Re: [Yxa-devel] SIP parser issue
On Tue, 2009-05-05 at 22:33 +0200, Krister Jarl wrote: ... > >They got more than one thing wrong though - correct formatting would > >include a leading whitespace on the second line too. > > > >Contact : ,\r\n sip:s...@192.168.0.3\r\n > > > >I note that they ALSO missed the comma. A bit much to fix at the > >receiving end instead of at the sending end, don't you think? > > > > Yes, of course. But if the line break were correct shouldn't the second > row be interpreted as a new header (possibly an extension header)? Yes, a new header - not another value of the Contact header. And sip:s...@192.168.0.3 is not a valid SIP header that I know of at least =). /Fredrik ___ Yxa-devel mailing list Yxa-devel@lists.su.se https://lists.su.se/mailman/listinfo/yxa-devel
Re: [Yxa-devel] SIP parser issue
> Hi! >> >> I've noted an issue regarding the parser in Yxa. >> >> Consider the following line: >> Contact: \rsip:s...@192.168.0.3\r\n >> >> Note the CR before the second URI. This seems to be an attempt to >> specify multiple Contact-headers, but they got it wrong. >> >> Yxa does not interpret this CR as a line terminator, which is mandated >> by RFC2543. Shouldn't Yxa accept this and send it out as Contact: >> \r\nsip:s...@192.168.0.3\r\n? > >I think maybe RFC3261 changed the rules for line breaks. Would have to >be checked. > >They got more than one thing wrong though - correct formatting would >include a leading whitespace on the second line too. > >Contact : ,\r\n sip:s...@192.168.0.3\r\n > >I note that they ALSO missed the comma. A bit much to fix at the >receiving end instead of at the sending end, don't you think? > Yes, of course. But if the line break were correct shouldn't the second row be interpreted as a new header (possibly an extension header)? /Krister >/Fredrik > ___ Yxa-devel mailing list Yxa-devel@lists.su.se https://lists.su.se/mailman/listinfo/yxa-devel
Re: [Yxa-devel] SIP parser issue
On Tue, 2009-05-05 at 19:10 +0200, Peter Fassberg wrote: ... > But according to Postels Law we shoud fix it at the receiving end > as well, if possible. :-) Propose a patch. I'm not sure it will be clean enough to adopt, but I'd love to be wrong. /Fredrik ___ Yxa-devel mailing list Yxa-devel@lists.su.se https://lists.su.se/mailman/listinfo/yxa-devel
Re: [Yxa-devel] SIP parser issue
Hi! > They got more than one thing wrong though - correct formatting would > include a leading whitespace on the second line too. > > Contact : ,\r\n sip:s...@192.168.0.3\r\n > > I note that they ALSO missed the comma. A bit much to fix at the > receiving end instead of at the sending end, don't you think? They must fix it at the sending end, but it is a Cisco/Linksys box and its a lot of them out there. But according to Postels Law we shoud fix it at the receiving end as well, if possible. :-) Best regards, -- Peter Fässberg E-mail: p...@leissner.se Leissner Data AB Box 912 461 29 TROLLHÄTTAN Telefon: 0520 - 300 00 Telefax: 0520 - 300 89 ___ Yxa-devel mailing list Yxa-devel@lists.su.se https://lists.su.se/mailman/listinfo/yxa-devel
Re: [Yxa-devel] SIP parser issue
On Tue, 2009-05-05 at 14:12 +0200, Krister Jarl wrote: > Hi! > > I've noted an issue regarding the parser in Yxa. > > Consider the following line: > Contact: \rsip:s...@192.168.0.3\r\n > > Note the CR before the second URI. This seems to be an attempt to > specify multiple Contact-headers, but they got it wrong. > > Yxa does not interpret this CR as a line terminator, which is mandated > by RFC2543. Shouldn't Yxa accept this and send it out as Contact: > \r\nsip:s...@192.168.0.3\r\n? I think maybe RFC3261 changed the rules for line breaks. Would have to be checked. They got more than one thing wrong though - correct formatting would include a leading whitespace on the second line too. Contact : ,\r\n sip:s...@192.168.0.3\r\n I note that they ALSO missed the comma. A bit much to fix at the receiving end instead of at the sending end, don't you think? /Fredrik ___ Yxa-devel mailing list Yxa-devel@lists.su.se https://lists.su.se/mailman/listinfo/yxa-devel
[Yxa-devel] SIP parser issue
Hi! I've noted an issue regarding the parser in Yxa. Consider the following line: Contact: \rsip:s...@192.168.0.3\r\n Note the CR before the second URI. This seems to be an attempt to specify multiple Contact-headers, but they got it wrong. Yxa does not interpret this CR as a line terminator, which is mandated by RFC2543. Shouldn't Yxa accept this and send it out as Contact: \r\nsip:s...@192.168.0.3\r\n? Best regards Krister ___ Yxa-devel mailing list Yxa-devel@lists.su.se https://lists.su.se/mailman/listinfo/yxa-devel
