Forget to mention that the version of the patch I've reviewd is RFC v2
Marwan
___
zathura mailing list
zathura@lists.pwmt.org
http://lists.pwmt.org/mailman/listinfo/zathura
, what's your suggestions, ideas (or maybe patches :-))?
And what's the final destiny of the periodic page reclaiming code?
Marwan Tanager (1):
Fix a horrible memory leak.
callbacks.c |3 +++
page-widget.c |9 +
page-widget.h |8
3 files changed, 20 insertions
---
callbacks.c |3 +++
page-widget.c |9 +
page-widget.h |8
3 files changed, 20 insertions(+)
diff --git a/callbacks.c b/callbacks.c
index 2c63945..89eacaf 100644
--- a/callbacks.c
+++ b/callbacks.c
@@ -102,6 +102,9 @@
On Sun, Mar 24, 2013 at 03:34:33PM +0100, Sebastian Ramacher wrote:
On 2013-03-24 07:28:03, Marwan Tanager wrote:
This patch tries to solve a serious problem with zathura leaking a
horrendous
amount of memory during scrolling through a document.
The problem is that the current way
This patch implements a page cache that is invalidated in a LRU fashion.
Pages are added to the cache as soon as they become visible. When the cache is
full and a new page that isn't in the cache becomes visible, the least recently
viewed page in the cache is evicted from memory and the new
This will not scroll the document when pressing 'f' or 'F', just to make the
behavior consistent with activating the inputbar using ':'.
---
shortcuts.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/shortcuts.c b/shortcuts.c
index 1de5ee6..04ec7e7 100644
--- a/shortcuts.c
+++
This fixes the bug of the page cache acting weird (e.g. the same cache index is
invalidated over and over again) after being used for some time. This is
because when we read the last-view property, we only get the least-significant
32 bits of the last_view private member.
---
page-widget.c |
On Tue, Apr 02, 2013 at 09:45:44PM +0200, Sebastian Ramacher wrote:
On 2013-03-25 04:14:25, Marwan Tanager wrote:
Also, I remember, that I hit a mem-leak recently when working on a
poster made with LaTeX. I was recompiling the same page over and over
again with LaTeX and I the memory
On Wed, Aug 28, 2013 at 11:30:48AM +0200, Moritz Lipp wrote:
Hi.
Personally, I have the same problem, and I don't know why it happens, so I
can't be very helpful on this one.
This works just fine for me under Arch Linux. In zathura we use the PRIMARY
selection which is conventionally
Tanager wrote:
On Thu, Aug 29, 2013 at 3:36 PM, Sebastian Ramacher sebasti...@pwmt.org
wrote:
On 2013-08-28 22:07:42, Marwan Tanager wrote:
On Wed, Aug 28, 2013 at 11:30:48AM +0200, Moritz Lipp wrote:
Hi.
Personally, I have the same problem, and I don't know why
From: Marawan Tanager marwan.t...@gmail.com
This patch adds a new configuration setting, selection-clipboard, which allows
us to choose between the PRIMARY selection, and the CLIPBOARD selection, for
determining which X clipboard to use for storing mouse-selected data. It has
only two valid
On Sat, Aug 31, 2013 at 01:14:43PM +0200, Sebastian Ramacher wrote:
the page widget now emits signals for text/image selection. zathura itself
now has callbacks to handle this events.
Yes. This is actually more clean and more modular.
--
Marwan
---
shortcuts.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/shortcuts.c b/shortcuts.c
index 1820a98..bb47d38 100644
--- a/shortcuts.c
+++ b/shortcuts.c
@@ -965,7 +965,7 @@ sc_search(girara_session_t* session, girara_argument_t*
argument,
continue;
}
-
Since we 'continue' the loop if num_search_results is 0, there is no need for
the second check.
---
shortcuts.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/shortcuts.c b/shortcuts.c
index bf43446..435d089 100644
--- a/shortcuts.c
+++ b/shortcuts.c
@@ -965,13
14 matches
Mail list logo
