[zathura] g_param_spec_int64 commit segfaults on my machine

Hi, The last commit in zathura's develop branch (1a145c5166cd834, "Use the 64-bit variants of g_param_spec_int ...) segfaults on my machine. I'm running Arch with gcc 4.7.2 and gtk 2.24.17. By the way, I posted some new issues (patches) on your bug tracker. Only after posting there I realized yo

[zathura] [PATCH] Fix zathura's bisect

^j and ^k) is not modified. Abdó Roig-Maranges >From dac4e9de439673ca5513c575c212c616160049d7 Mon Sep 17 00:00:00 2001 From: Abdo Roig-Maranges Date: Mon, 1 Jul 2013 23:53:53 +0200 Subject: [PATCH] Adapts bisect functionality to changes in the jumplist This recovers the old bisect behavi

Re: [zathura] [PATCH] Fix zathura's bisect

p are still the bounds for the bisection algorithm. About the attached patches: girara-list-insert.patch adds insert functionality to girara lists zathura-fix-bisect-v2.patch adds zathura_jumplist_insert + fixes bisect Abdó Roig-Maranges. >From 74c5c4f11f07059d5fb1f79332ae7a7da31bd45b Mo

Re: [zathura] [PATCH] Fix zathura's bisect

Hi, That looks quite good to me :) I attach a couple of patches changing some things, mainly simplifying the initial range setup. In detail: * added / fixed some comments * Simplified initial range setup. As we don't use the jumplist for state, we only need to look back one jump. I mean

[zathura] [PATCH] Fix zathura's odd window size issues in GTK3

Hi again, I think I've been able to fix the odd "huge-window" issue with GTK3. I attach a patch. Girara was hiding the scrollbars by setting GTK_POLICY_NEVER. It seems that, in GTK3, the ScrolledWindow container thinks that in such case he must fit the children size. I have fixed it by always se

[zathura] [PATCH] Initialize bisect state

A small fix for the bisect thing. When opening a new document at page 1, the bisect algorithm does not understand that it must begin a new bisect, and does not move from page 0 (the bisect struct is all initialized to 0's). The attached patch initializes the bisect range to 0, numpages-1, so that

Re: [zathura] [PATCH] Fix zathura's odd window size issues in GTK3

> Your changes broke commit 47830790a414720b77798e3af62350b8dbf677bc on girara > develop branch, which I've added a while ago to enable showing/hiding the > horizontal/vertical scrollbars independently from each others, while making > the > show-scrollbars setting sensitive to this (will be se

[zathura] [PATCH] Girara statusbar and inputbar fixes for GTK3

Hi again, I've done some changes on girara statusbar, inputbar and friends. It all started because on GTK3, notification and inputbar had different heights. I attach a patch with three commits: 1. reorganize widgets from statusbar inputbar and friends. Just put them all under a common c

Re: [zathura] [PATCH] Girara statusbar and inputbar fixes for GTK3

Hi > I think that once we get the GTK3 stuff working properly [1], we should just > get rid of the GTK2 support. ok > Oh, yeah, that's an ABI break. Do we need the new members anywhere outside of > girara? If not, I'd say we introduce a girara_session_private_s struct and add > a pointer to it

Re: [zathura] [PATCH] Girara statusbar and inputbar fixes for GTK3

Oops, sorry about that... > One of the bugs caused by the changes is http://bugs.pwmt.org/issue338. I attach a patch fixing the :info thing. A bit of a hack remains to set the statusbar height the same as the inputbar (session.c lines 284-291). Do you know of a better solution? The notification

Re: [zathura] [PATCH] Girara statusbar and inputbar fixes for GTK3

Hi, > I've attached two screenshots of zathura 0.2.4 running with girara 0.1.6 > and girara 0.1.7 plus the patch. With girara 0.1.6 there is a lot more > padding around the text in the statusbar and it's readable (maybe the > status bar is just too small in 0.1.7 and it's not the padding after >

[zathura] Don't let links chose the zoom for you

Hi, I encountered a weird pdf that wants to zoom out every time I follow a link from the index. I attach a patch that makes this "feature" configurable. Also I attach an other small patch that gets rid of a GTK deprecation warning. Abdó. >From d0c58face294de46915dc5de9fe553f0e31386ad Mon Sep 1

[zathura] Making page refreshes less prone to breaking

Hi, Tinkering with zathura I've been annoyed several times by the fragility of the page updates. They are prone to race conditions, due to the asynchronous nature of GTK. For instance, since the last GTK3 update zathura does not always refresh the page correctly when coming out of index mode. I

[zathura] [PATCH] pkg-config is not happy with --atleast-version

Hi, It seems that pkg-config complains when using --atleast-version together with --cflags or --libs. I attach a patch. Abdó. >From d01e128e7b4c2decb4d3a05e23b9b12cfda62879 Mon Sep 17 00:00:00 2001 From: Abdo Roig-Maranges Date: Sat, 26 Oct 2013 16:51:39 +0200 Subject: [PATCH] pkg-config compl

Re: [zathura] [PATCH] pkg-config is not happy with --atleast-version

> What version of pkg-config gives that message? But yes, it's broken. It > just get nothing at all. 0.28. Current pkg-config on arch linux. Abdó. ___ zathura mailing list zathura@lists.pwmt.org http://lists.pwmt.org/mailman/listinfo/zathura

Re: [zathura] Making page refreshes less prone to breaking

Hi, I got this in a stable state. I tried to attach the patches on a previous mail, but it was too big and got held up for moderation. So I've uploaded it on github. https://github.com/aroig/zathura What I have done is mainly restructure the code to cleanly separate document data from GTK stuff

Re: [zathura] [PATCH] Don't let links chose the zoom for you

Hi, After setting the scale, we need a render_all. Abdó. >From cb4fa03186794cb729a5adea14b853650db7584f Mon Sep 17 00:00:00 2001 From: Abdo Roig-Maranges Date: Sat, 26 Oct 2013 19:36:42 +0200 Subject: [PATCH] after a set_scale we need a render_all --- links.c | 1 + 1 file changed, 1 inserti

Re: [zathura] Making page refreshes less prone to breaking

Hi, > Maybe that's a bug that I haven't noticed so far or is introduced by > these changes: using the index to jump to some page, I always see the > first page. Moving around a little bit or zooming in/out displays the > correct page again. hmm... I can't reproduce this on the redo-page-refresh

Re: [zathura] [PATCH] Making page refreshes less prone to breaking

Hi, > So far I didn't find any issues, except for the one I reported on the bug > tracker regarding scale on the first page for a new document on gtk3. And right after that I found a little problem with link evaluation for some pdf's (the ones without page coordinates for the target). I attach a

[zathura] some fixes for the new synctex forward search

Hi, I attach some small fixes for the new synctex forward search functionality. Abdó. >From 922361bab36aef469766806cca12974e442ce99a Mon Sep 17 00:00:00 2001 From: Abdo Roig-Maranges Date: Fri, 17 Jan 2014 12:52:05 +0100 Subject: [PATCH 1/4] fix page range check In those cases, page is in the

Re: [zathura] some fixes for the new synctex forward search

Hi, > Thanks for the patches. Unfortunately, they do not apply (starting with > patch 2). Oops, sorry about that. I missed the first commit in the series. I attach the missing piece, which now should apply on top of current develop branch. Abdó. ___

Re: [zathura] some fixes for the new synctex forward search

abdo.r...@gmail.com writes: > Hi, > >> Thanks for the patches. Unfortunately, they do not apply (starting with >> patch 2). > > Oops, sorry about that. I missed the first commit in the series. I attach the > missing piece, which now should apply on top of current develop branch. And now I attach

[zathura] An other fix for synctex forward-search

Hi, Commit 5a992d2d460c0 introduced a type mismatch that breaks synctex forward search, failing with a DBus.Error.InvalidArgs. I attach a fix. Abdó. >From 48eb6481cfcb18d0d9da3d1cb7ff00d21a26ca27 Mon Sep 17 00:00:00 2001 From: Abdo Roig-Maranges Date: Sat, 18 Jan 2014 18:10:26 +0100 Subject:

Re: [zathura] jumplist-size option generates critical warning

Hi, >> There is a separator that appears in 2 places: around the input buffer in >> the statusbar, and between commands and descriptions in the completion menu. >> [...] > > This should be fixed in 8009f7e in girara's develop branch. I attach a patch removing the padding for the statusbar, whic