[Zeitgeist] [Bug 495392] Re: What to do if an event is not found or blocked when calling GetEvents (or its engine equivalent)

I think it looks good. The primary missing point is documentation. The DBus API needs to be documented in this regard. This also holds for the recent change with event id 0 indicates an error. It's ok to merge without it. If you don't get around to this it's ok - I'll try to remember doing it

[Zeitgeist] [Bug 495392] Re: What to do if an event is not found or blocked when calling GetEvents (or its engine equivalent)

Looks good. I suppose that just doing «NULL_EVENT = ([], [], )» instead of all this D-Bus fuss didn't work? Also, personally I'd change: = if event is None: continue event._make_dbus_sendable() = to: = if event: event._make_dbus_sendable() = But this is just nitpicking

[Zeitgeist] [Bug 495392] Re: What to do if an event is not found or blocked when calling GetEvents (or its engine equivalent)

I addressed both your comments in revision 1225, thanks for the review. -- What to do if an event is not found or blocked when calling GetEvents (or its engine equivalent) https://bugs.launchpad.net/bugs/495392 You received this bug notification because you are a member of Zeitgeist Developers,