Re: [Zeitgeist] [Merge] lp:~rainct/zeitgeist/collapse-uri into lp:zeitgeist

2012-03-06 Thread Michal Hruby
Review: Needs Fixing Looks really good, a couple of comments: 8 +#include cassert 25 +assert (g_checksum_type_get_length (G_CHECKSUM_MD5) == 16); We have glib for that (g_assert) ;) Let's also turn all the magic 16s into a const / #define. 88 +#include glib/gchecksum.h

[Zeitgeist] [Merge] lp:~rainct/zeitgeist/collapse-uri into lp:zeitgeist

2012-03-05 Thread Siegfried Gevatter
/collapse-uri/+merge/95994 Your team Zeitgeist Framework Team is requested to review the proposed merge of lp:~rainct/zeitgeist/collapse-uri into lp:zeitgeist. === modified file 'extensions/fts++/indexer.cpp' --- extensions/fts++/indexer.cpp 2012-02-14 16:56:04 + +++ extensions/fts++/indexer.cpp