[Zeitgeist] [Bug 495179] Re: What to do on failed or blocked event insertions?

2009-12-11 Thread Markus Korn
I'm preparing a branch with the solution proposed by Mikkel, as this solution has the best (making sense)/(breaking API) ratio. ** Changed in: zeitgeist Assignee: (unassigned) = Markus Korn (thekorn) -- What to do on failed or blocked event insertions?

[Zeitgeist] [Bug 495179] Re: What to do on failed or blocked event insertions?

2009-12-11 Thread Markus Korn
** Branch linked: lp:~thekorn/zeitgeist/zero_as_error -- What to do on failed or blocked event insertions? https://bugs.launchpad.net/bugs/495179 You received this bug notification because you are a member of Zeitgeist Framework, which is the registrant for Zeitgeist Framework. Status in

[Zeitgeist] [Bug 495179] Re: What to do on failed or blocked event insertions?

2009-12-11 Thread Mikkel Kamstrup Erlandsen
We could use negative integers as error indicators, but that would require that we break DBus API since we use uint32 (signatire u) as event _ids now. The alternative is to use 64 bit ints (signature x). It's not a big break though - transpararent in Python actually... Looking at your branch now.

[Zeitgeist] [Bug 495179] Re: What to do on failed or blocked event insertions?

2009-12-11 Thread Mikkel Kamstrup Erlandsen
If you rename _wrap_insert_event() to something like _insert_event_without_error() or something like that to indicate the purpose of the method I think the branch is fine to go in. -- What to do on failed or blocked event insertions? https://bugs.launchpad.net/bugs/495179 You received this bug

[Zeitgeist] [Bug 495179] Re: What to do on failed or blocked event insertions?

2009-12-11 Thread Markus Korn
thanks for your super fast code review. I've changed the method name and fixed some engine-testcases (Exceptions are not raised anymore, 0 is returned instead) If nobody complains until lunchtime I will merge this branch into lp:zeitgeist. This branch fixes only half of the issue, we also need a

[Zeitgeist] [Bug 495392] [NEW] What to do if an event is not found or blocked when calling GetEvents (or its engine equivalent)

2009-12-11 Thread Markus Korn
Public bug reported: Right now GetEvents raises a KeyError whenever any event is either not found or blocked by an extension. As good as this solution was in case of not found events it turns out to be bad for blocked events. I think there are two possible solutions: * adding a NULLEvent, a

[Zeitgeist] [Bug 495179] Re: What to do on failed or blocked event insertions?

2009-12-11 Thread Launchpad Bug Tracker
** Branch linked: lp:zeitgeist -- What to do on failed or blocked event insertions? https://bugs.launchpad.net/bugs/495179 You received this bug notification because you are a member of Zeitgeist Framework, which is the registrant for Zeitgeist Framework. Status in Zeitgeist Framework: Fix

[Zeitgeist] [Bug 495179] Re: What to do on failed or blocked event insertions?

2009-12-11 Thread Markus Korn
** Changed in: zeitgeist Status: Confirmed = Fix Committed -- What to do on failed or blocked event insertions? https://bugs.launchpad.net/bugs/495179 You received this bug notification because you are a member of Zeitgeist Framework, which is the registrant for Zeitgeist Framework.

[Zeitgeist] [Bug 495017] Re: AttributeError: 'NoneType' object has no attribute 'payload'

2009-12-11 Thread Siegfried Gevatter
** Changed in: zeitgeist Status: Fix Committed = Fix Released -- AttributeError: 'NoneType' object has no attribute 'payload' https://bugs.launchpad.net/bugs/495017 You received this bug notification because you are a member of Zeitgeist Framework, which is the registrant for Zeitgeist

[Zeitgeist] [Bug 495392] Re: What to do if an event is not found or blocked when calling GetEvents (or its engine equivalent)

2009-12-11 Thread Siegfried Gevatter
Looks good. I suppose that just doing ┬źNULL_EVENT = ([], [], )┬╗ instead of all this D-Bus fuss didn't work? Also, personally I'd change: = if event is None: continue event._make_dbus_sendable() = to: = if event: event._make_dbus_sendable() = But this is just nitpicking

[Zeitgeist] [Bug 494288] Re: apriori: get most used (websites/notes/documents/etc...)

2009-12-11 Thread Siegfried Gevatter
Okay, this is now merged into lp:zeitgeist (after doing some more changes and having Markus review it again), but of course this doesn't mean that we can't continue improving it there (all the opposite!). You are right. I think a hybrid approach would give the best results Yeah. But for this we

[Zeitgeist] [Bug 494288] Re: apriori: get most used (websites/notes/documents/etc...)

2009-12-11 Thread Launchpad Bug Tracker
** Branch linked: lp:zeitgeist -- apriori: get most used (websites/notes/documents/etc...) https://bugs.launchpad.net/bugs/494288 You received this bug notification because you are a member of Zeitgeist Developers, which is the registrant for Zeitgeist Framework. Status in Zeitgeist Framework:

[Zeitgeist] [Bug 495392] Re: What to do if an event is not found or blocked when calling GetEvents (or its engine equivalent)

2009-12-11 Thread Markus Korn
I addressed both your comments in revision 1225, thanks for the review. -- What to do if an event is not found or blocked when calling GetEvents (or its engine equivalent) https://bugs.launchpad.net/bugs/495392 You received this bug notification because you are a member of Zeitgeist Developers,