Re: [Zeitgeist] [Bug 695003] [NEW] Bzr data-source doens't use different uri for different events on same branch

2011-01-05 Thread Mikkel Kamstrup Erlandsen
Agreed. If the URI is carefully constructed GAJ (and others) could even pull out the commit message to show in a tooltip etc... Maybe use a bzr: URN scheme like bzr:file:///home/mikkel/myproject/trunk#27 bzr:bzr+ssh://bazaar.launchpad.net/~kamstrup/dee/foobar#68 Or don't use the bzr: URN, bu

[Zeitgeist] [Bug 695003] Re: Bzr datasource doesn't use different uri for different events on the same branch

2011-01-05 Thread Stefano Candori
The bzr: URN sounds good to me, because doing that we have different uris and we don't have to compare text. Anyway the URL thing doesn't work: a COMMIT on a branch it's not a PUSH. So if the user only commits we don't have an URL suitable for the URI...but i could be wrong. In conclusion: +1 b

[Zeitgeist] [Bug 695003] Re: Bzr datasource doesn't use different uri for different events on the same branch

2011-01-05 Thread Michal Hruby
> bzr:file:///home/mikkel/myproject/trunk#27 I disagree, not even bzr itself would understand this notation, which means special-casing it in each and every zg client. > file:///home/mikkel/myproject/trunk#27 This is a perfectly valid file (directory) name, with one little problem that it does

[Zeitgeist] [Bug 695003] Re: Bzr datasource doesn't use different uri for different events on the same branch

2011-01-05 Thread Stefano Candori
Yes, it's a special casing and GAJ and other clients must handle it...anyway also comparing the text is a plus operation that GAJ should do. Concluding, in every case the client should handle bzr event in a different way; we only have to decide what's the "less invasive". -- You received this b

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bug695311 into lp:zeitgeist

2011-01-05 Thread Siegfried Gevatter
I haven't checked, but Zeitgeist should be receiving a SIGTERM at system poweroff (and it's also the default signal sent by "kill"). This way we try to ensure that Zeitgeist always ends nicely (ie. mostly always other than if there's an uncached exception or a SIGKILL). -- https://code.launchpa

Re: [Zeitgeist] [Bug 695003] Re: Bzr datasource doesn't use different uri for different events on the same branch

2011-01-05 Thread Mikkel Kamstrup Erlandsen
On 5 January 2011 12:38, Michal Hruby wrote: >>  file:///home/mikkel/myproject/trunk#27 > > This is a perfectly valid file (directory) name, with one little problem > that it doesn't exist. This is *not* a file name. It is a URI. Let's keep the terminology correct here. It has path member being /

Re: [Zeitgeist] [Bug 695003] Re: Bzr datasource doesn't use different uri for different events on the same branch

2011-01-05 Thread Mikkel Kamstrup Erlandsen
On 5 January 2011 15:43, Mikkel Kamstrup Erlandsen wrote: > On 5 January 2011 12:38, Michal Hruby wrote: >>>  file:///home/mikkel/myproject/trunk#27 >> >> This is a perfectly valid file (directory) name, with one little problem >> that it doesn't exist. > > This is *not* a file name. It is a URI.

Re: [Zeitgeist] [Bug 695003] Re: Bzr datasource doesn't use different uri for different events on the same branch

2011-01-05 Thread Siegfried Gevatter
Mikkel: I agree 100% on this :). -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Data-Sources. https://bugs.launchpad.net/bugs/695003 Title: Bzr datasource doesn't use different uri for different events on the same b

Re: [Zeitgeist] [Bug 695003] Re: Bzr datasource doesn't use different uri for different events on the same branch

2011-01-05 Thread Stefano Candori
Well, now that have that info, i think we should have to choose the idea of Mikkel. Michal is it ok for you? 2011/1/5 Mikkel Kamstrup Erlandsen > On 5 January 2011 15:43, Mikkel Kamstrup Erlandsen > wrote: > > On 5 January 2011 12:38, Michal Hruby wrote: > >>> file:///home/mikkel/myproject/tr

[Zeitgeist] [Bug 695003] Re: Bzr datasource doesn't use different uri for different events on the same branch

2011-01-05 Thread Michal Hruby
>This is *not* a file name. It is a URI. Let's keep the terminology > correct here. It has path member being /home/mikkel/myproject/trunk > and has a URI fragment of 27. Please see > http://labs.apache.org/webarch/uri/rfc/rfc3986.html#components. I learn something new every day too, in this case I

[Zeitgeist] [Bug 695003] Re: Bzr datasource doesn't use different uri for different events on the same branch

2011-01-05 Thread Stefano Candori
** Changed in: zeitgeist-dataproviders Assignee: (unassigned) => Stefano Candori (cando) ** Changed in: zeitgeist-dataproviders Status: Confirmed => In Progress -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeis