Seif Lotfy has proposed merging lp:~seif/zeitgeist/bluebird-enums into
lp:~zeitgeist/zeitgeist/bluebird.
Requested reviews:
Zeitgeist Framework Team (zeitgeist)
For more details, see:
https://code.launchpad.net/~seif/zeitgeist/bluebird-enums/+merge/69344
Add enums
--
https://code.launchpad.n
Review: Approve
Sure, feel free add the other enums and push.
Some stupid nitpicking like usual:
I'd limit lines to max. 80 characters each, ie. here writing it like:
// comment
// ... more comment
MostRecentEvents,
Or maybe:
MostRecentEvents // comment
// ... more comment
Manish Sinha (मनीष सिन्हा) has proposed merging
lp:~manishsinha/zeitgeist/bluebird-fix-datamodel-properties into
lp:~zeitgeist/zeitgeist/bluebird.
Requested reviews:
Zeitgeist Framework Team (zeitgeist)
For more details, see:
https://code.launchpad.net/~manishsinha/zeitgeist/bluebird-fix-data
Review: Approve
--
https://code.launchpad.net/~manishsinha/zeitgeist/bluebird-fix-datamodel-properties/+merge/69348
Your team Zeitgeist Framework Team is subscribed to branch
lp:~zeitgeist/zeitgeist/bluebird.
___
Mailing list: https://launchpad.net/~z
It's looking like this now (and still exceding 80 chars):
FooBar // comment
// more
Fo // comment
// more..
What I meant is:
FooBar // comment
// more...
Fo // comment
// more...
Also there's spaces missing, eg. "orderedascendingly"
The proposal to merge
lp:~manishsinha/zeitgeist/bluebird-fix-datamodel-properties into
lp:~zeitgeist/zeitgeist/bluebird has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~manishsinha/zeitgeist/bluebird-fix-datamodel-properties/+merge/69348
--
The proposal to merge lp:~seif/zeitgeist/bluebird-enums into
lp:~zeitgeist/zeitgeist/bluebird has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~seif/zeitgeist/bluebird-enums/+merge/69344
--
https://code.launchpad.net/~seif/zeitgeist/bluebird
7 matches
Mail list logo
