Michal Hruby has proposed merging lp:~mhr3/zeitgeist/bb-schema-ver-table into
lp:~zeitgeist/zeitgeist/bluebird.
Requested reviews:
Zeitgeist Framework Team (zeitgeist)
For more details, see:
https://code.launchpad.net/~mhr3/zeitgeist/bb-schema-ver-table/+merge/79928
--
https://code.launchpa
Review: Approve
I like it a lot... Are we sure we don't want to upgrade from anything where
core_schema < 4 ?
Other than that +1
--
https://code.launchpad.net/~mhr3/zeitgeist/bb-schema-ver-table/+merge/79928
Your team Zeitgeist Framework Team is subscribed to branch
lp:~zeitgeist/zeitgeist/blue
Review: Needs Fixing
Hey!
Looks really nice. Here's some pedantic comments:
- Shouldn't we abort if the database backup can't be created?
- It'd make more sense for get_schema_version to be private, I don't think
it's needed anywhere outside.
- Can you please preserve the comment we had in
revno: 319
committer: Siegfried-Angel Gevatter Pujals
branch nick: bluebird
timestamp: Thu 2011-10-20 13:20:36 +0200
message:
Remove the post_get_events in prevision of possible direct-access.
modified:
.bzrignore
NEWS
src/engine
Review: Approve
The line «throw new EngineError.DATABASE_ERROR ("Unable to upgrade from schema»
is longer than 80 chars. And there's a typo in my comment ("appriopriate" ->
"appropriate") :P.
--
https://code.launchpad.net/~mhr3/zeitgeist/bb-schema-ver-table/+merge/79928
Your team Zeitgeist Fram
Merge authors:
Michal Hruby (mhr3)
Related merge proposals:
https://code.launchpad.net/~mhr3/zeitgeist/bb-schema-ver-table/+merge/79928
proposed by: Michal Hruby (mhr3)
review: Approve - Siegfried Gevatter (rainct)
review: Approve - Seif Lotfy (seif)
--
The proposal to merge lp:~mhr3/zeitgeist/bb-schema-ver-table into
lp:~zeitgeist/zeitgeist/bluebird has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~mhr3/zeitgeist/bb-schema-ver-table/+merge/79928
--
https://code.launchpad.net/~mhr3/zeitgeis
revno: 321
committer: Michal Hruby
branch nick: bb-fts
timestamp: Thu 2011-10-20 16:20:17 +0200
message:
Handle null events in event array properly
modified:
extensions/blacklist.vala
src/notify.vala
src/zeitgeist-daemon.vala
-
Public bug reported:
When using the ZeitgeistSearch gnome-shell extension, there is a silent
error that occurs in activateResult for the App- and Settings-
AsyncSearchProviders. This is due to a call to Params, which hasn't
been defined. I've attached a patch which solves this particular
problem
** Patch added: "Patch to include aliasing imports.misc.Params as Params"
https://bugs.launchpad.net/bugs/879146/+attachment/2563650/+files/zeitgeistsearch.patch
--
You received this bug notification because you are a member of Zeitgeist
Extensions, which is the registrant for Zeitgeist Exten
10 matches
Mail list logo
