[Zeitgeist] [Bug 486996] Re: testInsertGetWithoutTimestamp testcase fails

2009-11-24 Thread Mikkel Kamstrup Erlandsen
Fixed in r1158 ** Changed in: zeitgeist Status: Triaged => Fix Released -- testInsertGetWithoutTimestamp testcase fails https://bugs.launchpad.net/bugs/486996 You received this bug notification because you are a member of Zeitgeist-Engine, which is the registrant for Zeitgeist Engine. St

Re: [Zeitgeist] [Bug 486996] Re: testInsertGetWithoutTimestamp testcase fails

2009-11-23 Thread Seif Lotfy
@Mikkel: OK I get ur point :) 2009/11/23 Mikkel Kamstrup Erlandsen > @Seif: I wouldn't have to care about the timestamp format when sending > events if my app doesn't need high precision timing. Just create the > Event instance and send it along. Recall that not all apps will be > written in Pyt

[Zeitgeist] [Bug 486996] Re: testInsertGetWithoutTimestamp testcase fails

2009-11-23 Thread Mikkel Kamstrup Erlandsen
@Seif: I wouldn't have to care about the timestamp format when sending events if my app doesn't need high precision timing. Just create the Event instance and send it along. Recall that not all apps will be written in Python and using our client libs... -- testInsertGetWithoutTimestamp testcase f

Re: [Zeitgeist] [Bug 486996] Re: testInsertGetWithoutTimestamp testcase fails

2009-11-23 Thread Seif Lotfy
which convenience 2009/11/23 Mikkel Kamstrup Erlandsen > @Seif: I think we can allow empty timestamps for convenience. And as I > said in comment 1 paragraph 3; we meassure time in milliseconds, hence > timestamps are genrated with int(time.time()*1000). > > -- > testInsertGetWithoutTimestamp te

[Zeitgeist] [Bug 486996] Re: testInsertGetWithoutTimestamp testcase fails

2009-11-23 Thread Mikkel Kamstrup Erlandsen
@Seif: I think we can allow empty timestamps for convenience. And as I said in comment 1 paragraph 3; we meassure time in milliseconds, hence timestamps are genrated with int(time.time()*1000). -- testInsertGetWithoutTimestamp testcase fails https://bugs.launchpad.net/bugs/486996 You received thi

[Zeitgeist] [Bug 486996] Re: testInsertGetWithoutTimestamp testcase fails

2009-11-23 Thread Seif Lotfy
We should not even allow empty timestamps in. But if you guys think we should then an empty timestamp means we should generate one using time.time() and insert it into the DB. What do u think? -- testInsertGetWithoutTimestamp testcase fails https://bugs.launchpad.net/bugs/486996 You received this

[Zeitgeist] [Bug 486996] Re: testInsertGetWithoutTimestamp testcase fails

2009-11-23 Thread Markus Korn
** Changed in: zeitgeist Status: New => Triaged -- testInsertGetWithoutTimestamp testcase fails https://bugs.launchpad.net/bugs/486996 You received this bug notification because you are a member of Zeitgeist-Engine, which is the registrant for Zeitgeist Engine. Status in Zeitgeist Engine:

[Zeitgeist] [Bug 486996] Re: testInsertGetWithoutTimestamp testcase fails

2009-11-23 Thread Mikkel Kamstrup Erlandsen
I think a nice default is to use the timestamp of object creation time. That was the idea behind the test at least, and indeed it also worked like that at some point (where the test worked). Otoh - the engine will use the current time as timestamp if the incoming event doesn't have one, so it might