[Zeitgeist] [Bug 566184] Re: Deletes are not committed
** Changed in: zeitgeist Status: Fix Committed => Fix Released -- Deletes are not committed https://bugs.launchpad.net/bugs/566184 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. Status in Zeitgeist Framework: Fix Released Bug description: When we do engine.delete_events(ids) we never call commit() on the sqlite3 connection. This means that if the engine is shut down before we've committed because of other circumstances (eg. insert_events()) then the deleted items will reappear ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 566184] Re: Deletes are not committed
Thanks, I just uploaded a fix to your issue Seif. It was an odd corner case where we'd mistakingly assume that we didn't have any events for the given ids if all the deleted events had timestamp 0. This was because we used the builtin method all() to check the timestamps... -- Deletes are not committed https://bugs.launchpad.net/bugs/566184 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. Status in Zeitgeist Framework: Fix Committed Bug description: When we do engine.delete_events(ids) we never call commit() on the sqlite3 connection. This means that if the engine is shut down before we've committed because of other circumstances (eg. insert_events()) then the deleted items will reappear ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
Re: [Zeitgeist] [Bug 566184] Re: Deletes are not committed
i now get == FAIL: testDeleteSingle (__main__.ZeitgeistEngineTest) -- Traceback (most recent call last): File "test/engine-test.py", line 127, in testDeleteSingle self.assertEquals(0, len(filter(None, result))) AssertionError: 0 != 1 On Sun, Apr 18, 2010 at 9:56 PM, Mikkel Kamstrup Erlandsen < mikkel.kamst...@gmail.com> wrote: > Fixed in r1415 > > -- > Deletes are not committed > https://bugs.launchpad.net/bugs/566184 > You received this bug notification because you are subscribed to The > Zeitgeist Project. > > Status in Zeitgeist Framework: Fix Committed > > Bug description: > When we do engine.delete_events(ids) we never call commit() on the sqlite3 > connection. This means that if the engine is shut down before we've > committed because of other circumstances (eg. insert_events()) then the > deleted items will reappear > > > > -- Deletes are not committed https://bugs.launchpad.net/bugs/566184 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. Status in Zeitgeist Framework: Fix Committed Bug description: When we do engine.delete_events(ids) we never call commit() on the sqlite3 connection. This means that if the engine is shut down before we've committed because of other circumstances (eg. insert_events()) then the deleted items will reappear ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 566184] Re: Deletes are not committed
Fixed in r1415 -- Deletes are not committed https://bugs.launchpad.net/bugs/566184 You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. Status in Zeitgeist Framework: Fix Committed Bug description: When we do engine.delete_events(ids) we never call commit() on the sqlite3 connection. This means that if the engine is shut down before we've committed because of other circumstances (eg. insert_events()) then the deleted items will reappear ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
