[Zeitgeist] [Merge] lp:~malizor/activity-log-manager/fix-967150 into lp:activity-log-manager

2012-12-06 Thread noreply
The proposal to merge lp:~malizor/activity-log-manager/fix-967150 into 
lp:activity-log-manager has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~malizor/activity-log-manager/fix-967150/+merge/125556
-- 
https://code.launchpad.net/~malizor/activity-log-manager/fix-967150/+merge/125556
Your team Activity Log Manager is subscribed to branch lp:activity-log-manager.

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


Re: [Zeitgeist] [Merge] lp:~malizor/activity-log-manager/fix-967150 into lp:activity-log-manager

2012-12-06 Thread Didier Roche
Review: Approve

Looking good, Thanks Nicolas :)

Better to merge now so that on next release, people will have time to translate 
it.
-- 
https://code.launchpad.net/~malizor/activity-log-manager/fix-967150/+merge/125556
Your team Activity Log Manager is subscribed to branch lp:activity-log-manager.

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Merge] lp:~malizor/activity-log-manager/fix-967150 into lp:activity-log-manager

2012-09-20 Thread Nicolas Delvaux
Nicolas Delvaux has proposed merging 
lp:~malizor/activity-log-manager/fix-967150 into lp:activity-log-manager.

Requested reviews:
  Activity Log Manager (activity-log-manager)
Related bugs:
  Bug #967150 in Activity Log Manager: "Can not add the space character in the 
title"
  https://bugs.launchpad.net/activity-log-manager/+bug/967150

For more details, see:
https://code.launchpad.net/~malizor/activity-log-manager/fix-967150/+merge/125556

The "Forget activities" string was separated from its colon.
Because of a Rosetta bug, this led to bad translations (eg. in French, 
impossible to add a space between the string and the colon).

This patch has zero regression potential, but it creates a new string.
So this means translations have to be updated accordingly, which is the point 
of the related bug anyway (to be able to translate this string properly).
-- 
https://code.launchpad.net/~malizor/activity-log-manager/fix-967150/+merge/125556
Your team Activity Log Manager is requested to review the proposed merge of 
lp:~malizor/activity-log-manager/fix-967150 into lp:activity-log-manager.
=== modified file 'src/history-widget.vala'
--- src/history-widget.vala	2012-03-18 09:11:52 +
+++ src/history-widget.vala	2012-09-20 17:37:35 +
@@ -58,7 +58,7 @@
 
 			var text_box = new Box(orientation=Orientation.VERTICAL, 0);
 			var header = new Label("");
-			header.set_markup("%s:".printf(_("Forget activities")));
+			header.set_markup("%s".printf(_("Forget activities:")));
 			header.set_alignment(0, (float)0.5);
 			header.set_padding(0, 0);
 			

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp