Re: [Zeitgeist] [Merge] lp:~seif/zeitgeist/bluebird-enums into lp:~zeitgeist/zeitgeist/bluebird

2011-07-26 Thread Siegfried Gevatter 
It's looking like this now (and still exceding 80 chars):

FooBar // comment
  // more

Fo // comment
  // more..

What I meant is:

FooBar // comment
   // more...
Fo // comment
   // more...

Also there's spaces missing, eg. "orderedascendingly".
-- 
https://code.launchpad.net/~seif/zeitgeist/bluebird-enums/+merge/69344
Your team Zeitgeist Framework Team is subscribed to branch 
lp:~zeitgeist/zeitgeist/bluebird.

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp

Re: [Zeitgeist] [Merge] lp:~seif/zeitgeist/bluebird-enums into lp:~zeitgeist/zeitgeist/bluebird

2011-07-26 Thread Siegfried Gevatter 
Review: Approve
Sure, feel free add the other enums and push.

Some stupid nitpicking like usual:

I'd limit lines to max. 80 characters each, ie. here writing it like:

// comment
// ... more comment
MostRecentEvents,

Or maybe:

MostRecentEvents   // comment
   // ... more comment

(But in the later case I'd have all comments intented to start at the same 
column so it looks nice.)

Also you're removing a valid intentation newline before the closing "}" of the 
Event class (diff line 57).
-- 
https://code.launchpad.net/~seif/zeitgeist/bluebird-enums/+merge/69344
Your team Zeitgeist Framework Team is subscribed to branch 
lp:~zeitgeist/zeitgeist/bluebird.

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp