Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bb-extensions-conf into lp:~zeitgeist/zeitgeist/bluebird

2011-09-25 Thread Michal Hruby 
Review: Approve

1) I'd get rid of the get_name method, we can just use get_type().name()
2) if the extension needed something special, store/retrieve could be virtual

Other than that it looks fine, feel free to merge!
-- 
https://code.launchpad.net/~zeitgeist/zeitgeist/bb-extensions-conf/+merge/76902
Your team Zeitgeist Framework Team is subscribed to branch 
lp:~zeitgeist/zeitgeist/bluebird.

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bb-extensions-conf into lp:~zeitgeist/zeitgeist/bluebird

2011-09-25 Thread Siegfried Gevatter 
Great. Thanks for the review.

1) Changed, wasn't quite happy with get_name.
2) I'd rather not, if they really need to do something weird they can add a new 
function.
-- 
https://code.launchpad.net/~zeitgeist/zeitgeist/bb-extensions-conf/+merge/76902
Your team Zeitgeist Framework Team is subscribed to branch 
lp:~zeitgeist/zeitgeist/bluebird.

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp