Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bluebird-sig-crash into lp:zeitgeist

2012-01-25 Thread Siegfried Gevatter 
(Moving to 
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird-sig-crash2/+merge/90166)
-- 
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird-sig-crash/+merge/74091
Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bluebird-sig-crash into lp:zeitgeist

2012-01-25 Thread Michal Hruby 
Also, some tests pls...
-- 
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird-sig-crash/+merge/74091
Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bluebird-sig-crash into lp:zeitgeist

2012-01-25 Thread Michal Hruby 
Review: Needs Fixing

156  assert (event_variant.get_type_string () == "(" +
157  Utils.SIG_EVENT + ")");

Let's turn this into assert_sig as well.

161 -assert (iter.n_children () >= 3);

Shouldn't this throw the error as well, instead of just removing it?

-- 
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird-sig-crash/+merge/74091
Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp

Re: [Zeitgeist] [Merge] lp:~zeitgeist/zeitgeist/bluebird-sig-crash into lp:zeitgeist

2011-12-30 Thread Michal Hruby 
Review: Needs Fixing

Let's change the warn_if_fail to the assert_sig and merge this
-- 
https://code.launchpad.net/~zeitgeist/zeitgeist/bluebird-sig-crash/+merge/74091
Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist.

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp