[zfs-code] Code review request: new features and misc fixes

2006-08-31 Thread Eric Schrock
Thanks. Eric Kustarz has also done a thorough review, so don't sweat it if you can't get to everything. On Thu, Aug 31, 2006 at 03:41:30PM -0600, Mark Shellenbaum wrote: > > zfs_main.c > >Should use strlcpy() instead of strcpy() in get_callback(). Sure thing. >What are your plans for

[zfs-code] Code review request: new features and misc fixes

2006-08-31 Thread Mark Shellenbaum
> > Webrev at: > > http://cr.grommit.com/~eschrock/zfs-prop/ > I haven't looked at all of it, but here is what I've noticed. zfs_main.c Should use strlcpy() instead of strcpy() in get_callback(). What are your plans for ZFS_ABORT env variable? You should probably remove it befo

[zfs-code] Code review request: new features and misc fixes

2006-08-31 Thread Eric Schrock
Good point. The current 'canmount' property is never accessed in the kernel via dsl_prop_get_impl(), but future DSL-stored non-inheritable properties might be. I'll add the logic to dsl_prop_get_impl() as well. - Eric On Wed, Aug 30, 2006 at 05:41:32PM -0700, Matthew Ahrens wrote: > Eric Schroc