RE: [ZODB-Dev] RE: RE: PersistentMapping
[Thomas Lotze] ZODB/branches/3.5 My newly added tests for PersistentMapping break here; PersistentMapping seems to lack __iter__. (PersistentMapping hadn't been tested at all before.) The suite passes fine on the trunk and the 3.4 and 3.6 branches, but it fails on 3.5. Should __iter__ be added to the 3.5 PersistentMapping, or is it missing for a reason? Looks it got lost in the branches. PersistentMapping.__iter__ was added in ZODB 3.4.2, just this August: http://mail.zope.org/pipermail/zodb-checkins/2005-August/010225.html Log message for revision 38076: Gave PersistentMapping an __iter__ method. Also gave it some tests (it was woefully untested). ... That got merged to the trunk (at the time) right away: http://mail.zope.org/pipermail/zodb-checkins/2005-August/010226.html Looks like the 3.5 branch got overlooked. Merging rev 38076 from 3.4 branch to 3.5 branch would be fine. ___ For more information about ZODB, see the ZODB Wiki: http://www.zope.org/Wikis/ZODB/ ZODB-Dev mailing list - ZODB-Dev@zope.org http://mail.zope.org/mailman/listinfo/zodb-dev
Re: [ZODB-Dev] RE: RE: PersistentMapping
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Tim Peters wrote: So I tried that just now using ZODB trunk. It failed too, but with different symptoms than you're describing: $ python2.4 setup.py build ... $ python2.4 test.py -v Running tests from build/lib.linux-i686-2.4 Traceback (most recent call last): File test.py, line 40, in ? from zope.testing import testrunner ImportError: No module named zope.testing $ I never do setup.py build myself, so I was only mildly surprised by that. It should probably be fixed ;-) Note I added couple of weeks ago a comment about this within the README.txt of ZODB. To test the build, first build the externals and add the src dir to your PYTHONPATH, % python setup.py build_ext -i % export PYTHONPATH=`pwd`/src:$PYTHONPATH Then run the test script:: % python test.py Cheers, J. - -- Julien Anguenot | Nuxeo RD (Paris, France) CPS Platform : http://www.cps-project.org Zope3 / ECM : http://www.z3lab.org mail: anguenot at nuxeo.com; tel: +33 (0) 6 72 57 57 66 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.1 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFDffbbGhoG8MxZ/pIRAmLCAJ9Pjq4FqgbHIOI11V5zyfjONf3xMACfbEmO RV9RuLydwQvLEz/VAUZT2k4= =vNBY -END PGP SIGNATURE- ___ For more information about ZODB, see the ZODB Wiki: http://www.zope.org/Wikis/ZODB/ ZODB-Dev mailing list - ZODB-Dev@zope.org http://mail.zope.org/mailman/listinfo/zodb-dev
RE: [ZODB-Dev] RE: RE: PersistentMapping
[Tim] ... BTW, setup.py build python test.py should work too; it's a bug that it doesn't (and it worked fine within the last few months), but I don't have time for it now. Well, bug or not, the resident zpkgtools expert tells me he doesn't expect that to work anymore, and that it would take more work than _he_ has time for to try to make it work again. setup.py build is only intended to work from a distribution now, no longer from a checkout. So, README.txt should lose the parts that recommend setup.py build; setup.py build_ext -i is necessary now. ___ For more information about ZODB, see the ZODB Wiki: http://www.zope.org/Wikis/ZODB/ ZODB-Dev mailing list - ZODB-Dev@zope.org http://mail.zope.org/mailman/listinfo/zodb-dev
RE: [ZODB-Dev] RE: RE: PersistentMapping
[Julien] Well I'm not sure it works Tim. My comment was to be able to test the build *before* installing the ZODB on the Python. Right, and that's the way ZODB tests are normally run by everyone who works on ZODB (they never _install_ ZODB to run tests). I need to try that again but, if I remember correctly, without the PYTHONPATH update it didn't work out for me. Works for me ;-) A possible difference is that you stuffed ZODB/src at the front of PYTHONPATH, but test.py appends ZODB/src to the end of sys.path. If you have other ZODB or Zope code on sys.path (I never do when I run ZODB tests), your way might be effective at hiding the installed code from ZODB's test.py. I'm not sure. Please figure out whether that's the case in the way you run this stuff. If it is, ZODB's test.py could be changed to prepend ZODB/src instead. BTW, setup.py build python test.py should work too; it's a bug that it doesn't (and it worked fine within the last few months), but I don't have time for it now. right. See later email about that (apparently it's not intended to work anymore -- this is a zpkgtools thing). ___ For more information about ZODB, see the ZODB Wiki: http://www.zope.org/Wikis/ZODB/ ZODB-Dev mailing list - ZODB-Dev@zope.org http://mail.zope.org/mailman/listinfo/zodb-dev
