Tim Peters wrote:
Bless you! Alas, I haven't received any messages from any Zope Corp checkin
list since Sunday, so we'll just have to take your word for it .
svn diff -r 33279:33280 \
svn+ssh://svn.zope.org/repos/main/Zope/branches/Zope-2_8-branch
[Jim Fulton]
>> A good community project would be to convert all of the subtransaction
>> calls in Zope to savepoint calls.
[Christian Heimes]
> Done
>
> I found commit(1) in Zope3 zope.app.file.file Pdata handling and in code
> and tests in Zope2.
Bless you! Alas, I haven't received any message
[Tim Peters]
...
>> I'm not sure I follow this: old code could not be using savepoints
>> directly, so what would break in code that stuck solely to subtxn
>> commits?
> ...
>> So I don't see how backward compatibility would be injured. BTW, I
>> tried it, and all the ZODB tests pass with this ch
Jim Fulton wrote:
A good community project would be
to convert all of the subtransaction calls in Zope to
savepoint calls.
Done
I found commit(1) in Zope3 zope.app.file.file Pdata handling and in code
and tests in Zope2.
Christian
___
For more i
Tim Peters wrote:
[Christian Heimes, suggests changing Transaction.commit() to start with
if subtransaction:
# TODO deprecate subtransactions
self._subtransaction_savepoint = self.savepoint(1)
return
if self._savepoint2index:
self.
[Christian Heimes, suggests changing Transaction.commit() to start with
if subtransaction:
# TODO deprecate subtransactions
self._subtransaction_savepoint = self.savepoint(1)
return
if self._savepoint2index:
self._invalidate_all_save
Christian Heimes wrote:
Tim Peters wrote:
...
Nesting savepoints works according to your test and I really believe you
that they work in real live. Honestly! :)
But there is some evil code in transaction/ that is destroying
savepoints for my use case. Committing a subtransaction using the ol
Tim Peters wrote:
Today I stumbled over an unexpected behavior of savepoints. As far as I'm
able to understand savepoints they mark a well defined state in the
middle of a transaction.
A savepoint is invalid if its transaction is committed
or another savepoint is created.
No, that's not the in
Jim Fulton wrote:
From my point of view I can't see a reason why the ZODB forbids a
second rolback to the savepoint.
I agree. This should be changed.
Great!
HTH :)
Christian
___
For more information about ZODB, see the ZODB Wiki:
http://www.zop
