-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Tim Peters wrote:
> [Julien Anguenot]
>
>>I renamed those arguments in both methods.
>>
>>How can we solve this 2 methods problem ? Deprecation of the old one ? Or
>>can we live like this ?
>
>
> I think this would leave us in the best state:
>
> 1. Deprecate beforeCommitHook(), to be subsumed by #2.
>
> 2. Change the name of your new function to, e.g., addBeforeCommitHook()
>or registerBeforeCommitHook(), and change its signature to
>
> hook, args=(), kws=None, order=0
>
> The mechanics of deprecation are clumsy, but don't worry about #1 -- if we
> can agree this is the best outcome, I'll do the deprecation coding+testing.
>
ok I changed it as you mentionned above + the use of a global index on
the transaction for the bisect. Like this the complexity is removed.
For the deprecations, I checked a little bit and I saw you're having
lots of custom warnings utils so I'll let you cope with this one ;)
J.
- --
Julien Anguenot | Nuxeo R&D (Paris, France)
CPS Platform : http://www.cps-project.org
Zope3 / ECM : http://www.z3lab.org
mail: anguenot at nuxeo.com; tel: +33 (0) 6 72 57 57 66
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
iD8DBQFC+z4RGhoG8MxZ/pIRAs2kAJ9GIvfRDe5K6vpNY3tapOKRkStJ7ACeIF1K
bt8gejkA+6QPHSXPLN5WlQA=
=+eR0
-END PGP SIGNATURE-
___
For more information about ZODB, see the ZODB Wiki:
http://www.zope.org/Wikis/ZODB/
ZODB-Dev mailing list - ZODB-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zodb-dev