Re: [zones-discuss] codereview for 6914152 (zonecfg)

2010-02-19 Thread Jerry Jelinek
On 02/19/10 06:53, Frank Batschulat (Home) wrote: May I request 2 code reviewers for the changes for: 6914152 zonecfg fails when less(1M) is missing http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6914152 http://cr.opensolaris.org/~batschul/zpager/ Frank, This looks fine to me.

Re: [zones-discuss] codereview for 6914152 (zonecfg)

2010-02-19 Thread Frank Batschulat (Home)
On Fri, 19 Feb 2010 15:39:21 +0100, Jerry Jelinek gerald.jeli...@sun.com wrote: On 02/19/10 06:53, Frank Batschulat (Home) wrote: May I request 2 code reviewers for the changes for: 6914152 zonecfg fails when less(1M) is missing

Re: [zones-discuss] codereview for 6914152 (zonecfg)

2010-02-19 Thread Jerry Jelinek
On 02/19/10 11:32, Frank Batschulat (Home) wrote: Thanks Jerry, that is indeed a valid concern, I changed it to be: snip PAGER /usr/bin/nonsense does not exist (No such file or directory). snip end I included the real error string in case of permission errors where the file does indeed exist

Re: [zones-discuss] codereview for 6914152 (zonecfg)

2010-02-19 Thread Jordan Vaughan
On 02/19/10 10:32 AM, Frank Batschulat (Home) wrote: On Fri, 19 Feb 2010 15:39:21 +0100, Jerry Jelinekgerald.jeli...@sun.com wrote: On 02/19/10 06:53, Frank Batschulat (Home) wrote: May I request 2 code reviewers for the changes for: 6914152 zonecfg fails when less(1M) is missing