[jira] Created: (ZOOKEEPER-292) commit configure scripts (autotools) to svn for c projects and include in release

2009-02-04 Thread Patrick Hunt (JIRA)
commit configure scripts (autotools) to svn for c projects and include in 
release
-

 Key: ZOOKEEPER-292
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-292
 Project: Zookeeper
  Issue Type: Improvement
  Components: c client, contrib-zkfuse
Reporter: Patrick Hunt
 Fix For: 3.2.0


We currently don't include configure scripts, just the .ac file itself. This 
means that users are required
to run "autoreconf; ./configure" rather than just configure.

We should commit the configure script(s) to svn (hadoop core does this btw) for 
our autotools based projects (currently c client api and zkfuse).

Also these should be included in the build.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: [VOTE] Release ZooKeeper 3.1.0 (candidate 0)

2009-02-04 Thread Patrick Hunt
I've pushed a new release candidate (rc1 - separate email). This is a 
really interesting issue, I learned something new today. :-)


It seems that switch case requires _compile time_ constant expression, 
it's not good enough to use a "static final"! ZOOKEEPER-291 fixes the 
issue and is included in the 3.1.0 rc1.


Thanks Stu! If you could retry compiling your original code (3.0 based) 
and verify that would be great (I added tests specific for this so it 
should work but would be good to verify).


Regards,

Patrick

Patrick Hunt wrote:

I failed to mark 246 as an incompatible change in JIRA/releasenotes:
https://issues.apache.org/jira/browse/ZOOKEEPER-246

KeeperException.Code was changed from an interface to an enum, the old 
camel case Code fields (Ok, NoNode, etc...) were deprecated and replaced 
by upper case versions (OK, NONODE, etc...). Similar change in the C 
client interface.


I thought I verified this worked with legacy code (deprecated still 
worked), but I guess not. I'll fix this in the code to make it b/w 
compat and also update the release notes -- I'll respin a new release 
candidate today.


Thanks for the heads up Stu!

Patrick

Stu Hood wrote:

This candidate passes all of our unit tests.

Has the disk or wire format changed from 3.0.1 to 3.1.0?

There was one difference that prevented our code base from building 
immediately: the deprecated integers in KeeperException.Code were not 
working in switch statements anymore:

[javac] Compiling 91 source files to deploy/classes
[javac] src/java/mercury/ring/KeySpace.java:796: constant expression 
required

[javac] case Code.Ok:
[javac]  ^
[javac] src/java/mercury/ring/KeySpace.java:800: constant expression 
required

[javac] case Code.NoNode:
[javac]  ^
[javac] src/java/mercury/ring/KeySpace.java:803: constant expression 
required

[javac] case Code.SessionExpired:
[javac]  ^
[javac] src/java/mercury/ring/KeySpace.java:804: constant expression 
required

[javac] case Code.ConnectionLoss:
[javac]  ^


Thanks,
Stu


-Original Message-
From: "Patrick Hunt" 
Sent: Tuesday, February 3, 2009 8:37pm
To: "zookeeper-dev@hadoop.apache.org" 
Subject: [VOTE] Release ZooKeeper 3.1.0 (candidate 0)

I've created a candidate build for ZooKeeper 3.1.0. Over 65 JIRAs are 
addressed in this release, with major new features for Quota, JMX, and 
Bookkeeper (transactional log store) to name a few. Full details in 
the release notes.


*** Please download, test and VOTE before the
*** vote closes EOD on Friday, February 6.***

http://people.apache.org/~phunt/zookeeper-3.1.0-candidate-0/

Should we release this?

Patrick






[VOTE] Release ZooKeeper 3.1.0 (candidate 1)

2009-02-04 Thread Patrick Hunt
I've created a new candidate (rc1) that fixes an issue raised by a user 
(thanks Stu!) during review:

https://issues.apache.org/jira/browse/ZOOKEEPER-291
The release notes were also updated to reflect this change.

Otw there are no other changes.

*** Please download, test and VOTE before the
*** vote closes EOD on Monday February 9.***

http://people.apache.org/~phunt/zookeeper-3.1.0-candidate-1/

Should we release this?

Patrick




[jira] Commented: (ZOOKEEPER-290) Bad Address on Bookie

2009-02-04 Thread Benjamin Reed (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670548#action_12670548
 ] 

Benjamin Reed commented on ZOOKEEPER-290:
-

can you reproduce this? i'm wondering if it is a bad offset.

> Bad Address on Bookie
> -
>
> Key: ZOOKEEPER-290
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-290
> Project: Zookeeper
>  Issue Type: Bug
>  Components: contrib-bookkeeper
>Reporter: Flavio Paiva Junqueira
> Fix For: 3.2.0
>
>
> I'm getting this exception sometimes when running a bookie under a high 
> volume of requests:
> {noformat}
> java.io.IOException: Bad address
> at sun.nio.ch.FileDispatcher.writev0(Native Method)
> at sun.nio.ch.FileDispatcher.writev(FileDispatcher.java:51)
> at sun.nio.ch.IOUtil.write(IOUtil.java:164)
> at sun.nio.ch.FileChannelImpl.write0(FileChannelImpl.java:232)
> at sun.nio.ch.FileChannelImpl.write(FileChannelImpl.java:249)
> at java.nio.channels.FileChannel.write(FileChannel.java:222)
> at org.apache.bookkeeper.bookie.Bookie.run(Bookie.java:246)
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-291) regression for legacy code using KeeperException.Code constants (due to 246)

2009-02-04 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-291:


  Resolution: Fixed
Hadoop Flags: [Reviewed]
  Status: Resolved  (was: Patch Available)

I just committed this. THnaks pat.


> regression for legacy code using KeeperException.Code constants (due to 246)
> 
>
> Key: ZOOKEEPER-291
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-291
> Project: Zookeeper
>  Issue Type: Bug
>  Components: java client
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-291.patch
>
>
> In 246 the old constants were deprecated and replace with enum. In the 
> process usage of the orig constants was broken for switch statements, cases 
> require compiletime constants.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-291) regression for legacy code using KeeperException.Code constants (due to 246)

2009-02-04 Thread Mahadev konar (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670435#action_12670435
 ] 

Mahadev konar commented on ZOOKEEPER-291:
-

+1 for the patch.

> regression for legacy code using KeeperException.Code constants (due to 246)
> 
>
> Key: ZOOKEEPER-291
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-291
> Project: Zookeeper
>  Issue Type: Bug
>  Components: java client
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-291.patch
>
>
> In 246 the old constants were deprecated and replace with enum. In the 
> process usage of the orig constants was broken for switch statements, cases 
> require compiletime constants.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-291) regression for legacy code using KeeperException.Code constants (due to 246)

2009-02-04 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-291:
---

Status: Patch Available  (was: Open)

Please review and commit this patch - it needs to be committed to both the 
trunk and also the 3.1 branch. At the same time be sure to edit the CHANGES.txt 
(again both main/branch) to specify that 246 was an incompatible change (this 
one is just a bug).

I will ensure this is in the release notes for 3.1 release.


> regression for legacy code using KeeperException.Code constants (due to 246)
> 
>
> Key: ZOOKEEPER-291
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-291
> Project: Zookeeper
>  Issue Type: Bug
>  Components: java client
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-291.patch
>
>
> In 246 the old constants were deprecated and replace with enum. In the 
> process usage of the orig constants was broken for switch statements, cases 
> require compiletime constants.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-291) regression for legacy code using KeeperException.Code constants (due to 246)

2009-02-04 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-291:
---

Attachment: ZOOKEEPER-291.patch

I added tests (that failed w/o the changes) to verify that legacy code will 
work ok using the deprecated constants in switch case statements.

Also added tests to make sure the new enums work too :-)


> regression for legacy code using KeeperException.Code constants (due to 246)
> 
>
> Key: ZOOKEEPER-291
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-291
> Project: Zookeeper
>  Issue Type: Bug
>  Components: java client
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-291.patch
>
>
> In 246 the old constants were deprecated and replace with enum. In the 
> process usage of the orig constants was broken for switch statements, cases 
> require compiletime constants.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Assigned: (ZOOKEEPER-291) regression for legacy code using KeeperException.Code constants (due to 246)

2009-02-04 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt reassigned ZOOKEEPER-291:
--

Assignee: Patrick Hunt

> regression for legacy code using KeeperException.Code constants (due to 246)
> 
>
> Key: ZOOKEEPER-291
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-291
> Project: Zookeeper
>  Issue Type: Bug
>  Components: java client
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.1.0
>
>
> In 246 the old constants were deprecated and replace with enum. In the 
> process usage of the orig constants was broken for switch statements, cases 
> require compiletime constants.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (ZOOKEEPER-291) regression for legacy code using KeeperException.Code constants (due to 246)

2009-02-04 Thread Patrick Hunt (JIRA)
regression for legacy code using KeeperException.Code constants (due to 246)


 Key: ZOOKEEPER-291
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-291
 Project: Zookeeper
  Issue Type: Bug
  Components: java client
Reporter: Patrick Hunt
 Fix For: 3.1.0


In 246 the old constants were deprecated and replace with enum. In the process 
usage of the orig constants was broken for switch statements, cases require 
compiletime constants.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-281) autoreconf fails for /zookeeper-3.0.1/src/c/

2009-02-04 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-281:
---

Fix Version/s: (was: 3.0.1)
   3.2.0

Updating fix release to 3.2 - we'll address it there.


> autoreconf fails for /zookeeper-3.0.1/src/c/
> 
>
> Key: ZOOKEEPER-281
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-281
> Project: Zookeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.0.1
> Environment: Linux dememax-laptop 2.6.27-gentoo-r8 #2 SMP Fri Jan 23 
> 13:42:35 MSK 2009 i686 Intel(R) Core(TM)2 CPU T5600 @ 1.83GHz GenuineIntel 
> GNU/Linux
> autoconf (GNU Autoconf) 2.63
> automake (GNU automake) 1.10.2
> m4 (GNU M4) 1.4.11
> aclocal (GNU automake) 1.10.2
> ltmain.sh (GNU libtool) 1.5.26 (1.1220.2.493 2008/02/01 16:58:18)
> basename (GNU coreutils) 6.10
> gettext (GNU gettext-runtime) 0.17
> GNU ld (GNU Binutils) 2.18
>Reporter: Maxim P. Dementiev
>Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: autoreconf.log, configure-autoreconf-2.63.gz, 
> configure.gz, ZOOKEEPER-281.patch
>
>
> > autoreconf -i -f -v
> autoreconf-2.63: Entering directory `.'
> autoreconf-2.63: configure.ac: not using Gettext
> autoreconf-2.63: running: aclocal --force 
> configure.ac:21: error: AC_SUBST: `DX_FLAG_[]DX_CURRENT_FEATURE' is not a 
> valid shell variable name
> acinclude.m4:77: DX_REQUIRE_PROG is expanded from...
> acinclude.m4:117: DX_ARG_ABLE is expanded from...
> acinclude.m4:178: DX_INIT_DOXYGEN is expanded from...
> configure.ac:21: the top level
> autom4te-2.63: /usr/bin/m4 failed with exit status: 1
> aclocal-1.10: autom4te failed with exit status: 1
> autoreconf-2.63: aclocal failed with exit status: 1
> >

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-246) review error code definition in both source and docs

2009-02-04 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-246:
---

Hadoop Flags: [Incompatible change, Reviewed]  (was: [Reviewed])

> review error code definition in both source and docs
> 
>
> Key: ZOOKEEPER-246
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-246
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: c client, documentation, java client
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
>Priority: Minor
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-246.patch, ZOOKEEPER-246.patch, 
> ZOOKEEPER-246.patch
>
>
> A number of users have mentioned that our use of "calculated" values for 
> error codes makes it very difficult to track error reports from the logs.  In 
> both c/java we have:
> int ERROR = 100
> int X_ERROR= ERROR + 1
> int Y_ERROR= ERROR + 2
> etc...
> which makes it difficult to grep/search for "101" and find these references. 
> A number of users have mentioned that having non-calculated values (ie 
> X_ERROR=101) would make it easier. 
> I personally find calculated constants like this an anti-pattern.
> We should convert these values to non-calculated at a minimum, perhaps even 
> redefine them as enums if possible.
> Also documentation, esp in the c code (the names btw c and java don't match 
> btw) is lacking. We need to beef up docs in this area.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-281) autoreconf fails for /zookeeper-3.0.1/src/c/

2009-02-04 Thread Maxim P. Dementiev (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maxim P. Dementiev updated ZOOKEEPER-281:
-

Fix Version/s: 3.0.1
 Release Note: Introduces compatibility with new GNU Autoconf version 2.63.
   Status: Patch Available  (was: Open)

> autoreconf fails for /zookeeper-3.0.1/src/c/
> 
>
> Key: ZOOKEEPER-281
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-281
> Project: Zookeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.0.1
> Environment: Linux dememax-laptop 2.6.27-gentoo-r8 #2 SMP Fri Jan 23 
> 13:42:35 MSK 2009 i686 Intel(R) Core(TM)2 CPU T5600 @ 1.83GHz GenuineIntel 
> GNU/Linux
> autoconf (GNU Autoconf) 2.63
> automake (GNU automake) 1.10.2
> m4 (GNU M4) 1.4.11
> aclocal (GNU automake) 1.10.2
> ltmain.sh (GNU libtool) 1.5.26 (1.1220.2.493 2008/02/01 16:58:18)
> basename (GNU coreutils) 6.10
> gettext (GNU gettext-runtime) 0.17
> GNU ld (GNU Binutils) 2.18
>Reporter: Maxim P. Dementiev
>Assignee: Patrick Hunt
> Fix For: 3.0.1
>
> Attachments: autoreconf.log, configure-autoreconf-2.63.gz, 
> configure.gz, ZOOKEEPER-281.patch
>
>
> > autoreconf -i -f -v
> autoreconf-2.63: Entering directory `.'
> autoreconf-2.63: configure.ac: not using Gettext
> autoreconf-2.63: running: aclocal --force 
> configure.ac:21: error: AC_SUBST: `DX_FLAG_[]DX_CURRENT_FEATURE' is not a 
> valid shell variable name
> acinclude.m4:77: DX_REQUIRE_PROG is expanded from...
> acinclude.m4:117: DX_ARG_ABLE is expanded from...
> acinclude.m4:178: DX_INIT_DOXYGEN is expanded from...
> configure.ac:21: the top level
> autom4te-2.63: /usr/bin/m4 failed with exit status: 1
> aclocal-1.10: autom4te failed with exit status: 1
> autoreconf-2.63: aclocal failed with exit status: 1
> >

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-281) autoreconf fails for /zookeeper-3.0.1/src/c/

2009-02-04 Thread Maxim P. Dementiev (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maxim P. Dementiev updated ZOOKEEPER-281:
-

Attachment: configure-autoreconf-2.63.gz

Dear Patrick,

Your patch works fine for me! Take a look:

deme...@dememax-laptop ~/sources/ZooKeeper/zookeeper-3.0.1/src/c $ autoreconf 
-i -f -v
autoreconf-2.63: Entering directory `.'
autoreconf-2.63: configure.ac: not using Gettext
autoreconf-2.63: running: aclocal --force 
autoreconf-2.63: configure.ac: tracing
autoreconf-2.63: running: libtoolize --copy --force
autoreconf-2.63: running: /usr/bin/autoconf-2.63 --force
autoreconf-2.63: running: /usr/bin/autoheader-2.63 --force
autoreconf-2.63: running: automake --add-missing --copy --force-missing
configure.ac:30: installing `./compile'
configure.ac:24: installing `./install-sh'
configure.ac:24: installing `./missing'
Makefile.am: installing `./depcomp'
autoreconf-2.63: Leaving directory `.'
deme...@dememax-laptop ~/sources/ZooKeeper/zookeeper-3.0.1/src/c $

Generated configure script (see attachment configure-autoreconf-2.63.gz) works 
fine as well.

By the way, why C*FLAGS are ignored by the build system?
Should I submit an item for this case?

> autoreconf fails for /zookeeper-3.0.1/src/c/
> 
>
> Key: ZOOKEEPER-281
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-281
> Project: Zookeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.0.1
> Environment: Linux dememax-laptop 2.6.27-gentoo-r8 #2 SMP Fri Jan 23 
> 13:42:35 MSK 2009 i686 Intel(R) Core(TM)2 CPU T5600 @ 1.83GHz GenuineIntel 
> GNU/Linux
> autoconf (GNU Autoconf) 2.63
> automake (GNU automake) 1.10.2
> m4 (GNU M4) 1.4.11
> aclocal (GNU automake) 1.10.2
> ltmain.sh (GNU libtool) 1.5.26 (1.1220.2.493 2008/02/01 16:58:18)
> basename (GNU coreutils) 6.10
> gettext (GNU gettext-runtime) 0.17
> GNU ld (GNU Binutils) 2.18
>Reporter: Maxim P. Dementiev
>Assignee: Patrick Hunt
> Attachments: autoreconf.log, configure-autoreconf-2.63.gz, 
> configure.gz, ZOOKEEPER-281.patch
>
>
> > autoreconf -i -f -v
> autoreconf-2.63: Entering directory `.'
> autoreconf-2.63: configure.ac: not using Gettext
> autoreconf-2.63: running: aclocal --force 
> configure.ac:21: error: AC_SUBST: `DX_FLAG_[]DX_CURRENT_FEATURE' is not a 
> valid shell variable name
> acinclude.m4:77: DX_REQUIRE_PROG is expanded from...
> acinclude.m4:117: DX_ARG_ABLE is expanded from...
> acinclude.m4:178: DX_INIT_DOXYGEN is expanded from...
> configure.ac:21: the top level
> autom4te-2.63: /usr/bin/m4 failed with exit status: 1
> aclocal-1.10: autom4te failed with exit status: 1
> autoreconf-2.63: aclocal failed with exit status: 1
> >

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: [VOTE] Release ZooKeeper 3.1.0 (candidate 0)

2009-02-04 Thread Patrick Hunt

I failed to mark 246 as an incompatible change in JIRA/releasenotes:
https://issues.apache.org/jira/browse/ZOOKEEPER-246

KeeperException.Code was changed from an interface to an enum, the old 
camel case Code fields (Ok, NoNode, etc...) were deprecated and replaced 
by upper case versions (OK, NONODE, etc...). Similar change in the C 
client interface.


I thought I verified this worked with legacy code (deprecated still 
worked), but I guess not. I'll fix this in the code to make it b/w 
compat and also update the release notes -- I'll respin a new release 
candidate today.


Thanks for the heads up Stu!

Patrick

Stu Hood wrote:

This candidate passes all of our unit tests.

Has the disk or wire format changed from 3.0.1 to 3.1.0?

There was one difference that prevented our code base from building 
immediately: the deprecated integers in KeeperException.Code were not working 
in switch statements anymore:

[javac] Compiling 91 source files to deploy/classes
[javac] src/java/mercury/ring/KeySpace.java:796: constant expression required
[javac] case Code.Ok:
[javac]  ^
[javac] src/java/mercury/ring/KeySpace.java:800: constant expression required
[javac] case Code.NoNode:
[javac]  ^
[javac] src/java/mercury/ring/KeySpace.java:803: constant expression required
[javac] case Code.SessionExpired:
[javac]  ^
[javac] src/java/mercury/ring/KeySpace.java:804: constant expression required
[javac] case Code.ConnectionLoss:
[javac]  ^


Thanks,
Stu


-Original Message-
From: "Patrick Hunt" 
Sent: Tuesday, February 3, 2009 8:37pm
To: "zookeeper-dev@hadoop.apache.org" 
Subject: [VOTE] Release ZooKeeper 3.1.0 (candidate 0)

I've created a candidate build for ZooKeeper 3.1.0. Over 65 JIRAs are 
addressed in this release, with major new features for Quota, JMX, and 
Bookkeeper (transactional log store) to name a few. Full details in the 
release notes.


*** Please download, test and VOTE before the
*** vote closes EOD on Friday, February 6.***

http://people.apache.org/~phunt/zookeeper-3.1.0-candidate-0/

Should we release this?

Patrick






RE: [VOTE] Release ZooKeeper 3.1.0 (candidate 0)

2009-02-04 Thread Stu Hood
This candidate passes all of our unit tests.

Has the disk or wire format changed from 3.0.1 to 3.1.0?

There was one difference that prevented our code base from building 
immediately: the deprecated integers in KeeperException.Code were not working 
in switch statements anymore:
> [javac] Compiling 91 source files to deploy/classes
> [javac] src/java/mercury/ring/KeySpace.java:796: constant expression required
> [javac]   case Code.Ok:
> [javac]^
> [javac] src/java/mercury/ring/KeySpace.java:800: constant expression required
> [javac]   case Code.NoNode:
> [javac]^
> [javac] src/java/mercury/ring/KeySpace.java:803: constant expression required
> [javac]   case Code.SessionExpired:
> [javac]^
> [javac] src/java/mercury/ring/KeySpace.java:804: constant expression required
> [javac]   case Code.ConnectionLoss:
> [javac]^

Thanks,
Stu


-Original Message-
From: "Patrick Hunt" 
Sent: Tuesday, February 3, 2009 8:37pm
To: "zookeeper-dev@hadoop.apache.org" 
Subject: [VOTE] Release ZooKeeper 3.1.0 (candidate 0)

I've created a candidate build for ZooKeeper 3.1.0. Over 65 JIRAs are 
addressed in this release, with major new features for Quota, JMX, and 
Bookkeeper (transactional log store) to name a few. Full details in the 
release notes.

*** Please download, test and VOTE before the
*** vote closes EOD on Friday, February 6.***

http://people.apache.org/~phunt/zookeeper-3.1.0-candidate-0/

Should we release this?

Patrick






[jira] Commented: (ZOOKEEPER-289) add debug messages to nioserver select loop.

2009-02-04 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670311#action_12670311
 ] 

Hudson commented on ZOOKEEPER-289:
--

Integrated in ZooKeeper-trunk #219 (See 
[http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/219/])
. add debug messages to nioserver select loop. (mahadev)


> add debug messages to nioserver select loop.
> 
>
> Key: ZOOKEEPER-289
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-289
> Project: Zookeeper
>  Issue Type: Improvement
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Mahadev konar
>Assignee: Mahadev konar
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-289.patch, ZOOKEEPER-289.patch
>
>
> add some debug messages for any unexpected behaviour on select i/o in 
> NIOServerCnxn.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-290) Bad Address on Bookie

2009-02-04 Thread Flavio Paiva Junqueira (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Paiva Junqueira updated ZOOKEEPER-290:
-

Component/s: contrib-bookkeeper

> Bad Address on Bookie
> -
>
> Key: ZOOKEEPER-290
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-290
> Project: Zookeeper
>  Issue Type: Bug
>  Components: contrib-bookkeeper
>Reporter: Flavio Paiva Junqueira
> Fix For: 3.2.0
>
>
> I'm getting this exception sometimes when running a bookie under a high 
> volume of requests:
> {noformat}
> java.io.IOException: Bad address
> at sun.nio.ch.FileDispatcher.writev0(Native Method)
> at sun.nio.ch.FileDispatcher.writev(FileDispatcher.java:51)
> at sun.nio.ch.IOUtil.write(IOUtil.java:164)
> at sun.nio.ch.FileChannelImpl.write0(FileChannelImpl.java:232)
> at sun.nio.ch.FileChannelImpl.write(FileChannelImpl.java:249)
> at java.nio.channels.FileChannel.write(FileChannel.java:222)
> at org.apache.bookkeeper.bookie.Bookie.run(Bookie.java:246)
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (ZOOKEEPER-290) Bad Address on Bookie

2009-02-04 Thread Flavio Paiva Junqueira (JIRA)
Bad Address on Bookie
-

 Key: ZOOKEEPER-290
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-290
 Project: Zookeeper
  Issue Type: Bug
Reporter: Flavio Paiva Junqueira
 Fix For: 3.2.0


I'm getting this exception sometimes when running a bookie under a high volume 
of requests:

{noformat}
java.io.IOException: Bad address
at sun.nio.ch.FileDispatcher.writev0(Native Method)
at sun.nio.ch.FileDispatcher.writev(FileDispatcher.java:51)
at sun.nio.ch.IOUtil.write(IOUtil.java:164)
at sun.nio.ch.FileChannelImpl.write0(FileChannelImpl.java:232)
at sun.nio.ch.FileChannelImpl.write(FileChannelImpl.java:249)
at java.nio.channels.FileChannel.write(FileChannel.java:222)
at org.apache.bookkeeper.bookie.Bookie.run(Bookie.java:246)
{noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.