[jira] Updated: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henry Robinson updated ZOOKEEPER-395: - Attachment: ZOOKEEPER-395.patch Python bindings --- Key: ZOOKEEPER-395 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 Project: Zookeeper Issue Type: New Feature Affects Versions: 3.2.0 Reporter: Henry Robinson Assignee: Henry Robinson Attachments: ZOOKEEPER-395.patch ZooKeeper doesn't have Python bindings. Having them would be useful, and would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henry Robinson updated ZOOKEEPER-395: - Release Note: Python bindings for ZooKeeper. See src/contrib/zkpython/README for details. Status: Patch Available (was: Open) Here's a new patch conforming to the directory layout as suggested. Other improvements: the asynchronous API is now implemented, a nasty reference count bug has been fixed and most of the integer constants from zookeeper.h are now in the module. src/contrib/zkpython/src/python/zk.py demonstrates some of the working features. There are no tests yet - that's next on my to do list, followed by docstrings. Python bindings --- Key: ZOOKEEPER-395 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 Project: Zookeeper Issue Type: New Feature Affects Versions: 3.2.0 Reporter: Henry Robinson Assignee: Henry Robinson Attachments: ZOOKEEPER-395.patch ZooKeeper doesn't have Python bindings. Having them would be useful, and would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henry Robinson updated ZOOKEEPER-395: - Attachment: (was: ZOOKEEPER-395.patch) Python bindings --- Key: ZOOKEEPER-395 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 Project: Zookeeper Issue Type: New Feature Affects Versions: 3.2.0 Reporter: Henry Robinson Assignee: Henry Robinson Attachments: ZOOKEEPER-395.patch ZooKeeper doesn't have Python bindings. Having them would be useful, and would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-358) Throw exception when ledger does not exist
[ https://issues.apache.org/jira/browse/ZOOKEEPER-358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira reassigned ZOOKEEPER-358: Assignee: Flavio Paiva Junqueira Throw exception when ledger does not exist -- Key: ZOOKEEPER-358 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-358 Project: Zookeeper Issue Type: Improvement Components: contrib-bookkeeper Affects Versions: 3.1.1 Reporter: Luca Telloli Assignee: Flavio Paiva Junqueira Priority: Minor Currently, openLedger() in the BookKeeper client returns null if the ledger ID does not exist on ZK. Maybe it would be better to throw a specific exception so it can be handled by the client side. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-358) Throw exception when ledger does not exist
[ https://issues.apache.org/jira/browse/ZOOKEEPER-358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-358: - Attachment: ZOOKEEPER-358.patch This is quite a simple patch. Throw exception when ledger does not exist -- Key: ZOOKEEPER-358 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-358 Project: Zookeeper Issue Type: Improvement Components: contrib-bookkeeper Affects Versions: 3.1.1 Reporter: Luca Telloli Assignee: Flavio Paiva Junqueira Priority: Minor Attachments: ZOOKEEPER-358.patch Currently, openLedger() in the BookKeeper client returns null if the ledger ID does not exist on ZK. Maybe it would be better to throw a specific exception so it can be handled by the client side. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-358) Throw exception when ledger does not exist
[ https://issues.apache.org/jira/browse/ZOOKEEPER-358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-358: - Status: Patch Available (was: Open) Throw exception when ledger does not exist -- Key: ZOOKEEPER-358 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-358 Project: Zookeeper Issue Type: Improvement Components: contrib-bookkeeper Affects Versions: 3.1.1 Reporter: Luca Telloli Assignee: Flavio Paiva Junqueira Priority: Minor Attachments: ZOOKEEPER-358.patch Currently, openLedger() in the BookKeeper client returns null if the ledger ID does not exist on ZK. Maybe it would be better to throw a specific exception so it can be handled by the client side. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12707974#action_12707974 ] Hadoop QA commented on ZOOKEEPER-395: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12407751/ZOOKEEPER-395.patch against trunk revision 772843. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. -1 release audit. The applied patch generated 159 release audit warnings (more than the trunk's current 156 warnings). -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/67/testReport/ Release audit warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/67/artifact/trunk/current/releaseAuditDiffWarnings.txt Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/67/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/67/console This message is automatically generated. Python bindings --- Key: ZOOKEEPER-395 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 Project: Zookeeper Issue Type: New Feature Affects Versions: 3.2.0 Reporter: Henry Robinson Assignee: Henry Robinson Attachments: ZOOKEEPER-395.patch ZooKeeper doesn't have Python bindings. Having them would be useful, and would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12707977#action_12707977 ] Flavio Paiva Junqueira commented on ZOOKEEPER-395: -- Henry, you have to add the license header to the new files, otherwise the release audit test will fail. Python bindings --- Key: ZOOKEEPER-395 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 Project: Zookeeper Issue Type: New Feature Affects Versions: 3.2.0 Reporter: Henry Robinson Assignee: Henry Robinson Attachments: ZOOKEEPER-395.patch ZooKeeper doesn't have Python bindings. Having them would be useful, and would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-391) bookeeper mainline code should not be calling printStackTrace
[ https://issues.apache.org/jira/browse/ZOOKEEPER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira reassigned ZOOKEEPER-391: Assignee: Flavio Paiva Junqueira bookeeper mainline code should not be calling printStackTrace - Key: ZOOKEEPER-391 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-391 Project: Zookeeper Issue Type: Bug Components: contrib-bookkeeper Reporter: Patrick Hunt Assignee: Flavio Paiva Junqueira Fix For: 3.2.0 Bookeeper mainline code is calling printStackTrace, it should be using logging instead. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-391) bookeeper mainline code should not be calling printStackTrace
[ https://issues.apache.org/jira/browse/ZOOKEEPER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-391: - Attachment: ZOOKEEPER-391.patch Thanks for pointing it out, Pat. This patch replaces calls to printStackTrace with calls to the log4j logger. bookeeper mainline code should not be calling printStackTrace - Key: ZOOKEEPER-391 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-391 Project: Zookeeper Issue Type: Bug Components: contrib-bookkeeper Reporter: Patrick Hunt Assignee: Flavio Paiva Junqueira Fix For: 3.2.0 Attachments: ZOOKEEPER-391.patch Bookeeper mainline code is calling printStackTrace, it should be using logging instead. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-391) bookeeper mainline code should not be calling printStackTrace
[ https://issues.apache.org/jira/browse/ZOOKEEPER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-391: - Status: Patch Available (was: Open) bookeeper mainline code should not be calling printStackTrace - Key: ZOOKEEPER-391 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-391 Project: Zookeeper Issue Type: Bug Components: contrib-bookkeeper Reporter: Patrick Hunt Assignee: Flavio Paiva Junqueira Fix For: 3.2.0 Attachments: ZOOKEEPER-391.patch Bookeeper mainline code is calling printStackTrace, it should be using logging instead. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Hudson build is back to normal: ZooKeeper-trunk #306
See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/306/
[jira] Updated: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henry Robinson updated ZOOKEEPER-395: - Status: Open (was: Patch Available) adding license headers Python bindings --- Key: ZOOKEEPER-395 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 Project: Zookeeper Issue Type: New Feature Affects Versions: 3.2.0 Reporter: Henry Robinson Assignee: Henry Robinson Attachments: ZOOKEEPER-395.patch ZooKeeper doesn't have Python bindings. Having them would be useful, and would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12708124#action_12708124 ] Patrick Hunt commented on ZOOKEEPER-395: Great! A few fyis: 1) hadoopqabot only triggers on submit, so if you want to re-run the static verifications cancel and resubmit the patch after attaching the new patch file 2) if you update a patch just attach with the same name - jira will be able to track the changes that way (the latest file, if dup names, will be highlighted). don't delete the old patch (in general) 3) why not consider zk.py your smoketest/test? Move it into the test directory, we'll work out the build.xml changes necessary to build/test/package next. including adding the ability to run unit/func tests from build.xml. Python bindings --- Key: ZOOKEEPER-395 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 Project: Zookeeper Issue Type: New Feature Affects Versions: 3.2.0 Reporter: Henry Robinson Assignee: Henry Robinson Attachments: ZOOKEEPER-395.patch ZooKeeper doesn't have Python bindings. Having them would be useful, and would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12708128#action_12708128 ] Henry Robinson commented on ZOOKEEPER-395: -- Thanks for the info - as you can tell I'm still getting up to speed with the Jira workflow and am still pretty clumsy with it. Thanks for your patience! 3) Will do, although I might not have the chance to do so until this evening. I was planning to write a suite of unittest-based tests as well, so I'll add those to test and figure out the build.xml incantations at the same time. Python bindings --- Key: ZOOKEEPER-395 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 Project: Zookeeper Issue Type: New Feature Affects Versions: 3.2.0 Reporter: Henry Robinson Assignee: Henry Robinson Attachments: ZOOKEEPER-395.patch ZooKeeper doesn't have Python bindings. Having them would be useful, and would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henry Robinson updated ZOOKEEPER-395: - Attachment: (was: ZOOKEEPER-395.patch) Python bindings --- Key: ZOOKEEPER-395 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 Project: Zookeeper Issue Type: New Feature Affects Versions: 3.2.0 Reporter: Henry Robinson Assignee: Henry Robinson Attachments: ZOOKEEPER-395.patch ZooKeeper doesn't have Python bindings. Having them would be useful, and would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henry Robinson updated ZOOKEEPER-395: - Comment: was deleted (was: adding license headers) Python bindings --- Key: ZOOKEEPER-395 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 Project: Zookeeper Issue Type: New Feature Affects Versions: 3.2.0 Reporter: Henry Robinson Assignee: Henry Robinson Attachments: ZOOKEEPER-395.patch ZooKeeper doesn't have Python bindings. Having them would be useful, and would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henry Robinson updated ZOOKEEPER-395: - Attachment: ZOOKEEPER-395.patch License headers. Python bindings --- Key: ZOOKEEPER-395 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 Project: Zookeeper Issue Type: New Feature Affects Versions: 3.2.0 Reporter: Henry Robinson Assignee: Henry Robinson Attachments: ZOOKEEPER-395.patch ZooKeeper doesn't have Python bindings. Having them would be useful, and would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henry Robinson updated ZOOKEEPER-395: - Status: Patch Available (was: Open) Added license headers. Python bindings --- Key: ZOOKEEPER-395 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 Project: Zookeeper Issue Type: New Feature Affects Versions: 3.2.0 Reporter: Henry Robinson Assignee: Henry Robinson Attachments: ZOOKEEPER-395.patch ZooKeeper doesn't have Python bindings. Having them would be useful, and would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12708153#action_12708153 ] Patrick Hunt commented on ZOOKEEPER-395: No worries. We appreciate you taking the time to contribute back to the community! Either way you handle 3 is fine w/me. Python bindings --- Key: ZOOKEEPER-395 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 Project: Zookeeper Issue Type: New Feature Affects Versions: 3.2.0 Reporter: Henry Robinson Assignee: Henry Robinson Attachments: ZOOKEEPER-395.patch ZooKeeper doesn't have Python bindings. Having them would be useful, and would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-358) Throw exception when ledger does not exist
[ https://issues.apache.org/jira/browse/ZOOKEEPER-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12708203#action_12708203 ] Hadoop QA commented on ZOOKEEPER-358: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12407766/ZOOKEEPER-358.patch against trunk revision 772843. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/68/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/68/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/68/console This message is automatically generated. Throw exception when ledger does not exist -- Key: ZOOKEEPER-358 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-358 Project: Zookeeper Issue Type: Improvement Components: contrib-bookkeeper Affects Versions: 3.1.1 Reporter: Luca Telloli Assignee: Flavio Paiva Junqueira Priority: Minor Attachments: ZOOKEEPER-358.patch Currently, openLedger() in the BookKeeper client returns null if the ledger ID does not exist on ZK. Maybe it would be better to throw a specific exception so it can be handled by the client side. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-358) Throw exception when ledger does not exist
[ https://issues.apache.org/jira/browse/ZOOKEEPER-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12708207#action_12708207 ] Flavio Paiva Junqueira commented on ZOOKEEPER-358: -- I don't think this patch requires a new test or modifications to existing ones. Any objection? Throw exception when ledger does not exist -- Key: ZOOKEEPER-358 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-358 Project: Zookeeper Issue Type: Improvement Components: contrib-bookkeeper Affects Versions: 3.1.1 Reporter: Luca Telloli Assignee: Flavio Paiva Junqueira Priority: Minor Attachments: ZOOKEEPER-358.patch Currently, openLedger() in the BookKeeper client returns null if the ledger ID does not exist on ZK. Maybe it would be better to throw a specific exception so it can be handled by the client side. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-391) bookeeper mainline code should not be calling printStackTrace
[ https://issues.apache.org/jira/browse/ZOOKEEPER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12708286#action_12708286 ] Hadoop QA commented on ZOOKEEPER-391: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12407773/ZOOKEEPER-391.patch against trunk revision 772843. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/69/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/69/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/69/console This message is automatically generated. bookeeper mainline code should not be calling printStackTrace - Key: ZOOKEEPER-391 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-391 Project: Zookeeper Issue Type: Bug Components: contrib-bookkeeper Reporter: Patrick Hunt Assignee: Flavio Paiva Junqueira Fix For: 3.2.0 Attachments: ZOOKEEPER-391.patch Bookeeper mainline code is calling printStackTrace, it should be using logging instead. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
