[jira] Commented: (ZOOKEEPER-416) BookKeeper jar includes unnecessary files

2009-05-27 Thread Flavio Paiva Junqueira (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713452#action_12713452
 ] 

Flavio Paiva Junqueira commented on ZOOKEEPER-416:
--

This is a change to the build.xml file of BookKeeper. It does not require a 
unit test.

> BookKeeper jar includes unnecessary files
> -
>
> Key: ZOOKEEPER-416
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-416
> Project: Zookeeper
>  Issue Type: Bug
>  Components: contrib-bookkeeper
>Reporter: Flavio Paiva Junqueira
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-416.patch
>
>
> I was checking the bookkeper jar, and I found that it includes some 
> unnecessary files related to junit, such as:
> {noformat}
>  0 Tue May 12 19:00:14 PDT 2009 tmp/
>  0 Tue May 12 19:00:00 PDT 2009 tmp/test14667.junit.dir/
>  0 Tue May 12 19:00:08 PDT 2009 tmp/test14667.junit.dir/version-2/
>  0 Tue May 12 19:00:10 PDT 2009 tmp/test16109.junit.dir/
>  0 Tue May 12 19:00:16 PDT 2009 tmp/test16109.junit.dir/version-2/
>  0 Tue May 12 19:00:14 PDT 2009 tmp/test16113.junit.dir/
>  0 Tue May 12 19:00:16 PDT 2009 tmp/test16113.junit.dir/version-2/
>   2256 Tue May 12 18:59:08 PDT 2009 
> logs/TEST-org.apache.bookkeeper.test.BookieClientTest.txt
> 167046 Tue May 12 19:00:00 PDT 2009 
> logs/TEST-org.apache.bookkeeper.test.BookieReadWriteTest.txt
>  13035 Tue May 12 19:00:08 PDT 2009 
> logs/TEST-org.apache.bookkeeper.test.CloseTest.txt
>  25036 Tue May 12 19:00:16 PDT 2009 
> logs/TEST-org.apache.bookkeeper.test.LedgerRecoveryTest.txt
>896 Tue May 12 19:00:16 PDT 2009 
> logs/TEST-org.apache.bookkeeper.test.NIOServerFactoryTest.txt
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (ZOOKEEPER-418) Need nifty zookeeper browser

2009-05-27 Thread Ted Dunning (JIRA)
Need nifty zookeeper browser


 Key: ZOOKEEPER-418
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-418
 Project: Zookeeper
  Issue Type: Bug
Reporter: Ted Dunning


It would be very nice to have a browser that would allow the state of a Zoo to 
be examined.  Even nice would be such a utility that showed changes in real 
time.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-418) Need nifty zookeeper browser

2009-05-27 Thread Ted Dunning (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Dunning updated ZOOKEEPER-418:
--

Attachment: zk-view-0.1.tgz

Here is a first stab at recreating our internal tool with nice upgrades like 
real-time updates for file and directory contents.  I have never built any 
swing UI's before so there are bound to be infelicities galore.  Please help.

There are some warts,  

1) you can't open a file that has children.

2) opening non-text files is bad juju

3) There seems to be a problem with the way the watchers are glued in place.  
If you create a file, it appears, but if you create children for it, it doesn't 
turn into a folder.  Work-around is to simply restart the browser.



> Need nifty zookeeper browser
> 
>
> Key: ZOOKEEPER-418
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-418
> Project: Zookeeper
>  Issue Type: Bug
>Reporter: Ted Dunning
> Attachments: zk-view-0.1.tgz
>
>
> It would be very nice to have a browser that would allow the state of a Zoo 
> to be examined.  Even nice would be such a utility that showed changes in 
> real time.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-418) Need nifty zookeeper browser

2009-05-27 Thread Ted Dunning (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Dunning updated ZOOKEEPER-418:
--

Attachment: screenshot-1.jpg

Here is a simple example on a live ZK.

> Need nifty zookeeper browser
> 
>
> Key: ZOOKEEPER-418
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-418
> Project: Zookeeper
>  Issue Type: Bug
>Reporter: Ted Dunning
> Attachments: screenshot-1.jpg, zk-view-0.1.tgz
>
>
> It would be very nice to have a browser that would allow the state of a Zoo 
> to be examined.  Even nice would be such a utility that showed changes in 
> real time.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-416) BookKeeper jar includes unnecessary files

2009-05-27 Thread Benjamin Reed (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713607#action_12713607
 ] 

Benjamin Reed commented on ZOOKEEPER-416:
-

+1 looks good. those files shouldn't be there.

> BookKeeper jar includes unnecessary files
> -
>
> Key: ZOOKEEPER-416
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-416
> Project: Zookeeper
>  Issue Type: Bug
>  Components: contrib-bookkeeper
>Reporter: Flavio Paiva Junqueira
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-416.patch
>
>
> I was checking the bookkeper jar, and I found that it includes some 
> unnecessary files related to junit, such as:
> {noformat}
>  0 Tue May 12 19:00:14 PDT 2009 tmp/
>  0 Tue May 12 19:00:00 PDT 2009 tmp/test14667.junit.dir/
>  0 Tue May 12 19:00:08 PDT 2009 tmp/test14667.junit.dir/version-2/
>  0 Tue May 12 19:00:10 PDT 2009 tmp/test16109.junit.dir/
>  0 Tue May 12 19:00:16 PDT 2009 tmp/test16109.junit.dir/version-2/
>  0 Tue May 12 19:00:14 PDT 2009 tmp/test16113.junit.dir/
>  0 Tue May 12 19:00:16 PDT 2009 tmp/test16113.junit.dir/version-2/
>   2256 Tue May 12 18:59:08 PDT 2009 
> logs/TEST-org.apache.bookkeeper.test.BookieClientTest.txt
> 167046 Tue May 12 19:00:00 PDT 2009 
> logs/TEST-org.apache.bookkeeper.test.BookieReadWriteTest.txt
>  13035 Tue May 12 19:00:08 PDT 2009 
> logs/TEST-org.apache.bookkeeper.test.CloseTest.txt
>  25036 Tue May 12 19:00:16 PDT 2009 
> logs/TEST-org.apache.bookkeeper.test.LedgerRecoveryTest.txt
>896 Tue May 12 19:00:16 PDT 2009 
> logs/TEST-org.apache.bookkeeper.test.NIOServerFactoryTest.txt
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-383) Asynchronous version of createLedger()

2009-05-27 Thread Flavio Paiva Junqueira (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Paiva Junqueira updated ZOOKEEPER-383:
-

Status: Open  (was: Patch Available)

> Asynchronous version of createLedger()
> --
>
> Key: ZOOKEEPER-383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-383
> Project: Zookeeper
>  Issue Type: New Feature
>  Components: contrib-bookkeeper
>Reporter: Utkarsh Srivastava
>Assignee: Flavio Paiva Junqueira
> Attachments: ZOOKEEPER-383.patch, ZOOKEEPER-383.patch, 
> ZOOKEEPER-383.patch, ZOOKEEPER-383.patch, ZOOKEEPER-383.patch
>
>
> While there are async versions for read and write, there is no async version 
> for creating a ledger. This can cause applications to have to change their 
> whole thread design. 
> It should be easier and more consistent to add an async version of 
> createLedger().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-383) Asynchronous version of createLedger()

2009-05-27 Thread Flavio Paiva Junqueira (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Paiva Junqueira updated ZOOKEEPER-383:
-

Attachment: ZOOKEEPER-383.patch

I have just reorganized error codes in this new patch.

> Asynchronous version of createLedger()
> --
>
> Key: ZOOKEEPER-383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-383
> Project: Zookeeper
>  Issue Type: New Feature
>  Components: contrib-bookkeeper
>Reporter: Utkarsh Srivastava
>Assignee: Flavio Paiva Junqueira
> Attachments: ZOOKEEPER-383.patch, ZOOKEEPER-383.patch, 
> ZOOKEEPER-383.patch, ZOOKEEPER-383.patch, ZOOKEEPER-383.patch, 
> ZOOKEEPER-383.patch
>
>
> While there are async versions for read and write, there is no async version 
> for creating a ledger. This can cause applications to have to change their 
> whole thread design. 
> It should be easier and more consistent to add an async version of 
> createLedger().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-383) Asynchronous version of createLedger()

2009-05-27 Thread Flavio Paiva Junqueira (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Paiva Junqueira updated ZOOKEEPER-383:
-

Fix Version/s: 3.2.0
   Status: Patch Available  (was: Open)

> Asynchronous version of createLedger()
> --
>
> Key: ZOOKEEPER-383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-383
> Project: Zookeeper
>  Issue Type: New Feature
>  Components: contrib-bookkeeper
>Reporter: Utkarsh Srivastava
>Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-383.patch, ZOOKEEPER-383.patch, 
> ZOOKEEPER-383.patch, ZOOKEEPER-383.patch, ZOOKEEPER-383.patch, 
> ZOOKEEPER-383.patch
>
>
> While there are async versions for read and write, there is no async version 
> for creating a ledger. This can cause applications to have to change their 
> whole thread design. 
> It should be easier and more consistent to add an async version of 
> createLedger().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-375) zoo_add_auth only retains most recent auth on re-sync

2009-05-27 Thread Patrick Hunt (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713662#action_12713662
 ] 

Patrick Hunt commented on ZOOKEEPER-375:


have 2 servers, connect client to a server, add auth, create node add another 
auth, shutdown the server that the client is using, client
will switch to the other server, verify correct auth.


> zoo_add_auth only retains most recent auth on re-sync
> -
>
> Key: ZOOKEEPER-375
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-375
> Project: Zookeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.1.0, 3.1.1
>Reporter: Patrick Hunt
>Assignee: Mahadev konar
>Priority: Critical
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-375.patch
>
>
> zoo_add_auth doesn't maintain a list of auths - it only stores the most 
> recent auth send to the server. As a result on re-sync to the cluster it will 
> lose (not reregister) any auths prior to the most recent.
> This code should maintain a list of auths similar to the java code. Be sure 
> to free the memory in close.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Hudson build is back to normal: Zookeeper-Patch-vesta.apache.org #92

2009-05-27 Thread Apache Hudson Server
See 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/92/




[jira] Commented: (ZOOKEEPER-383) Asynchronous version of createLedger()

2009-05-27 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713674#action_12713674
 ] 

Hadoop QA commented on ZOOKEEPER-383:
-

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12409185/ZOOKEEPER-383.patch
  against trunk revision 777662.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 7 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/92/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/92/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/92/console

This message is automatically generated.

> Asynchronous version of createLedger()
> --
>
> Key: ZOOKEEPER-383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-383
> Project: Zookeeper
>  Issue Type: New Feature
>  Components: contrib-bookkeeper
>Reporter: Utkarsh Srivastava
>Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-383.patch, ZOOKEEPER-383.patch, 
> ZOOKEEPER-383.patch, ZOOKEEPER-383.patch, ZOOKEEPER-383.patch, 
> ZOOKEEPER-383.patch
>
>
> While there are async versions for read and write, there is no async version 
> for creating a ledger. This can cause applications to have to change their 
> whole thread design. 
> It should be easier and more consistent to add an async version of 
> createLedger().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Assigned: (ZOOKEEPER-418) Need nifty zookeeper browser

2009-05-27 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt reassigned ZOOKEEPER-418:
--

Assignee: Ted Dunning

> Need nifty zookeeper browser
> 
>
> Key: ZOOKEEPER-418
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-418
> Project: Zookeeper
>  Issue Type: Bug
>Reporter: Ted Dunning
>Assignee: Ted Dunning
> Attachments: screenshot-1.jpg, zk-view-0.1.tgz
>
>
> It would be very nice to have a browser that would allow the state of a Zoo 
> to be examined.  Even nice would be such a utility that showed changes in 
> real time.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-418) Need nifty zookeeper browser

2009-05-27 Thread Patrick Hunt (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713720#action_12713720
 ] 

Patrick Hunt commented on ZOOKEEPER-418:


Ted, thanks for the submission, looks interesting.

We'd be happy to include in contrib if you'd like. In particular take a look at 
src/contrib, the rest/zkpython, etc... are good examples
of how to structure the code (you're already pretty close). Please submit as a 
patch if possible.

We don't currently support maven, so you'd have to create a build.xml - take a 
look at the example in the other
 contribs (like rest), you probably just need to copy/tweak one of those.

I'd suggest that you change the package to org.apache.zookeeper.gui.swing.tree 
(something like that) rather than just org.apache.zookeeper.tree

Regards.

> Need nifty zookeeper browser
> 
>
> Key: ZOOKEEPER-418
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-418
> Project: Zookeeper
>  Issue Type: Bug
>Reporter: Ted Dunning
>Assignee: Ted Dunning
> Attachments: screenshot-1.jpg, zk-view-0.1.tgz
>
>
> It would be very nice to have a browser that would allow the state of a Zoo 
> to be examined.  Even nice would be such a utility that showed changes in 
> real time.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-418) Need nifty zookeeper browser

2009-05-27 Thread Patrick Hunt (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713722#action_12713722
 ] 

Patrick Hunt commented on ZOOKEEPER-418:


forgot to mention:

add apache license to the top of all files.

add a README.txt to the contrib directory giving some basic information on 
what/why/how type information.


> Need nifty zookeeper browser
> 
>
> Key: ZOOKEEPER-418
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-418
> Project: Zookeeper
>  Issue Type: Bug
>Reporter: Ted Dunning
>Assignee: Ted Dunning
> Attachments: screenshot-1.jpg, zk-view-0.1.tgz
>
>
> It would be very nice to have a browser that would allow the state of a Zoo 
> to be examined.  Even nice would be such a utility that showed changes in 
> real time.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-375) zoo_add_auth only retains most recent auth on re-sync

2009-05-27 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-375:
---

Priority: Blocker  (was: Critical)

> zoo_add_auth only retains most recent auth on re-sync
> -
>
> Key: ZOOKEEPER-375
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-375
> Project: Zookeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.1.0, 3.1.1
>Reporter: Patrick Hunt
>Assignee: Mahadev konar
>Priority: Blocker
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-375.patch
>
>
> zoo_add_auth doesn't maintain a list of auths - it only stores the most 
> recent auth send to the server. As a result on re-sync to the cluster it will 
> lose (not reregister) any auths prior to the most recent.
> This code should maintain a list of auths similar to the java code. Be sure 
> to free the memory in close.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-417) stray message problem when changing servers

2009-05-27 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-417:
---

Priority: Blocker  (was: Major)

> stray message problem when changing servers
> ---
>
> Key: ZOOKEEPER-417
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-417
> Project: Zookeeper
>  Issue Type: Bug
>Reporter: Benjamin Reed
>Priority: Blocker
> Fix For: 3.2.0
>
>
> There is  a possibility for stray messages from a previous connection to 
> violate ordering and generally cause problems. Here is a scenario: we have a 
> client, C, two followers, F1 and F2, and a leader, L. The client is connected 
> to F1, which is a slow follower. C sends setData("/a", "1") to F1 and then 
> loses the connection, so C reconnects to F2 and sends setData("/a", "2").  it 
> is possible, if F1 is slow enough and the setData("/a", "1") got onto the 
> network before the connection break, for F1 to forward the setData("/a", "1") 
> to L after F2 forwards setData("/a", "2").
> to fix this, the leader should keep track of which follower last registered a 
> session for a client and drop any requests from followers for clients for 
> whom they do not have a registration. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-297) centralize version numbering in the source/build

2009-05-27 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-297:
---

Fix Version/s: (was: 3.2.0)
   3.3.0

> centralize version numbering in the source/build
> 
>
> Key: ZOOKEEPER-297
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-297
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 3.1.0
>Reporter: Patrick Hunt
>Priority: Minor
> Fix For: 3.3.0
>
>
> There are now three locations in the source repository that store the version 
> number of the code:
> 1) build.xml
> 2) configure.ac
> 3) zookeeper_version.h
> these all have to be managed when releasing/branching/etc... would be better 
> if there were just one place - at the very least the configure.ac should be 
> used to generate the version for zookeeper_version.h. 
> Can we do a better job (ie less) at this?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



ZooKeeper 3.2 release status

2009-05-27 Thread Patrick Hunt
We have been planning for a ZooKeeper 3.2 release at the end of May. 
There are currently 82 of 101 issues resolved for the release, this is 
after Mahadev and I scrubbed the bug list for obvious issues that can be 
pushed to 3.3. Looking at the remaining issues I believe we can 
realistically push a release if given another 4 weeks or so - many of 
the remaining issues are simple bug/doc fixes, however there are a few 
blockers that we should address for 3.2:

https://issues.apache.org/jira/browse/ZOOKEEPER?report=com.atlassian.jira.plugin.system.project:roadmap-panel

I will update the JIRA version information to push 3.2 release out to 
the end of June. Let me know if there are any questions/comments.


Patrick


[jira] Updated: (ZOOKEEPER-419) Reference counting bug in Python bindings causes abort errors

2009-05-27 Thread Henry Robinson (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Henry Robinson updated ZOOKEEPER-419:
-

Attachment: ZOOKEEPER-419.patch

Replace "O" with "N" for stat and acl objects passed to Py_BuildValue.

> Reference counting bug in Python bindings causes abort errors
> -
>
> Key: ZOOKEEPER-419
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-419
> Project: Zookeeper
>  Issue Type: Bug
>  Components: contrib-bindings
>Reporter: Henry Robinson
>Assignee: Henry Robinson
>Priority: Critical
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-419.patch
>
>
> Due to reference counts being incremented incorrectly for stat-based calls, 
> Python's GC occasionally aborts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (ZOOKEEPER-419) Reference counting bug in Python bindings causes abort errors

2009-05-27 Thread Henry Robinson (JIRA)
Reference counting bug in Python bindings causes abort errors
-

 Key: ZOOKEEPER-419
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-419
 Project: Zookeeper
  Issue Type: Bug
  Components: contrib-bindings
Reporter: Henry Robinson
Assignee: Henry Robinson
Priority: Critical
 Fix For: 3.2.0
 Attachments: ZOOKEEPER-419.patch

Due to reference counts being incremented incorrectly for stat-based calls, 
Python's GC occasionally aborts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-419) Reference counting bug in Python bindings causes abort errors

2009-05-27 Thread Henry Robinson (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Henry Robinson updated ZOOKEEPER-419:
-

Status: Patch Available  (was: Open)

> Reference counting bug in Python bindings causes abort errors
> -
>
> Key: ZOOKEEPER-419
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-419
> Project: Zookeeper
>  Issue Type: Bug
>  Components: contrib-bindings
>Reporter: Henry Robinson
>Assignee: Henry Robinson
>Priority: Critical
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-419.patch
>
>
> Due to reference counts being incremented incorrectly for stat-based calls, 
> Python's GC occasionally aborts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Build failed in Hudson: Zookeeper-Patch-vesta.apache.org #93

2009-05-27 Thread Apache Hudson Server
See 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/93/

--
[...truncated 130316 lines...]
 [exec]  [exec] libtool: compile:  gcc -DHAVE_CONFIG_H -I. 
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c
  
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/include
  
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/tests
  
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/generated
  -DTHREADED -g -O2 -MT libzkmt_la-mt_adaptor.lo -MD -MP -MF 
.deps/libzkmt_la-mt_adaptor.Tpo -c 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/src/mt_adaptor.c
  -o libzkmt_la-mt_adaptor.o >/dev/null 2>&1
 [exec]  [exec] mv -f .deps/libzkmt_la-mt_adaptor.Tpo 
.deps/libzkmt_la-mt_adaptor.Plo
 [exec]  [exec] /bin/bash ./libtool --tag=CC   --mode=link gcc 
-DTHREADED -g -O2   -o libzkmt.la  libzkmt_la-zookeeper.lo 
libzkmt_la-recordio.lo libzkmt_la-zookeeper.jute.lo libzkmt_la-zk_log.lo 
libzkmt_la-zk_hashtable.lo libzkmt_la-mt_adaptor.lo -lm 
 [exec]  [exec] libtool: link: ar cru .libs/libzkmt.a 
.libs/libzkmt_la-zookeeper.o .libs/libzkmt_la-recordio.o 
.libs/libzkmt_la-zookeeper.jute.o .libs/libzkmt_la-zk_log.o 
.libs/libzkmt_la-zk_hashtable.o .libs/libzkmt_la-mt_adaptor.o 
 [exec]  [exec] libtool: link: ranlib .libs/libzkmt.a
 [exec]  [exec] libtool: link: ( cd ".libs" && rm -f "libzkmt.la" && ln 
-s "../libzkmt.la" "libzkmt.la" )
 [exec]  [exec] /bin/bash ./libtool --tag=CC   --mode=link gcc -Wall 
-Werror  -g -O2 -no-undefined -version-info 2  -o libzookeeper_mt.la -rpath 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/build/test/test-cppunit/lib
   libzkmt.la libhashtable.la -lpthread 
 [exec]  [exec] libtool: link: gcc -shared  -Wl,--whole-archive 
./.libs/libzkmt.a ./.libs/libhashtable.a -Wl,--no-whole-archive  -lm -lpthread  
  -Wl,-soname -Wl,libzookeeper_mt.so.2 -o .libs/libzookeeper_mt.so.2.0.0
 [exec]  [exec] libtool: link: (cd ".libs" && rm -f 
"libzookeeper_mt.so.2" && ln -s "libzookeeper_mt.so.2.0.0" 
"libzookeeper_mt.so.2")
 [exec]  [exec] libtool: link: (cd ".libs" && rm -f 
"libzookeeper_mt.so" && ln -s "libzookeeper_mt.so.2.0.0" "libzookeeper_mt.so")
 [exec]  [exec] libtool: link: (cd .libs/libzookeeper_mt.lax/libzkmt.a 
&& ar x 
"http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/build/test/test-cppunit/./.libs/libzkmt.a";)
 
 [exec]  [exec] libtool: link: (cd 
.libs/libzookeeper_mt.lax/libhashtable.a && ar x 
"http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/build/test/test-cppunit/./.libs/libhashtable.a";)
 
 [exec]  [exec] libtool: link: ar cru .libs/libzookeeper_mt.a   
.libs/libzookeeper_mt.lax/libzkmt.a/libzkmt_la-zk_hashtable.o 
.libs/libzookeeper_mt.lax/libzkmt.a/libzkmt_la-zookeeper.jute.o 
.libs/libzookeeper_mt.lax/libzkmt.a/libzkmt_la-mt_adaptor.o 
.libs/libzookeeper_mt.lax/libzkmt.a/libzkmt_la-zk_log.o 
.libs/libzookeeper_mt.lax/libzkmt.a/libzkmt_la-recordio.o 
.libs/libzookeeper_mt.lax/libzkmt.a/libzkmt_la-zookeeper.o  
.libs/libzookeeper_mt.lax/libhashtable.a/hashtable_itr.o 
.libs/libzookeeper_mt.lax/libhashtable.a/hashtable.o 
 [exec]  [exec] libtool: link: ranlib .libs/libzookeeper_mt.a
 [exec]  [exec] libtool: link: rm -fr .libs/libzookeeper_mt.lax
 [exec]  [exec] libtool: link: ( cd ".libs" && rm -f 
"libzookeeper_mt.la" && ln -s "../libzookeeper_mt.la" "libzookeeper_mt.la" )
 [exec]  [exec] gcc -DHAVE_CONFIG_H -I. 
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c
   
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/include
  
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/tests
  
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/generated
   -Wall -Werror  -g -O2 -MT cli.o -MD -MP -MF .deps/cli.Tpo -c -o cli.o `test 
-f 'src/cli.c' || echo 
'http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/'`src/cli.c
 
 [exec]  [exec] mv -f .deps/cli.Tpo .deps/cli.Po
 [exec]  [exec] /bin/bash ./libtool --tag=CC   --mode=link gcc -Wall 
-Werror  -g -O2   -o cli_st cli.o libzookeeper_st.la 
 [exec]  [exec] libtool: link: gcc -Wall -Werror -g -O2 -o .libs/cli_st 
cli.o  ./.libs/libzookeeper_st.so -lm -Wl,-rpath 
-Wl,http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/build/test/test-cppunit/lib
 
 [exec]  [exec] gcc -DHAVE_CONFIG_H -I. 
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/

[jira] Commented: (ZOOKEEPER-419) Reference counting bug in Python bindings causes abort errors

2009-05-27 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713844#action_12713844
 ] 

Hadoop QA commented on ZOOKEEPER-419:
-

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12409226/ZOOKEEPER-419.patch
  against trunk revision 777662.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no tests are needed for this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/93/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/93/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/93/console

This message is automatically generated.

> Reference counting bug in Python bindings causes abort errors
> -
>
> Key: ZOOKEEPER-419
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-419
> Project: Zookeeper
>  Issue Type: Bug
>  Components: contrib-bindings
>Reporter: Henry Robinson
>Assignee: Henry Robinson
>Priority: Critical
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-419.patch
>
>
> Due to reference counts being incremented incorrectly for stat-based calls, 
> Python's GC occasionally aborts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Assigned: (ZOOKEEPER-416) BookKeeper jar includes unnecessary files

2009-05-27 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar reassigned ZOOKEEPER-416:
---

Assignee: Flavio Paiva Junqueira

> BookKeeper jar includes unnecessary files
> -
>
> Key: ZOOKEEPER-416
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-416
> Project: Zookeeper
>  Issue Type: Bug
>  Components: contrib-bookkeeper
>Reporter: Flavio Paiva Junqueira
>Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-416.patch
>
>
> I was checking the bookkeper jar, and I found that it includes some 
> unnecessary files related to junit, such as:
> {noformat}
>  0 Tue May 12 19:00:14 PDT 2009 tmp/
>  0 Tue May 12 19:00:00 PDT 2009 tmp/test14667.junit.dir/
>  0 Tue May 12 19:00:08 PDT 2009 tmp/test14667.junit.dir/version-2/
>  0 Tue May 12 19:00:10 PDT 2009 tmp/test16109.junit.dir/
>  0 Tue May 12 19:00:16 PDT 2009 tmp/test16109.junit.dir/version-2/
>  0 Tue May 12 19:00:14 PDT 2009 tmp/test16113.junit.dir/
>  0 Tue May 12 19:00:16 PDT 2009 tmp/test16113.junit.dir/version-2/
>   2256 Tue May 12 18:59:08 PDT 2009 
> logs/TEST-org.apache.bookkeeper.test.BookieClientTest.txt
> 167046 Tue May 12 19:00:00 PDT 2009 
> logs/TEST-org.apache.bookkeeper.test.BookieReadWriteTest.txt
>  13035 Tue May 12 19:00:08 PDT 2009 
> logs/TEST-org.apache.bookkeeper.test.CloseTest.txt
>  25036 Tue May 12 19:00:16 PDT 2009 
> logs/TEST-org.apache.bookkeeper.test.LedgerRecoveryTest.txt
>896 Tue May 12 19:00:16 PDT 2009 
> logs/TEST-org.apache.bookkeeper.test.NIOServerFactoryTest.txt
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-416) BookKeeper jar includes unnecessary files

2009-05-27 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-416:


  Resolution: Fixed
Hadoop Flags: [Reviewed]
  Status: Resolved  (was: Patch Available)

I just committed this. thanks flavio.

> BookKeeper jar includes unnecessary files
> -
>
> Key: ZOOKEEPER-416
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-416
> Project: Zookeeper
>  Issue Type: Bug
>  Components: contrib-bookkeeper
>Reporter: Flavio Paiva Junqueira
>Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-416.patch
>
>
> I was checking the bookkeper jar, and I found that it includes some 
> unnecessary files related to junit, such as:
> {noformat}
>  0 Tue May 12 19:00:14 PDT 2009 tmp/
>  0 Tue May 12 19:00:00 PDT 2009 tmp/test14667.junit.dir/
>  0 Tue May 12 19:00:08 PDT 2009 tmp/test14667.junit.dir/version-2/
>  0 Tue May 12 19:00:10 PDT 2009 tmp/test16109.junit.dir/
>  0 Tue May 12 19:00:16 PDT 2009 tmp/test16109.junit.dir/version-2/
>  0 Tue May 12 19:00:14 PDT 2009 tmp/test16113.junit.dir/
>  0 Tue May 12 19:00:16 PDT 2009 tmp/test16113.junit.dir/version-2/
>   2256 Tue May 12 18:59:08 PDT 2009 
> logs/TEST-org.apache.bookkeeper.test.BookieClientTest.txt
> 167046 Tue May 12 19:00:00 PDT 2009 
> logs/TEST-org.apache.bookkeeper.test.BookieReadWriteTest.txt
>  13035 Tue May 12 19:00:08 PDT 2009 
> logs/TEST-org.apache.bookkeeper.test.CloseTest.txt
>  25036 Tue May 12 19:00:16 PDT 2009 
> logs/TEST-org.apache.bookkeeper.test.LedgerRecoveryTest.txt
>896 Tue May 12 19:00:16 PDT 2009 
> logs/TEST-org.apache.bookkeeper.test.NIOServerFactoryTest.txt
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-383) Asynchronous version of createLedger()

2009-05-27 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-383:


  Resolution: Fixed
Release Note: Asynchronous calls for create ledger with changes in 
callbacks using ledger handle rather than ledgerid.
Hadoop Flags: [Reviewed]
  Status: Resolved  (was: Patch Available)

+1. I just committed this. thanks flavio.

> Asynchronous version of createLedger()
> --
>
> Key: ZOOKEEPER-383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-383
> Project: Zookeeper
>  Issue Type: New Feature
>  Components: contrib-bookkeeper
>Reporter: Utkarsh Srivastava
>Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-383.patch, ZOOKEEPER-383.patch, 
> ZOOKEEPER-383.patch, ZOOKEEPER-383.patch, ZOOKEEPER-383.patch, 
> ZOOKEEPER-383.patch
>
>
> While there are async versions for read and write, there is no async version 
> for creating a ledger. This can cause applications to have to change their 
> whole thread design. 
> It should be easier and more consistent to add an async version of 
> createLedger().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Some questions

2009-05-27 Thread Qian Ye
Hi all:

I'm a fresh man  to Zookeeper. These days, I'm studying on the source code
of the C client for Zookeeper, and here are some questions, maybe any one
can give me some help.

1. I found in the source of API "zookeeper_interest" that it used a "pipe"
to connect with the fd which connects to the Zookeeper server, and used
"poll()" to supervise the reading and writing events. I'm not familiar with
this usage of combining of pipe and poll. Is there any special advantages in
it?
2. I want to conduct a deeply study on both the client and server side of
Zookeeper. Could any one provide me the docs of design for Zookeeper?
3. What is JIRA? :-p

Thanks for any kinds of help!

-- 
With Regards!

Ye, Qian
Made in Zhejiang University