[jira] Updated: (ZOOKEEPER-252) PurgeTxnLog is not handling the new dataDir directory structure

2009-01-26 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-252:


Attachment: ZOOKEEPER-252.patch

had a bug in the last patch.

> PurgeTxnLog is not handling the new dataDir directory structure
> ---
>
> Key: ZOOKEEPER-252
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-252
> Project: Zookeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Patrick Hunt
>Assignee: Mahadev konar
>Priority: Critical
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-252.patch
>
>
> org.apache.zookeeper.server.PurgeTxnLog class has not been updated to handle 
> the new directory structure imposed by the upgrade from v2 to v3 of 
> ZooKeeper. In particular the dataDir now has a "version-2" subdirectory that 
> stores all of the snaps/transactionallogs for version2 of the persistence 
> layer.
> I also note that the documentation of this class is particularly poor. I'm 
> working on ZOOKEEPER-229 and would like to point to the API docs for this 
> class regarding usage but they api docs are nonexistent
> Also - I think it's important for the user to be able to specify the number 
> of "backup" snaps and logs that should be kept -- right now it seems we 
> delete all but the current snaps/txlogs. Either by count or by date -- ie 
> "remove anything 5 days or older, with a minum of 3 most recents snaps (and 
> accompanying txlogs)" seems like a pretty common user case (assuming the 
> operator is doing system backups every X days, etc...)
> in general this class needs some tlc - the formatting should also be cleaned 
> up.
> Also - the API docs for this and LogFormatter are not included in the 
> build.xml "javadoc" target. These are user utilities so javadoc for these two 
> classes should be included. I will fix this issue as part of ZOOKEEPER-229. 
> I'm also updateing the forrest documention in 229 so don't worry about that 
> either.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-252) PurgeTxnLog is not handling the new dataDir directory structure

2009-01-26 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-252:


Attachment: (was: ZOOKEEPER-252.patch)

> PurgeTxnLog is not handling the new dataDir directory structure
> ---
>
> Key: ZOOKEEPER-252
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-252
> Project: Zookeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Patrick Hunt
>Assignee: Mahadev konar
>Priority: Critical
> Fix For: 3.1.0
>
>
> org.apache.zookeeper.server.PurgeTxnLog class has not been updated to handle 
> the new directory structure imposed by the upgrade from v2 to v3 of 
> ZooKeeper. In particular the dataDir now has a "version-2" subdirectory that 
> stores all of the snaps/transactionallogs for version2 of the persistence 
> layer.
> I also note that the documentation of this class is particularly poor. I'm 
> working on ZOOKEEPER-229 and would like to point to the API docs for this 
> class regarding usage but they api docs are nonexistent
> Also - I think it's important for the user to be able to specify the number 
> of "backup" snaps and logs that should be kept -- right now it seems we 
> delete all but the current snaps/txlogs. Either by count or by date -- ie 
> "remove anything 5 days or older, with a minum of 3 most recents snaps (and 
> accompanying txlogs)" seems like a pretty common user case (assuming the 
> operator is doing system backups every X days, etc...)
> in general this class needs some tlc - the formatting should also be cleaned 
> up.
> Also - the API docs for this and LogFormatter are not included in the 
> build.xml "javadoc" target. These are user utilities so javadoc for these two 
> classes should be included. I will fix this issue as part of ZOOKEEPER-229. 
> I'm also updateing the forrest documention in 229 so don't worry about that 
> either.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Issue Comment Edited: (ZOOKEEPER-252) PurgeTxnLog is not handling the new dataDir directory structure

2009-01-26 Thread Mahadev konar (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667552#action_12667552
 ] 

mahadev edited comment on ZOOKEEPER-252 at 1/26/09 6:11 PM:
--

this patch fixes the issue.
It allows purgetxn to be called with -n num (which is to keep history for last 
n snapshots and the corresponding logs).


  was (Author: mahadev):
this patch fixes the issue.
It allows purgetxn to be called with -n num (which is to keep history for num 
snapshots).

  
> PurgeTxnLog is not handling the new dataDir directory structure
> ---
>
> Key: ZOOKEEPER-252
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-252
> Project: Zookeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Patrick Hunt
>Assignee: Mahadev konar
>Priority: Critical
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-252.patch
>
>
> org.apache.zookeeper.server.PurgeTxnLog class has not been updated to handle 
> the new directory structure imposed by the upgrade from v2 to v3 of 
> ZooKeeper. In particular the dataDir now has a "version-2" subdirectory that 
> stores all of the snaps/transactionallogs for version2 of the persistence 
> layer.
> I also note that the documentation of this class is particularly poor. I'm 
> working on ZOOKEEPER-229 and would like to point to the API docs for this 
> class regarding usage but they api docs are nonexistent
> Also - I think it's important for the user to be able to specify the number 
> of "backup" snaps and logs that should be kept -- right now it seems we 
> delete all but the current snaps/txlogs. Either by count or by date -- ie 
> "remove anything 5 days or older, with a minum of 3 most recents snaps (and 
> accompanying txlogs)" seems like a pretty common user case (assuming the 
> operator is doing system backups every X days, etc...)
> in general this class needs some tlc - the formatting should also be cleaned 
> up.
> Also - the API docs for this and LogFormatter are not included in the 
> build.xml "javadoc" target. These are user utilities so javadoc for these two 
> classes should be included. I will fix this issue as part of ZOOKEEPER-229. 
> I'm also updateing the forrest documention in 229 so don't worry about that 
> either.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-252) PurgeTxnLog is not handling the new dataDir directory structure

2009-01-26 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-252:


Attachment: ZOOKEEPER-252.patch

this patch fixes the issue.
It allows purgetxn to be called with -n num (which is to keep history for num 
snapshots).


> PurgeTxnLog is not handling the new dataDir directory structure
> ---
>
> Key: ZOOKEEPER-252
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-252
> Project: Zookeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Patrick Hunt
>Assignee: Mahadev konar
>Priority: Critical
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-252.patch
>
>
> org.apache.zookeeper.server.PurgeTxnLog class has not been updated to handle 
> the new directory structure imposed by the upgrade from v2 to v3 of 
> ZooKeeper. In particular the dataDir now has a "version-2" subdirectory that 
> stores all of the snaps/transactionallogs for version2 of the persistence 
> layer.
> I also note that the documentation of this class is particularly poor. I'm 
> working on ZOOKEEPER-229 and would like to point to the API docs for this 
> class regarding usage but they api docs are nonexistent
> Also - I think it's important for the user to be able to specify the number 
> of "backup" snaps and logs that should be kept -- right now it seems we 
> delete all but the current snaps/txlogs. Either by count or by date -- ie 
> "remove anything 5 days or older, with a minum of 3 most recents snaps (and 
> accompanying txlogs)" seems like a pretty common user case (assuming the 
> operator is doing system backups every X days, etc...)
> in general this class needs some tlc - the formatting should also be cleaned 
> up.
> Also - the API docs for this and LogFormatter are not included in the 
> build.xml "javadoc" target. These are user utilities so javadoc for these two 
> classes should be included. I will fix this issue as part of ZOOKEEPER-229. 
> I'm also updateing the forrest documention in 229 so don't worry about that 
> either.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-231) Quotas in zookeeper

2009-01-26 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-231:


Attachment: ZOOKEEPER-231.patch

added a junit test to run with QUorum for quotas.

> Quotas in zookeeper
> ---
>
> Key: ZOOKEEPER-231
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-231
> Project: Zookeeper
>  Issue Type: New Feature
>Affects Versions: 3.0.0
>Reporter: Mahadev konar
>Assignee: Mahadev konar
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-231.patch, ZOOKEEPER-231.patch, 
> ZOOKEEPER-231.patch, ZOOKEEPER-231.patch, ZOOKEEPER-231.patch, 
> ZOOKEEPER-231.patch, ZOOKEEPER-231.patch
>
>
> creating quota's in zookeeper so that a runaway application does not bring 
> down the zookeeper cluster.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-279) Variable expansion in zoo.cfg

2009-01-26 Thread Nitay Joffe (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667361#action_12667361
 ] 

Nitay Joffe commented on ZOOKEEPER-279:
---

More specifically, we are trying to make zoo.cfg play nicely with hadoop/hbase 
conf so that we can interpolate things like hadoop.tmp.dir as the default for 
the ZK dataDir.

> Variable expansion in zoo.cfg
> -
>
> Key: ZOOKEEPER-279
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-279
> Project: Zookeeper
>  Issue Type: Improvement
>Reporter: Nitay Joffe
>Priority: Minor
>
> We would like to define certain parts of ZooKeeper's configuration using 
> variables that get substituted. For example, we want the ZooKeeper quorum to 
> be able to use a dataDir configured per user. In other words, something like:
> tickTime=2000
> dataDir=/tmp/zookeeper-${user.name}
> clientPort=2181
> initLimit=5
> syncLimit=2
> server.1=zoo1:2888:3888
> server.2=zoo2:2888:3888
> server.3=zoo3:2888:3888
> I think Java already has a system for configuration that allows something 
> like this using Properties?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-268) tostring on jute generated objects can cause NPE

2009-01-26 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-268:


Resolution: Fixed
Status: Resolved  (was: Patch Available)

I just committed this. Thanks pat.

> tostring on jute generated objects can cause NPE
> 
>
> Key: ZOOKEEPER-268
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-268
> Project: Zookeeper
>  Issue Type: Bug
>  Components: java client, server
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-268.patch
>
>
> Jute still causing problems with tostring operations on generated code, need 
> to review/cleanup the toCSV code
> From user Kevin Burton:
> -
> Creating this node with this ACL:
> Created /foo
> setAcl /foo world:anyone:w
> Causes the exception included below.
> It's an infinite loop so it's just called over and over again filling my
> console.
> I'm just doing an exists( path, true ); ... setting a watch still causes the
> problem.
> java.lang.NullPointerException
> at org.apache.jute.Utils.toCSVBuffer(Utils.java:234)
> at
> org.apache.jute.CsvOutputArchive.writeBuffer(CsvOutputArchive.java:101)
> at
> org.apache.zookeeper.proto.GetDataResponse.toString(GetDataResponse.java:48)
> at java.lang.String.valueOf(String.java:2827)
> at java.lang.StringBuilder.append(StringBuilder.java:115)
> at
> org.apache.zookeeper.ClientCnxn$Packet.toString(ClientCnxn.java:230)
> at java.lang.String.valueOf(String.java:2827)
> at java.lang.StringBuilder.append(StringBuilder.java:115)
> at
> org.apache.zookeeper.ClientCnxn$SendThread.readResponse(ClientCnxn.java:586)
> at
> org.apache.zookeeper.ClientCnxn$SendThread.doIO(ClientCnxn.java:626)
> at
> org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:852)
> java.lang.NullPointerException
> at org.apache.jute.Utils.toCSVBuffer(Utils.java:234)
> at
> org.apache.jute.CsvOutputArchive.writeBuffer(CsvOutputArchive.java:101)
> at
> org.apache.zookeeper.proto.GetDataResponse.toString(GetDataResponse.java:48)
> at java.lang.String.valueOf(String.java:2827)
> at java.lang.StringBuilder.append(StringBuilder.java:115)
> at
> org.apache.zookeeper.ClientCnxn$Packet.toString(ClientCnxn.java:230)
> at java.lang.String.valueOf(String.java:2827)
> at java.lang.StringBuilder.append(StringBuilder.java:115)
> at
> org.apache.zookeeper.ClientCnxn$SendThread.readResponse(ClientCnxn.java:586)
> at
> org.apache.zookeeper.ClientCnxn$SendThread.doIO(ClientCnxn.java:626)
> at
> org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:852)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (ZOOKEEPER-279) Variable expansion in zoo.cfg

2009-01-26 Thread Nitay Joffe (JIRA)
Variable expansion in zoo.cfg
-

 Key: ZOOKEEPER-279
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-279
 Project: Zookeeper
  Issue Type: Improvement
Reporter: Nitay Joffe
Priority: Minor


We would like to define certain parts of ZooKeeper's configuration using 
variables that get substituted. For example, we want the ZooKeeper quorum to be 
able to use a dataDir configured per user. In other words, something like:

tickTime=2000
dataDir=/tmp/zookeeper-${user.name}
clientPort=2181
initLimit=5
syncLimit=2
server.1=zoo1:2888:3888
server.2=zoo2:2888:3888
server.3=zoo3:2888:3888

I think Java already has a system for configuration that allows something like 
this using Properties?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (ZOOKEEPER-278) Create a test jar

2009-01-26 Thread Nitay Joffe (JIRA)
Create a test jar
-

 Key: ZOOKEEPER-278
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-278
 Project: Zookeeper
  Issue Type: Improvement
  Components: tests
Reporter: Nitay Joffe
Priority: Minor


I am working on integrating ZooKeeper into HBase. I've found myself copying a 
lot of the test infrastructure code from places like zk.t.QuorumTest to create 
classes like MiniZooKeeper so that I can test my new additions in HBase. I 
think things would be a lot easier if we shipped a ZooKeeper test jar for 
others to use. Additionally, I think we should clean up the test code a bit so 
that the tests use some common infrastructure rather than each doing its own 
setup/teardown of a ZK cluster. I believe this is how things are done for 
testing Hadoop things HBase.

For more context, see hbase-1144.patch in 
https://issues.apache.org/jira/browse/HBASE-1144

I would do this myself but I can't currently contribute to Apache projects 
other than HBase because of company issues. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Assigned: (ZOOKEEPER-269) connectionloss - add more documentation to detail

2009-01-26 Thread Flavio Paiva Junqueira (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Paiva Junqueira reassigned ZOOKEEPER-269:


Assignee: Flavio Paiva Junqueira  (was: Patrick Hunt)

> connectionloss - add more documentation to detail 
> --
>
> Key: ZOOKEEPER-269
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-269
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Patrick Hunt
>Assignee: Flavio Paiva Junqueira
>Priority: Minor
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-269.patch
>
>
> discussion with user, this should be better documented:
> --
> There are basically 2 cases where you can see connectionloss:
> 1) you call an operation on a session that is no longer alive
> 2) you are disconnected from a server when there are pending async operations 
> to that server (you made an async request which has not yet completed)
> Patrick
> Kevin Burton wrote:
> > Can this be thrown when using multiple servers as long as > 1 of them is
> > online?
> > Trying to figure out of I should try some type of reconnect if a single
> > machine fails instead of failing altogether.
> >
> > Kevin
> >

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-269) connectionloss - add more documentation to detail

2009-01-26 Thread Flavio Paiva Junqueira (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Paiva Junqueira updated ZOOKEEPER-269:
-

Status: Open  (was: Patch Available)

Will think about this one and will assign to myself.

> connectionloss - add more documentation to detail 
> --
>
> Key: ZOOKEEPER-269
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-269
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 3.0.1, 3.0.0
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
>Priority: Minor
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-269.patch
>
>
> discussion with user, this should be better documented:
> --
> There are basically 2 cases where you can see connectionloss:
> 1) you call an operation on a session that is no longer alive
> 2) you are disconnected from a server when there are pending async operations 
> to that server (you made an async request which has not yet completed)
> Patrick
> Kevin Burton wrote:
> > Can this be thrown when using multiple servers as long as > 1 of them is
> > online?
> > Trying to figure out of I should try some type of reconnect if a single
> > machine fails instead of failing altogether.
> >
> > Kevin
> >

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-273) Zookeeper c client build should not depend on CPPUNIT

2009-01-26 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-273:


  Resolution: Fixed
Hadoop Flags: [Reviewed]
  Status: Resolved  (was: Patch Available)

I just committed this. Thanks pat and runping.

> Zookeeper c client build should not depend on CPPUNIT
> -
>
> Key: ZOOKEEPER-273
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-273
> Project: Zookeeper
>  Issue Type: Bug
>  Components: c client
>Reporter: Runping Qi
>Assignee: Patrick Hunt
> Fix For: 3.1.0
>
> Attachments: patch_zookeeper_273.txt, ZOOKEEPER-273.patch, 
> ZOOKEEPER-273.patch
>
>
> One should be able to build Zookeeper C client libs on a machine without 
> CPPUNIT installation.
> A simple fix is to remove from configure.ac the following line:
> M_PATH_CPPUNIT(1.10.2)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-273) Zookeeper c client build should not depend on CPPUNIT

2009-01-26 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-273:


Attachment: ZOOKEEPER-273.patch

+1 ... changed the readme to reflect the new option for building the c library.

> Zookeeper c client build should not depend on CPPUNIT
> -
>
> Key: ZOOKEEPER-273
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-273
> Project: Zookeeper
>  Issue Type: Bug
>  Components: c client
>Reporter: Runping Qi
>Assignee: Patrick Hunt
> Fix For: 3.1.0
>
> Attachments: patch_zookeeper_273.txt, ZOOKEEPER-273.patch, 
> ZOOKEEPER-273.patch
>
>
> One should be able to build Zookeeper C client libs on a machine without 
> CPPUNIT installation.
> A simple fix is to remove from configure.ac the following line:
> M_PATH_CPPUNIT(1.10.2)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Issue Comment Edited: (ZOOKEEPER-16) Need to do path validation

2009-01-26 Thread Flavio Paiva Junqueira (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667245#action_12667245
 ] 

fpj edited comment on ZOOKEEPER-16 at 1/26/09 5:46 AM:
--

I went over the patch and it looks good to me, although it is stale and I 
couldn't apply it to trunk. Also, one question I have is why you don't have to 
declare all methods in ZooKeeper.java that invoke validatePath as throwing 
IllegalArgumentException.

I'm canceling the patch for now.

(Never mind about the comment on IllegalArgumentException. I just found out the 
reason: it is an unchecked exception.)

  was (Author: fpj):
I went over the patch and it looks good to me, although it is stale and I 
couldn't apply it to trunk. Also, one question I have is why you don't have to 
declare all methods in ZooKeeper.java that invoke validatePath as throwing 
IllegalArgumentException.

I'm canceling the patch for now.
  
> Need to do path validation
> --
>
> Key: ZOOKEEPER-16
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-16
> Project: Zookeeper
>  Issue Type: Bug
>  Components: c client, java client, server
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-16.patch, ZOOKEEPER-16.patch
>
>
> Moved from SourceForge to Apache.
> http://sourceforge.net/tracker/index.php?func=detail&aid=1963141&group_id=209147&atid=1008544

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-16) Need to do path validation

2009-01-26 Thread Flavio Paiva Junqueira (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Paiva Junqueira updated ZOOKEEPER-16:


Status: Open  (was: Patch Available)

Patch is stale.

> Need to do path validation
> --
>
> Key: ZOOKEEPER-16
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-16
> Project: Zookeeper
>  Issue Type: Bug
>  Components: c client, java client, server
>Affects Versions: 3.0.1, 3.0.0
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-16.patch, ZOOKEEPER-16.patch
>
>
> Moved from SourceForge to Apache.
> http://sourceforge.net/tracker/index.php?func=detail&aid=1963141&group_id=209147&atid=1008544

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-16) Need to do path validation

2009-01-26 Thread Flavio Paiva Junqueira (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667245#action_12667245
 ] 

Flavio Paiva Junqueira commented on ZOOKEEPER-16:
-

I went over the patch and it looks good to me, although it is stale and I 
couldn't apply it to trunk. Also, one question I have is why you don't have to 
declare all methods in ZooKeeper.java that invoke validatePath as throwing 
IllegalArgumentException.

I'm canceling the patch for now.

> Need to do path validation
> --
>
> Key: ZOOKEEPER-16
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-16
> Project: Zookeeper
>  Issue Type: Bug
>  Components: c client, java client, server
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.1.0
>
> Attachments: ZOOKEEPER-16.patch, ZOOKEEPER-16.patch
>
>
> Moved from SourceForge to Apache.
> http://sourceforge.net/tracker/index.php?func=detail&aid=1963141&group_id=209147&atid=1008544

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.