[jira] Commented: (ZOOKEEPER-383) Asynchronous version of createLedger()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710036#action_12710036 ] Benjamin Reed commented on ZOOKEEPER-383: - yes i agree it would be good to use separate jiras. the patch looks good. great job. i'm wondering why you are queuing the operations into a blocking queue to send to a separate thread to issue the async calls. since they are async calls we could just issue them directly. couldn't we? > Asynchronous version of createLedger() > -- > > Key: ZOOKEEPER-383 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-383 > Project: Zookeeper > Issue Type: New Feature > Components: contrib-bookkeeper >Reporter: Utkarsh Srivastava >Assignee: Flavio Paiva Junqueira > Attachments: ZOOKEEPER-383.patch > > > While there are async versions for read and write, there is no async version > for creating a ledger. This can cause applications to have to change their > whole thread design. > It should be easier and more consistent to add an async version of > createLedger(). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (ZOOKEEPER-358) Throw exception when ledger does not exist
[ https://issues.apache.org/jira/browse/ZOOKEEPER-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709910#action_12709910 ] Mahadev konar edited comment on ZOOKEEPER-358 at 5/15/09 1:22 PM: -- flavio, We should still throw an exception with the openledger call. most of the open api calls that you would encounter would throw an exception saying not found rather than failing silently and returning a null. Its understandable that async api cannot throw exceptions and would just return return codes that would map to the exception thrown by the synchronous api. was (Author: mahadev): flavio, We should still throw an exception with the openledger call. The asynchronous api is no excuse to hide excpetions. THe idea is to have asycnrhonous calls return the same error codes as the exception that you throw. For an example, take a look at zookeeper client api in java. It has both the synchronous calls and aysnc calls. The sync calls throw an exception and the async calls call the callback function with a return code which maps to the exception thrown via sync calls. > Throw exception when ledger does not exist > -- > > Key: ZOOKEEPER-358 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-358 > Project: Zookeeper > Issue Type: Improvement > Components: contrib-bookkeeper >Affects Versions: 3.1.1 >Reporter: Luca Telloli >Assignee: Flavio Paiva Junqueira >Priority: Minor > Attachments: ZOOKEEPER-358.patch > > > Currently, openLedger() in the BookKeeper client returns null if the ledger > ID does not exist on ZK. Maybe it would be better to throw a specific > exception so it can be handled by the client side. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-358) Throw exception when ledger does not exist
[ https://issues.apache.org/jira/browse/ZOOKEEPER-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709910#action_12709910 ] Mahadev konar commented on ZOOKEEPER-358: - flavio, We should still throw an exception with the openledger call. The asynchronous api is no excuse to hide excpetions. THe idea is to have asycnrhonous calls return the same error codes as the exception that you throw. For an example, take a look at zookeeper client api in java. It has both the synchronous calls and aysnc calls. The sync calls throw an exception and the async calls call the callback function with a return code which maps to the exception thrown via sync calls. > Throw exception when ledger does not exist > -- > > Key: ZOOKEEPER-358 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-358 > Project: Zookeeper > Issue Type: Improvement > Components: contrib-bookkeeper >Affects Versions: 3.1.1 >Reporter: Luca Telloli >Assignee: Flavio Paiva Junqueira >Priority: Minor > Attachments: ZOOKEEPER-358.patch > > > Currently, openLedger() in the BookKeeper client returns null if the ledger > ID does not exist on ZK. Maybe it would be better to throw a specific > exception so it can be handled by the client side. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ZOOKEEPER-148) add jdiff support to zookeeper release process
[ https://issues.apache.org/jira/browse/ZOOKEEPER-148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar resolved ZOOKEEPER-148. - Resolution: Fixed Assignee: Mahadev konar with the jdiff targets jdiff targets "api-report, api-xml " this jira can be resolved. > add jdiff support to zookeeper release process > -- > > Key: ZOOKEEPER-148 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-148 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Patrick Hunt >Assignee: Mahadev konar >Priority: Minor > Fix For: 3.2.0 > > > Add jdiff support to enable detailed release notes on changes to java. > Hadoop just added code for including that in the build: HADOOP-2421. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (ZOOKEEPER-148) add jdiff support to zookeeper release process
[ https://issues.apache.org/jira/browse/ZOOKEEPER-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709906#action_12709906 ] Mahadev konar edited comment on ZOOKEEPER-148 at 5/15/09 10:04 AM: --- with the jdiff targets "api-report, api-xml " this jira can be resolved. was (Author: mahadev): with the jdiff targets jdiff targets "api-report, api-xml " this jira can be resolved. > add jdiff support to zookeeper release process > -- > > Key: ZOOKEEPER-148 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-148 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Patrick Hunt >Assignee: Mahadev konar >Priority: Minor > Fix For: 3.2.0 > > > Add jdiff support to enable detailed release notes on changes to java. > Hadoop just added code for including that in the build: HADOOP-2421. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-383) Asynchronous version of createLedger()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-383: - Attachment: ZOOKEEPER-383.patch This is a preliminary patch. It works and contains a unit test. It needs a little bit of cleanup before being committed, though. Also, I think it would be good to have the synchronous versions of create, open, and close calling the respective asynchronous versions, just as we do with addEntry and readEntries, to avoid repetition of code. Because this patch corresponds to such a major change, I wonder if it would be best to discuss and implement this last suggestion in a separate jira. > Asynchronous version of createLedger() > -- > > Key: ZOOKEEPER-383 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-383 > Project: Zookeeper > Issue Type: New Feature > Components: contrib-bookkeeper >Reporter: Utkarsh Srivastava >Assignee: Flavio Paiva Junqueira > Attachments: ZOOKEEPER-383.patch > > > While there are async versions for read and write, there is no async version > for creating a ledger. This can cause applications to have to change their > whole thread design. > It should be easier and more consistent to add an async version of > createLedger(). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-358) Throw exception when ledger does not exist
[ https://issues.apache.org/jira/browse/ZOOKEEPER-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709767#action_12709767 ] Flavio Paiva Junqueira commented on ZOOKEEPER-358: -- Thinking more carefully about this modification, I wonder if it really makes sense to throw an exception if you try to open a ledger that doesn't exist. Currently, the code of openLedger returns null if the id passed does not exist. I'm questioning the validity of the modification because I have been working on a patch to make create, open, and close operations asynchronous, and with asynchronous operations we cannot really throw an exception. In summary, I think I prefer the current approach (the one in trunk) because we'll have to do something similar with an asynchronous version of open. That is, we'll indicate that an attempt to open a non-existing ledger is invalid through a null ledger handle or through a return code value. > Throw exception when ledger does not exist > -- > > Key: ZOOKEEPER-358 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-358 > Project: Zookeeper > Issue Type: Improvement > Components: contrib-bookkeeper >Affects Versions: 3.1.1 >Reporter: Luca Telloli >Assignee: Flavio Paiva Junqueira >Priority: Minor > Attachments: ZOOKEEPER-358.patch > > > Currently, openLedger() in the BookKeeper client returns null if the ledger > ID does not exist on ZK. Maybe it would be better to throw a specific > exception so it can be handled by the client side. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
