Build failed in Hudson: ZooKeeper-trunk #341

2009-06-09 Thread Apache Hudson Server
See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/341/changes

Changes:

[breed] forgot to add new files from ZOOKEEPER-336

[breed] ZOOKEEPER-435. allow super admin digest based auth to be configurable

[breed] ZOOKEEPER-434. the java shell should indicate connection status on 
command prompt

[breed] ZOOKEEPER-434. the java shell should indicate connection status on 
command prompt

[breed] ZOOKEEPER-336. single bad client can cause server to stop accepting 
connections

[mahadev] ZOOKEEPER-196. doxygen comment for state argument of watcher_fn 
typedef and implementation differ (...one of the *_STATE constants, otherwise 
-1)

[mahadev] ZOOKEEPER-396. race condition in zookeeper client library between 
zookeeper_close and zoo_synchronous api. (mahadev)

--
[...truncated 128211 lines...]
 [exec] checking sys/socket.h usability... yes
 [exec] checking sys/socket.h presence... yes
 [exec] checking for sys/socket.h... yes
 [exec] checking sys/time.h usability... yes
 [exec] checking sys/time.h presence... yes
 [exec] checking for sys/time.h... yes
 [exec] checking for unistd.h... (cached) yes
 [exec] checking sys/utsname.h usability... yes
 [exec] checking sys/utsname.h presence... yes
 [exec] checking for sys/utsname.h... yes
 [exec] checking for an ANSI C-conforming const... yes
 [exec] checking for inline... inline
 [exec] checking whether time.h and sys/time.h may both be included... yes
 [exec] checking for nfds_t... yes
 [exec] checking for getcwd... yes
 [exec] checking for gethostbyname... yes
 [exec] checking for gethostname... yes
 [exec] checking for getlogin... yes
 [exec] checking for getpwuid_r... yes
 [exec] checking for gettimeofday... yes
 [exec] checking for getuid... yes
 [exec] checking for memmove... yes
 [exec] checking for memset... yes
 [exec] checking for poll... yes
 [exec] checking for socket... yes
 [exec] checking for strchr... yes
 [exec] checking for strdup... yes
 [exec] checking for strerror... yes
 [exec] checking for strtol... yes
 [exec] configure: creating ./config.status
 [exec] config.status: creating Makefile
 [exec] config.status: creating config.h
 [exec] config.status: executing depfiles commands
 [exec] config.status: executing libtool commands

init:

jute:

compile_jute_uptodate:

compile_jute:

clover.setup:

clover.info:

clover:

ver-gen:

svn-revision:

version-info:

build-generated:
[javac] Compiling 1 source file to 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/classes
 

compile-main:
 [copy] Copying 1 file to 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/classes
 

compile-extra:

compile:

jar:
  [jar] Building jar: 
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/zookeeper-dev.jar
 

check-cppunit-makefile:

create-cppunit-makefile:

test-cppunit:
 [exec]  rm -f cli_st cli_st
 [exec]  rm -f cli_mt cli_mt
 [exec]  rm -f load_gen load_gen
 [exec]  rm -f zktest-st zktest-st
 [exec]  rm -f zktest-mt zktest-mt
 [exec] test -z libzookeeper_st.la libzookeeper_mt.la || rm -f 
libzookeeper_st.la libzookeeper_mt.la
 [exec] rm -f ./so_locations
 [exec] rm -f ./so_locations
 [exec] rm -rf .libs _libs
 [exec] rm -f zktest_st-TestDriver.o zktest_st-LibCMocks.o 
zktest_st-LibCSymTable.o zktest_st-MocksBase.o zktest_st-ZKMocks.o 
zktest_st-Util.o zktest_st-ThreadingUtil.o zktest_st-TestClientRetry.o 
zktest_st-TestOperations.o zktest_st-TestZookeeperInit.o 
zktest_st-TestZookeeperClose.o zktest_st-TestClient.o zktest_st-TestWatchers.o 
zktest_mt-TestDriver.o zktest_mt-LibCMocks.o zktest_mt-LibCSymTable.o 
zktest_mt-MocksBase.o zktest_mt-ZKMocks.o zktest_mt-Util.o 
zktest_mt-ThreadingUtil.o zktest_mt-TestClientRetry.o 
zktest_mt-TestOperations.o zktest_mt-TestZookeeperInit.o 
zktest_mt-TestZookeeperClose.o zktest_mt-TestClient.o zktest_mt-TestWatchers.o 
zktest_mt-PthreadMocks.o
 [exec] rm -f docs/c-client-src.tag -r docs/html
 [exec] test -z libhashtable.la libzkst.la libzkmt.la || rm -f 
libhashtable.la libzkst.la libzkmt.la
 [exec] rm -f ./so_locations
 [exec] rm -f ./so_locations
 [exec] rm -f ./so_locations
 [exec] rm -f *.o
 [exec] rm -f *.lo
 [exec] /bin/bash ./libtool --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H 
-I. -Ihttp://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c  
 
-Ihttp://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c/include
  
-Ihttp://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c/tests
  
-Ihttp://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c/generated
   -Wall -Werror  -g -O2 -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c -o 
zookeeper.lo `test -f 'src/zookeeper.c' || echo 

[jira] Commented: (ZOOKEEPER-437) Variety of Documentation Updates

2009-06-09 Thread Grant Ingersoll (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12717644#action_12717644
 ] 

Grant Ingersoll commented on ZOOKEEPER-437:
---

{quote} -1 tests included. The patch doesn't appear to include any new or 
modified tests.
Please justify why no tests are needed for this patch.
{quote}

It's a documentation patch.  The one spot that it touches code is to better 
format the ZooKeeperMain help output

 Variety of Documentation Updates
 

 Key: ZOOKEEPER-437
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-437
 Project: Zookeeper
  Issue Type: Improvement
Reporter: Grant Ingersoll
Assignee: Grant Ingersoll
Priority: Trivial
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-437.patch


 Patch with a variety of documentation updates.  Some new content for getting 
 started based on my experience trying it out, plus some typo fixes, etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: Build failed in Hudson: ZooKeeper-trunk #341

2009-06-09 Thread Henry Robinson
I'm looking into this now...

On Tue, Jun 9, 2009 at 11:45 AM, Apache Hudson Server 
hud...@hudson.zones.apache.org wrote:

 See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/341/changes

 Changes:

 [breed] forgot to add new files from ZOOKEEPER-336

 [breed] ZOOKEEPER-435. allow super admin digest based auth to be
 configurable

 [breed] ZOOKEEPER-434. the java shell should indicate connection status on
 command prompt

 [breed] ZOOKEEPER-434. the java shell should indicate connection status on
 command prompt

 [breed] ZOOKEEPER-336. single bad client can cause server to stop accepting
 connections

 [mahadev] ZOOKEEPER-196. doxygen comment for state argument of watcher_fn
 typedef and implementation differ (...one of the *_STATE constants,
 otherwise -1)

 [mahadev] ZOOKEEPER-396. race condition in zookeeper client library between
 zookeeper_close and zoo_synchronous api. (mahadev)

 --
 [...truncated 128211 lines...]
 [exec] checking sys/socket.h usability... yes
 [exec] checking sys/socket.h presence... yes
 [exec] checking for sys/socket.h... yes
 [exec] checking sys/time.h usability... yes
 [exec] checking sys/time.h presence... yes
 [exec] checking for sys/time.h... yes
 [exec] checking for unistd.h... (cached) yes
 [exec] checking sys/utsname.h usability... yes
 [exec] checking sys/utsname.h presence... yes
 [exec] checking for sys/utsname.h... yes
 [exec] checking for an ANSI C-conforming const... yes
 [exec] checking for inline... inline
 [exec] checking whether time.h and sys/time.h may both be included...
 yes
 [exec] checking for nfds_t... yes
 [exec] checking for getcwd... yes
 [exec] checking for gethostbyname... yes
 [exec] checking for gethostname... yes
 [exec] checking for getlogin... yes
 [exec] checking for getpwuid_r... yes
 [exec] checking for gettimeofday... yes
 [exec] checking for getuid... yes
 [exec] checking for memmove... yes
 [exec] checking for memset... yes
 [exec] checking for poll... yes
 [exec] checking for socket... yes
 [exec] checking for strchr... yes
 [exec] checking for strdup... yes
 [exec] checking for strerror... yes
 [exec] checking for strtol... yes
 [exec] configure: creating ./config.status
 [exec] config.status: creating Makefile
 [exec] config.status: creating config.h
 [exec] config.status: executing depfiles commands
 [exec] config.status: executing libtool commands

 init:

 jute:

 compile_jute_uptodate:

 compile_jute:

 clover.setup:

 clover.info:

 clover:

 ver-gen:

 svn-revision:

 version-info:

 build-generated:
[javac] Compiling 1 source file to
 http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/classes

 compile-main:
 [copy] Copying 1 file to
 http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/classes

 compile-extra:

 compile:

 jar:
  [jar] Building jar:
 http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/zookeeper-dev.jar

 check-cppunit-makefile:

 create-cppunit-makefile:

 test-cppunit:
 [exec]  rm -f cli_st cli_st
 [exec]  rm -f cli_mt cli_mt
 [exec]  rm -f load_gen load_gen
 [exec]  rm -f zktest-st zktest-st
 [exec]  rm -f zktest-mt zktest-mt
 [exec] test -z libzookeeper_st.la libzookeeper_mt.la || rm -f
 libzookeeper_st.la libzookeeper_mt.la
 [exec] rm -f ./so_locations
 [exec] rm -f ./so_locations
 [exec] rm -rf .libs _libs
 [exec] rm -f zktest_st-TestDriver.o zktest_st-LibCMocks.o
 zktest_st-LibCSymTable.o zktest_st-MocksBase.o zktest_st-ZKMocks.o
 zktest_st-Util.o zktest_st-ThreadingUtil.o zktest_st-TestClientRetry.o
 zktest_st-TestOperations.o zktest_st-TestZookeeperInit.o
 zktest_st-TestZookeeperClose.o zktest_st-TestClient.o
 zktest_st-TestWatchers.o zktest_mt-TestDriver.o zktest_mt-LibCMocks.o
 zktest_mt-LibCSymTable.o zktest_mt-MocksBase.o zktest_mt-ZKMocks.o
 zktest_mt-Util.o zktest_mt-ThreadingUtil.o zktest_mt-TestClientRetry.o
 zktest_mt-TestOperations.o zktest_mt-TestZookeeperInit.o
 zktest_mt-TestZookeeperClose.o zktest_mt-TestClient.o
 zktest_mt-TestWatchers.o zktest_mt-PthreadMocks.o
 [exec] rm -f docs/c-client-src.tag -r docs/html
 [exec] test -z libhashtable.la libzkst.la libzkmt.la || rm -f
 libhashtable.la libzkst.la libzkmt.la
 [exec] rm -f ./so_locations
 [exec] rm -f ./so_locations
 [exec] rm -f ./so_locations
 [exec] rm -f *.o
 [exec] rm -f *.lo
 [exec] /bin/bash ./libtool --tag=CC   --mode=compile gcc
 -DHAVE_CONFIG_H -I. -Ihttp://
 hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c
 -Ihttp://
 hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c/include 
 -Ihttp://
 hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c/tests 
 -Ihttp://
 hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c/generated  
 -Wall -Werror  -g -O2 

[jira] Created: (ZOOKEEPER-441) Zk-336 diff got applied twice to TestClientRetry.cc C test, causing compilation failure

2009-06-09 Thread Henry Robinson (JIRA)
Zk-336 diff got applied twice to TestClientRetry.cc C test, causing compilation 
failure
---

 Key: ZOOKEEPER-441
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-441
 Project: Zookeeper
  Issue Type: Bug
Reporter: Henry Robinson
Assignee: Henry Robinson
Priority: Blocker


The latest version of trunk has a src/c/tests/TestClientRetry.cc file that has 
the actual file from ZK-336 appended to itself. This causes the compilation to 
fail due to lots of redeclaration errors. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-441) Zk-336 diff got applied twice to TestClientRetry.cc C test, causing compilation failure

2009-06-09 Thread Henry Robinson (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Henry Robinson updated ZOOKEEPER-441:
-

Attachment: ZOOKEEPER-441.patch

Seems like the patch got applied twice - it's annoying that patch is not 
idempotent for file additions :) I'm not sure if this new patch is the right 
way to fix it, or if the committers should rollback and reapply ZK-336.



 Zk-336 diff got applied twice to TestClientRetry.cc C test, causing 
 compilation failure
 ---

 Key: ZOOKEEPER-441
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-441
 Project: Zookeeper
  Issue Type: Bug
Reporter: Henry Robinson
Assignee: Henry Robinson
Priority: Blocker
 Attachments: ZOOKEEPER-441.patch


 The latest version of trunk has a src/c/tests/TestClientRetry.cc file that 
 has the actual file from ZK-336 appended to itself. This causes the 
 compilation to fail due to lots of redeclaration errors. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-441) Zk-336 diff got applied twice to TestClientRetry.cc C test, causing compilation failure

2009-06-09 Thread Henry Robinson (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Henry Robinson updated ZOOKEEPER-441:
-

Status: Patch Available  (was: Open)

 Zk-336 diff got applied twice to TestClientRetry.cc C test, causing 
 compilation failure
 ---

 Key: ZOOKEEPER-441
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-441
 Project: Zookeeper
  Issue Type: Bug
Reporter: Henry Robinson
Assignee: Henry Robinson
Priority: Blocker
 Attachments: ZOOKEEPER-441.patch


 The latest version of trunk has a src/c/tests/TestClientRetry.cc file that 
 has the actual file from ZK-336 appended to itself. This causes the 
 compilation to fail due to lots of redeclaration errors. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-420) build/test should not require install in zkpython

2009-06-09 Thread Henry Robinson (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Henry Robinson updated ZOOKEEPER-420:
-

Attachment: ZOOKEEPER-420.patch

 build/test should not require install in zkpython
 -

 Key: ZOOKEEPER-420
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-420
 Project: Zookeeper
  Issue Type: Bug
  Components: contrib-bindings
Reporter: Patrick Hunt
Assignee: Henry Robinson
 Attachments: ZOOKEEPER-420.patch


 Currently you cannot just build and test the zkpython contrib, you need to 
 actually install the zookeeper client c library as well
 as the zkpython lib itself.
 There really needs to be 2 steps:
 1) build/test zkpython encapsulated within the src repository, there should 
 be no requirement to actually install anything
 (this is esp the case for automated processes and for review by PMC during 
 release time for example)
 2) build an egg that can be distributed/installed by end user

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-420) build/test should not require install in zkpython

2009-06-09 Thread Henry Robinson (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Henry Robinson updated ZOOKEEPER-420:
-

Attachment: build.jpg

 build/test should not require install in zkpython
 -

 Key: ZOOKEEPER-420
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-420
 Project: Zookeeper
  Issue Type: Bug
  Components: contrib-bindings
Reporter: Patrick Hunt
Assignee: Henry Robinson
 Attachments: build.jpg, ZOOKEEPER-420.patch


 Currently you cannot just build and test the zkpython contrib, you need to 
 actually install the zookeeper client c library as well
 as the zkpython lib itself.
 There really needs to be 2 steps:
 1) build/test zkpython encapsulated within the src repository, there should 
 be no requirement to actually install anything
 (this is esp the case for automated processes and for review by PMC during 
 release time for example)
 2) build an egg that can be distributed/installed by end user

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-420) build/test should not require install in zkpython

2009-06-09 Thread Henry Robinson (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12717673#action_12717673
 ] 

Henry Robinson commented on ZOOKEEPER-420:
--

Here's a strawman patch (not yet ready for submission) which illustrates a 
point.

In order to encapsulate zkpython completely, the C libraries need to be built 
somewhere in the encapsulated tree. From looking at the ant dependency graph (I 
attached a copy of the graph for interest :) ) and experimenting it seems that 
test-cppunit is the only target which makes sure that they are built, and it 
places them in build/test/test-cppunit. 

In this patch, Python will try and link the zookeeper module against those 
libraries first, before looking for /usr/local/lib. However this then 
introduces a dependency between zkpython and the C tests (which I can't build 
on my Mac, due to an unsupported ld option), which I'd rather avoid. If there 
were a separate ant target for building the C libraries (seems like there 
should be - maybe I've missed it?) then I can make zkpython test target depend 
on that.

I don't know the C infrastructure well enough to hack on this without 
confirmation that this is the right thing to do, but will happily separate out 
the targets if it is. 

It seems like this is probably related to ZOOKEEPER-316 as well?

 build/test should not require install in zkpython
 -

 Key: ZOOKEEPER-420
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-420
 Project: Zookeeper
  Issue Type: Bug
  Components: contrib-bindings
Reporter: Patrick Hunt
Assignee: Henry Robinson
 Attachments: build.jpg, ZOOKEEPER-420.patch


 Currently you cannot just build and test the zkpython contrib, you need to 
 actually install the zookeeper client c library as well
 as the zkpython lib itself.
 There really needs to be 2 steps:
 1) build/test zkpython encapsulated within the src repository, there should 
 be no requirement to actually install anything
 (this is esp the case for automated processes and for review by PMC during 
 release time for example)
 2) build an egg that can be distributed/installed by end user

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-441) Zk-336 diff got applied twice to TestClientRetry.cc C test, causing compilation failure

2009-06-09 Thread Benjamin Reed (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12717734#action_12717734
 ] 

Benjamin Reed commented on ZOOKEEPER-441:
-

thanx henry! i had a rough night last night. i missed this one. testing now.

 Zk-336 diff got applied twice to TestClientRetry.cc C test, causing 
 compilation failure
 ---

 Key: ZOOKEEPER-441
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-441
 Project: Zookeeper
  Issue Type: Bug
Reporter: Henry Robinson
Assignee: Henry Robinson
Priority: Blocker
 Attachments: ZOOKEEPER-441.patch


 The latest version of trunk has a src/c/tests/TestClientRetry.cc file that 
 has the actual file from ZK-336 appended to itself. This causes the 
 compilation to fail due to lots of redeclaration errors. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Build failed in Hudson: Zookeeper-Patch-vesta.apache.org #111

2009-06-09 Thread Apache Hudson Server
See 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/111/changes

Changes:

[breed] Fixed bad checkin for ZOOKEEPER-336

[breed] forgot to add new files from ZOOKEEPER-336

[breed] ZOOKEEPER-435. allow super admin digest based auth to be configurable

[breed] ZOOKEEPER-434. the java shell should indicate connection status on 
command prompt

[breed] ZOOKEEPER-434. the java shell should indicate connection status on 
command prompt

[breed] ZOOKEEPER-336. single bad client can cause server to stop accepting 
connections

--
started
Building remotely on vesta.apache.org (Ubuntu)
Updating http://svn.apache.org/repos/asf/hadoop/zookeeper/trunk
U CHANGES.txt
A src/java/test/org/apache/zookeeper/test/AuthTest.java
U src/java/test/org/apache/zookeeper/test/ClientBase.java
A src/java/test/org/apache/zookeeper/test/MaxCnxnsTest.java
A src/java/test/org/apache/zookeeper/test/ClientRetry.java
U src/java/main/org/apache/zookeeper/ZooKeeperMain.java
U src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java
U src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java
U src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java
U 
src/java/main/org/apache/zookeeper/server/auth/DigestAuthenticationProvider.java
U src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java
U src/java/main/org/apache/zookeeper/server/ServerConfig.java
U src/c/tests/zkServer.sh
A src/c/tests/TestClientRetry.cc
U src/c/Makefile.am
U src/docs/src/documentation/content/xdocs/zookeeperStarted.xml
U src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml
Fetching 'http://svn.apache.org/repos/asf/hadoop/core/nightly/test-patch' at -1 
into 
'http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/java/test/bin'
 
At revision 783089
At revision 783089
no change for http://svn.apache.org/repos/asf/hadoop/core/nightly/test-patch 
since the previous build
[Zookeeper-Patch-vesta.apache.org] $ /bin/bash /tmp/hudson5666206495218839426.sh
/home/hudson/tools/java/latest1.6/bin/java
Buildfile: build.xml

check-for-findbugs:

findbugs.check:

java5.check:

forrest.check:

hudson-test-patch:
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Testing patch for ZOOKEEPER-441.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Reverted 'src/c/tests/TestClient.cc'
 [exec] Reverted 'src/c/src/zk_adaptor.h'
 [exec] Reverted 'src/c/src/zookeeper.c'
 [exec] Reverted 'src/c/src/mt_adaptor.c'
 [exec] 
 [exec] Fetching external item into 'src/java/test/bin'
 [exec] Asrc/java/test/bin/test-patch.sh
 [exec] Updated external to revision 783089.
 [exec] 
 [exec] Updated to revision 783089.
 [exec] ZOOKEEPER-441 is not Patch Available.  Exiting.
 [exec]   % Total% Received % Xferd  Average Speed   TimeTime 
Time  Current
 [exec]  Dload  Upload   Total   Spent
Left  Speed
 [exec] 
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec]   0 00 00 0  0  0 --:--:-- --:--:-- 
--:--:-- 0  0 00 00 0  0  0 --:--:-- --:--:-- 
--:--:-- 0

BUILD SUCCESSFUL
Total time: 2 seconds
ERROR: No artifacts found that match the file pattern 
trunk/build/test/findbugs/newPatchFindbugsWarnings.html,trunk/patchprocess/*Warnings.txt.
 Configuration error?
ERROR: 'trunk/build/test/findbugs/newPatchFindbugsWarnings.html' doesn't match 
anything: 'trunk' exists but not 
'trunk/build/test/findbugs/newPatchFindbugsWarnings.html'
Recording test results
Description found: ZOOKEEPER-441



[jira] Updated: (ZOOKEEPER-437) Variety of Documentation Updates

2009-06-09 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-437:


Status: Open  (was: Patch Available)

 Variety of Documentation Updates
 

 Key: ZOOKEEPER-437
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-437
 Project: Zookeeper
  Issue Type: Improvement
Reporter: Grant Ingersoll
Assignee: Grant Ingersoll
Priority: Trivial
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-437.patch, ZOOKEEPER-437.patch


 Patch with a variety of documentation updates.  Some new content for getting 
 started based on my experience trying it out, plus some typo fixes, etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-437) Variety of Documentation Updates

2009-06-09 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-437:


Attachment: ZOOKEEPER-437.patch

the  patch conflicted because of the last commit, so I made some changes and 
uploaded a new patch.

 Variety of Documentation Updates
 

 Key: ZOOKEEPER-437
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-437
 Project: Zookeeper
  Issue Type: Improvement
Reporter: Grant Ingersoll
Assignee: Grant Ingersoll
Priority: Trivial
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-437.patch, ZOOKEEPER-437.patch


 Patch with a variety of documentation updates.  Some new content for getting 
 started based on my experience trying it out, plus some typo fixes, etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-437) Variety of Documentation Updates

2009-06-09 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-437:


Status: Patch Available  (was: Open)

rerunning through the hudson... 

 Variety of Documentation Updates
 

 Key: ZOOKEEPER-437
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-437
 Project: Zookeeper
  Issue Type: Improvement
Reporter: Grant Ingersoll
Assignee: Grant Ingersoll
Priority: Trivial
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-437.patch, ZOOKEEPER-437.patch


 Patch with a variety of documentation updates.  Some new content for getting 
 started based on my experience trying it out, plus some typo fixes, etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-375) zoo_add_auth only retains most recent auth on re-sync

2009-06-09 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-375:


Resolution: Fixed
Status: Resolved  (was: Patch Available)

I just committed this.

 zoo_add_auth only retains most recent auth on re-sync
 -

 Key: ZOOKEEPER-375
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-375
 Project: Zookeeper
  Issue Type: Bug
  Components: c client
Affects Versions: 3.1.0, 3.1.1
Reporter: Patrick Hunt
Assignee: Mahadev konar
Priority: Blocker
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-375.patch, ZOOKEEPER-375.patch, 
 ZOOKEEPER-375.patch


 zoo_add_auth doesn't maintain a list of auths - it only stores the most 
 recent auth send to the server. As a result on re-sync to the cluster it will 
 lose (not reregister) any auths prior to the most recent.
 This code should maintain a list of auths similar to the java code. Be sure 
 to free the memory in close.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-237) Add a Chroot request

2009-06-09 Thread Mahadev konar (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12717788#action_12717788
 ] 

Mahadev konar commented on ZOOKEEPER-237:
-

pat, this patch does not apply any more, can you update the patch to merge with 
the trunk?

 Add a Chroot request
 

 Key: ZOOKEEPER-237
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-237
 Project: Zookeeper
  Issue Type: New Feature
  Components: c client, java client
Reporter: Benjamin Reed
Assignee: Mahadev konar
Priority: Minor
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-237.patch


 It would be nice to be able to root ZooKeeper handles at specific points in 
 the namespace, so that applications that use ZooKeeper can work in their own 
 rooted subtree.
 For example, if ops decides that application X can use the subtree /apps/X 
 and application Y can use the subtree /apps/Y, X can to a chroot to /apps/X 
 and then all its path references can be rooted at /apps/X. Thus when X 
 creates the path /myid, it will actually be creating the path 
 /apps/X/myid.
 There are two ways we can expose this mechanism: 1) We can simply add a 
 chroot(String path) API, or 2) we can integrate into a service identifier 
 scheme for example zk://server1:2181,server2:2181/my/root. I like the second 
 form personally.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-237) Add a Chroot request

2009-06-09 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-237:
---

Attachment: ZOOKEEPER-237.patch

merged into latest trunk

 Add a Chroot request
 

 Key: ZOOKEEPER-237
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-237
 Project: Zookeeper
  Issue Type: New Feature
  Components: c client, java client
Reporter: Benjamin Reed
Assignee: Mahadev konar
Priority: Minor
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-237.patch, ZOOKEEPER-237.patch


 It would be nice to be able to root ZooKeeper handles at specific points in 
 the namespace, so that applications that use ZooKeeper can work in their own 
 rooted subtree.
 For example, if ops decides that application X can use the subtree /apps/X 
 and application Y can use the subtree /apps/Y, X can to a chroot to /apps/X 
 and then all its path references can be rooted at /apps/X. Thus when X 
 creates the path /myid, it will actually be creating the path 
 /apps/X/myid.
 There are two ways we can expose this mechanism: 1) We can simply add a 
 chroot(String path) API, or 2) we can integrate into a service identifier 
 scheme for example zk://server1:2181,server2:2181/my/root. I like the second 
 form personally.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-237) Add a Chroot request

2009-06-09 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-237:
---

Status: Patch Available  (was: Open)

 Add a Chroot request
 

 Key: ZOOKEEPER-237
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-237
 Project: Zookeeper
  Issue Type: New Feature
  Components: c client, java client
Reporter: Benjamin Reed
Assignee: Mahadev konar
Priority: Minor
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-237.patch, ZOOKEEPER-237.patch


 It would be nice to be able to root ZooKeeper handles at specific points in 
 the namespace, so that applications that use ZooKeeper can work in their own 
 rooted subtree.
 For example, if ops decides that application X can use the subtree /apps/X 
 and application Y can use the subtree /apps/Y, X can to a chroot to /apps/X 
 and then all its path references can be rooted at /apps/X. Thus when X 
 creates the path /myid, it will actually be creating the path 
 /apps/X/myid.
 There are two ways we can expose this mechanism: 1) We can simply add a 
 chroot(String path) API, or 2) we can integrate into a service identifier 
 scheme for example zk://server1:2181,server2:2181/my/root. I like the second 
 form personally.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-237) Add a Chroot request

2009-06-09 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-237:
---

Status: Open  (was: Patch Available)

oops, cancel, waiting for c code from Mahadev

 Add a Chroot request
 

 Key: ZOOKEEPER-237
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-237
 Project: Zookeeper
  Issue Type: New Feature
  Components: c client, java client
Reporter: Benjamin Reed
Assignee: Mahadev konar
Priority: Minor
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-237.patch, ZOOKEEPER-237.patch


 It would be nice to be able to root ZooKeeper handles at specific points in 
 the namespace, so that applications that use ZooKeeper can work in their own 
 rooted subtree.
 For example, if ops decides that application X can use the subtree /apps/X 
 and application Y can use the subtree /apps/Y, X can to a chroot to /apps/X 
 and then all its path references can be rooted at /apps/X. Thus when X 
 creates the path /myid, it will actually be creating the path 
 /apps/X/myid.
 There are two ways we can expose this mechanism: 1) We can simply add a 
 chroot(String path) API, or 2) we can integrate into a service identifier 
 scheme for example zk://server1:2181,server2:2181/my/root. I like the second 
 form personally.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-437) Variety of Documentation Updates

2009-06-09 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12717852#action_12717852
 ] 

Hadoop QA commented on ZOOKEEPER-437:
-

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12410239/ZOOKEEPER-437.patch
  against trunk revision 783096.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no tests are needed for this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/112/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/112/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/112/console

This message is automatically generated.

 Variety of Documentation Updates
 

 Key: ZOOKEEPER-437
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-437
 Project: Zookeeper
  Issue Type: Improvement
Reporter: Grant Ingersoll
Assignee: Grant Ingersoll
Priority: Trivial
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-437.patch, ZOOKEEPER-437.patch


 Patch with a variety of documentation updates.  Some new content for getting 
 started based on my experience trying it out, plus some typo fixes, etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Build failed in Hudson: Zookeeper-Patch-vesta.apache.org #112

2009-06-09 Thread Apache Hudson Server
See 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/112/changes

Changes:

[mahadev] ZOOKEEPER-375. zoo_add_auth only retains most recent auth on re-sync. 
(mahadev)

--
[...truncated 119372 lines...]
 [exec]  [exec] g++ -DHAVE_CONFIG_H -I. 
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c
   
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/include
  
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/tests
  
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/generated
   -DUSE_STATIC_LIB 
-DZKSERVER_CMD=\http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/tests/zkServer.sh\;
  -Wall -g -MT zktest_st-LibCSymTable.o -MD -MP -MF 
.deps/zktest_st-LibCSymTable.Tpo -c -o zktest_st-LibCSymTable.o `test -f 
'tests/LibCSymTable.cc' || echo 
'http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/'`tests/LibCSymTable.cc
 
 [exec]  [exec] mv -f .deps/zktest_st-LibCSymTable.Tpo 
.deps/zktest_st-LibCSymTable.Po
 [exec]  [exec] g++ -DHAVE_CONFIG_H -I. 
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c
   
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/include
  
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/tests
  
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/generated
   -DUSE_STATIC_LIB 
-DZKSERVER_CMD=\http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/tests/zkServer.sh\;
  -Wall -g -MT zktest_st-MocksBase.o -MD -MP -MF .deps/zktest_st-MocksBase.Tpo 
-c -o zktest_st-MocksBase.o `test -f 'tests/MocksBase.cc' || echo 
'http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/'`tests/MocksBase.cc
 
 [exec]  [exec] mv -f .deps/zktest_st-MocksBase.Tpo 
.deps/zktest_st-MocksBase.Po
 [exec]  [exec] g++ -DHAVE_CONFIG_H -I. 
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c
   
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/include
  
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/tests
  
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/generated
   -DUSE_STATIC_LIB 
-DZKSERVER_CMD=\http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/tests/zkServer.sh\;
  -Wall -g -MT zktest_st-ZKMocks.o -MD -MP -MF .deps/zktest_st-ZKMocks.Tpo -c 
-o zktest_st-ZKMocks.o `test -f 'tests/ZKMocks.cc' || echo 
'http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/'`tests/ZKMocks.cc
 
 [exec]  [exec] mv -f .deps/zktest_st-ZKMocks.Tpo 
.deps/zktest_st-ZKMocks.Po
 [exec]  [exec] g++ -DHAVE_CONFIG_H -I. 
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c
   
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/include
  
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/tests
  
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/generated
   -DUSE_STATIC_LIB 
-DZKSERVER_CMD=\http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/tests/zkServer.sh\;
  -Wall -g -MT zktest_st-Util.o -MD -MP -MF .deps/zktest_st-Util.Tpo -c -o 
zktest_st-Util.o `test -f 'tests/Util.cc' || echo 
'http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/'`tests/Util.cc
 
 [exec]  [exec] mv -f .deps/zktest_st-Util.Tpo .deps/zktest_st-Util.Po
 [exec]  [exec] g++ -DHAVE_CONFIG_H -I. 
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c
   
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/include
  
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/tests
  
-Ihttp://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/generated
   -DUSE_STATIC_LIB 
-DZKSERVER_CMD=\http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/tests/zkServer.sh\;
  -Wall -g -MT zktest_st-ThreadingUtil.o -MD -MP -MF 
.deps/zktest_st-ThreadingUtil.Tpo -c -o zktest_st-ThreadingUtil.o `test -f 
'tests/ThreadingUtil.cc' || echo 
'http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/c/'`tests/ThreadingUtil.cc
 
 [exec]  [exec] mv -f .deps/zktest_st-ThreadingUtil.Tpo 

[jira] Updated: (ZOOKEEPER-437) Variety of Documentation Updates

2009-06-09 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-437:


  Resolution: Fixed
Hadoop Flags: [Reviewed]
  Status: Resolved  (was: Patch Available)

I just committed this. thanks grant.

 Variety of Documentation Updates
 

 Key: ZOOKEEPER-437
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-437
 Project: Zookeeper
  Issue Type: Improvement
Reporter: Grant Ingersoll
Assignee: Grant Ingersoll
Priority: Trivial
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-437.patch, ZOOKEEPER-437.patch


 Patch with a variety of documentation updates.  Some new content for getting 
 started based on my experience trying it out, plus some typo fixes, etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-356) Masking bookie failure during writes to a ledger

2009-06-09 Thread Benjamin Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Reed updated ZOOKEEPER-356:


Status: Open  (was: Patch Available)

-1 wow you did a lot of work flavio. big patch, so i found a couple of 
problems. (some i might just be confused about.) it shouldn't be much to fix:

* in LedgerOutputStream why are you interrupting the thread on BKExceptions
* in the tests, why are you catching and just logging BKExceptions? shouldn't 
those make the tests fail?
* i think _down_ should be volatile in BookieServer
* why do you pass a BookieHandle to BookieClient
* in BookKeeper you should probably catch NumberFormatException when you call 
Long.parseLong its one of those things are are really hard to debug if it 
happens
* could you add a comment to the top of BookKeeper to explain how the different 
znodes are used? it will really help the next person
* i think _stop_ and _incoming_ should be updated and read in the same 
synchronized block right?
* in LedgerManager @return says getItem returns a long rather than String
* are next and errorCounter used in ClientCB?

very nice job on using the state machine to process the asynchronous calls!


 Masking bookie failure during writes to a ledger
 

 Key: ZOOKEEPER-356
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-356
 Project: Zookeeper
  Issue Type: New Feature
  Components: contrib-bookkeeper
Reporter: Flavio Paiva Junqueira
Assignee: Flavio Paiva Junqueira
 Fix For: 3.2.0

 Attachments: ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, 
 ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, 
 ZOOKEEPER-BOOKKEEPER-356.patch


 The idea of this jira is to work out the changes necessary to make a client 
 mask the failure of a bookie while writing to a ledger. I'm submitting a 
 preliminary patch, but before I submit a final one, I need to have 288 
 committed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Build failed in Hudson: Zookeeper-Patch-vesta.apache.org #113

2009-06-09 Thread Apache Hudson Server
See 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/113/changes

Changes:

[mahadev] ZOOKEEPER-437. Variety of Documentation Updates (grant via mahadev)

--
started
Building remotely on vesta.apache.org (Ubuntu)
Updating http://svn.apache.org/repos/asf/hadoop/zookeeper/trunk
U CHANGES.txt
G src/java/main/org/apache/zookeeper/ZooKeeperMain.java
G src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
G src/docs/src/documentation/content/xdocs/zookeeperTutorial.xml
G src/docs/src/documentation/content/xdocs/zookeeperStarted.xml
U docs/zookeeperAdmin.html
U docs/zookeeperAdmin.pdf
U docs/zookeeperProgrammers.html
U docs/zookeeperProgrammers.pdf
U docs/zookeeperStarted.html
U docs/zookeeperStarted.pdf
Fetching 'http://svn.apache.org/repos/asf/hadoop/core/nightly/test-patch' at -1 
into 
'http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/ws/trunk/src/java/test/bin'
 
At revision 783182
At revision 783182
no change for http://svn.apache.org/repos/asf/hadoop/core/nightly/test-patch 
since the previous build
[Zookeeper-Patch-vesta.apache.org] $ /bin/bash /tmp/hudson7045168241628526120.sh
/home/hudson/tools/java/latest1.6/bin/java
Buildfile: build.xml

check-for-findbugs:

findbugs.check:

java5.check:

forrest.check:

hudson-test-patch:
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Testing patch for ZOOKEEPER-237.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Fetching external item into 'src/java/test/bin'
 [exec] Asrc/java/test/bin/test-patch.sh
 [exec] Updated external to revision 783182.
 [exec] 
 [exec] Updated to revision 783182.
 [exec] ZOOKEEPER-237 is not Patch Available.  Exiting.
 [exec]   % Total% Received % Xferd  Average Speed   TimeTime 
Time  Current
 [exec]  Dload  Upload   Total   Spent
Left  Speed
 [exec] 
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec]   0 00 00 0  0  0 --:--:-- --:--:-- 
--:--:-- 0  0 00 00 0  0  0 --:--:-- --:--:-- 
--:--:-- 0

BUILD SUCCESSFUL
Total time: 2 seconds
ERROR: No artifacts found that match the file pattern 
trunk/build/test/findbugs/newPatchFindbugsWarnings.html,trunk/patchprocess/*Warnings.txt.
 Configuration error?
ERROR: 'trunk/build/test/findbugs/newPatchFindbugsWarnings.html' doesn't match 
anything: 'trunk' exists but not 
'trunk/build/test/findbugs/newPatchFindbugsWarnings.html'
Recording test results
Description found: ZOOKEEPER-237