Benjamin Reed updated ZOOKEEPER-356:

    Status: Open  (was: Patch Available)

-1 wow you did a lot of work flavio. big patch, so i found a couple of 
problems. (some i might just be confused about.) it shouldn't be much to fix:

* in LedgerOutputStream why are you interrupting the thread on BKExceptions
* in the tests, why are you catching and just logging BKExceptions? shouldn't 
those make the tests fail?
* i think _down_ should be volatile in BookieServer
* why do you pass a BookieHandle to BookieClient
* in BookKeeper you should probably catch NumberFormatException when you call 
Long.parseLong its one of those things are are really hard to debug if it 
* could you add a comment to the top of BookKeeper to explain how the different 
znodes are used? it will really help the next person
* i think _stop_ and _incoming_ should be updated and read in the same 
synchronized block right?
* in LedgerManager @return says getItem returns a long rather than String
* are next and errorCounter used in ClientCB?

very nice job on using the state machine to process the asynchronous calls!

> Masking bookie failure during writes to a ledger
> ------------------------------------------------
>                 Key: ZOOKEEPER-356
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-356
>             Project: Zookeeper
>          Issue Type: New Feature
>          Components: contrib-bookkeeper
>            Reporter: Flavio Paiva Junqueira
>            Assignee: Flavio Paiva Junqueira
>             Fix For: 3.2.0
>         Attachments: ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, 
> ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, 
> The idea of this jira is to work out the changes necessary to make a client 
> mask the failure of a bookie while writing to a ledger. I'm submitting a 
> preliminary patch, but before I submit a final one, I need to have 288 
> committed.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to