[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789391#action_12789391 ] Patrick Hunt commented on ZOOKEEPER-458: Have you tried running with valgrind? connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-599) Changes to FLE and QuorumCnxManager to support Observers
[
https://issues.apache.org/jira/browse/ZOOKEEPER-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789392#action_12789392
]
Benjamin Reed commented on ZOOKEEPER-599:
-
looks good flavio. i'd like to request two changes:
1) can you remove or expand debug message so that they are more informative?
for example, if(recvqueue.size() == 0) LOG.debug(Message: + n.sid);
doesn't describe what is going on or why the message is being logged.
2) can we simplify:
+Random r = new Random();
+do{
+sid = 1L + ((long) r.nextInt(1));
+} while(self.getVotingView().containsKey(sid)
+|| senderWorkerMap.containsKey(sid));
if we guarantee that followers are non-negative, we could pick negative sids
for observers, so that we don't have to worry about observers colliding with
follower sids. it might also help later for debugging.
Changes to FLE and QuorumCnxManager to support Observers
Key: ZOOKEEPER-599
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-599
Project: Zookeeper
Issue Type: Improvement
Reporter: Flavio Paiva Junqueira
Assignee: Flavio Paiva Junqueira
Fix For: 3.3.0
Attachments: ZOOKEEPER-599.patch, ZOOKEEPER-599.patch,
ZOOKEEPER-599.patch
Observers currently can only use electionAlg 0, which is not the default,
supported leader implementation. This issue will fix it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-618) hudson not reporting failures correctly
[ https://issues.apache.org/jira/browse/ZOOKEEPER-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789430#action_12789430 ] Giridharan Kesavan commented on ZOOKEEPER-618: -- Patrick, I dont see Quorum test failure in the console o/p of the build that you have mentioned.. Is 612 the build that you are talkin about? hudson not reporting failures correctly --- Key: ZOOKEEPER-618 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-618 Project: Zookeeper Issue Type: Bug Components: tests Affects Versions: 3.3.0 Reporter: Patrick Hunt Assignee: Giridharan Kesavan Priority: Critical See http://hudson.zones.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/612/ this test failed however there is no indication in the hudson page why it failed. Looking at the raw console output I see [junit] Running org.apache.zookeeper.test.QuorumTest [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec [junit] Test org.apache.zookeeper.test.QuorumTest FAILED (timeout) So it seems there is an error in hudson reporting. Giri can you look into this? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-618) hudson not reporting failures correctly
[ https://issues.apache.org/jira/browse/ZOOKEEPER-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789445#action_12789445 ] Patrick Hunt commented on ZOOKEEPER-618: you know, I must have looked at the wrong consoletext file (they are all named the same by default). Regardless - in this case there is no report of why the build failed. Looking at the console again, I see that it failed due to some problem during cppunit. We've seen similar though for other things like svn checkout failure, and random build issues like running clover w/o the right libs, etc... It wold be great at least if the hudson page could indicate that this failed due to cppunit failure. hudson not reporting failures correctly --- Key: ZOOKEEPER-618 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-618 Project: Zookeeper Issue Type: Bug Components: tests Affects Versions: 3.3.0 Reporter: Patrick Hunt Assignee: Giridharan Kesavan Priority: Critical See http://hudson.zones.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/612/ this test failed however there is no indication in the hudson page why it failed. Looking at the raw console output I see [junit] Running org.apache.zookeeper.test.QuorumTest [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec [junit] Test org.apache.zookeeper.test.QuorumTest FAILED (timeout) So it seems there is an error in hudson reporting. Giri can you look into this? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-600) TODO pondering about allocation behavior in zkpython may be removed
[
https://issues.apache.org/jira/browse/ZOOKEEPER-600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Robinson updated ZOOKEEPER-600:
-
Status: Patch Available (was: Open)
Marking as patch submitted so that hudsonqabot can take a look.
TODO pondering about allocation behavior in zkpython may be removed
---
Key: ZOOKEEPER-600
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-600
Project: Zookeeper
Issue Type: Bug
Components: contrib-bindings
Affects Versions: 3.2.1
Reporter: Gustavo Niemeyer
Assignee: Gustavo Niemeyer
Priority: Trivial
Fix For: 3.3.0
Attachments: deallocate-vector.patch
I suppose the TODO below is referring to the path variable which is passed
in as an output variable to PyArg_ParseTuple right below. The TODO may be
removed, since the code is right. Code using PyArg_ParseTuple will borrow
the reference from the calling code, since there's a stack behind the call to
the enclosing function (pyzoo_get_children in this case) which won't go away
until the function returns.
Index: src/contrib/zkpython/src/c/zookeeper.c
===
--- src/contrib/zkpython/src/c/zookeeper.c(revision 885582)
+++ src/contrib/zkpython/src/c/zookeeper.c(working copy)
@@ -774,8 +774,6 @@
static PyObject *pyzoo_get_children(PyObject *self, PyObject *args)
{
- // TO DO: Does Python copy the string or the reference? If it's the former
- // we should free the String_vector
int zkhid;
char *path;
PyObject *watcherfn = Py_None;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-610) cleanup final fields, esp those used for locking
[ https://issues.apache.org/jira/browse/ZOOKEEPER-610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henry Robinson updated ZOOKEEPER-610: - Status: Patch Available (was: Open) Resubmitting to push through hudsonqabot. cleanup final fields, esp those used for locking Key: ZOOKEEPER-610 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-610 Project: Zookeeper Issue Type: Bug Components: java client, server Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-610.patch There are a number of places where we have non-final fields that could (should) be declared as final. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ZOOKEEPER-619) hudson test failure in QuorumTest -- timeout error
[ https://issues.apache.org/jira/browse/ZOOKEEPER-619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt resolved ZOOKEEPER-619. Resolution: Invalid Assignee: Patrick Hunt My bad, looked at the wrong consoletext file, this was really an issue with cppunit build - someone was running a test by hand on h8 and it caused this test to fail (reuse of port #). Issue addressed on h8 and now things are fine.. hudson test failure in QuorumTest -- timeout error -- Key: ZOOKEEPER-619 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-619 Project: Zookeeper Issue Type: Bug Affects Versions: 3.3.0 Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Critical Fix For: 3.3.0 Hudson is not reporting this correctly but: http://hudson.zones.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/612/ [junit] 2009-12-03 08:46:27,297 - INFO [QuorumPeer:/0:0:0:0:0:0:0:0:11301:leaderelect...@109] - 5- 2 [junit] Running org.apache.zookeeper.test.QuorumTest [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec [junit] Test org.apache.zookeeper.test.QuorumTest FAILED (timeout) [junit] 2009-12-03 08:46:28,390 - INFO [main:portassignm...@31] - assigning port 11221 [junit] 2009-12-03 08:46:28,393 - INFO [main:portassignm...@31] - assigning port 11222 [junit] Running org.apache.zookeeper.test.QuorumZxidSyncTest but this makes no sense - how is this a timeout? One concern is - perhaps this is a deadlock? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-616) Provide a function to parse out the name and the sequence number from a zknode path
[ https://issues.apache.org/jira/browse/ZOOKEEPER-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789475#action_12789475 ] Patrick Hunt commented on ZOOKEEPER-616: Actually this is very well documented in the current release docs: http://hadoop.apache.org/zookeeper/docs/current/zookeeperProgrammers.html#Sequence+Nodes+--+Unique+Naming When creating a znode you can also request that ZooKeeper append a monotonicly increasing counter to the end of path. This counter is unique to the parent znode. The counter has a format of %010d -- that is 10 digits with 0 (zero) padding (the counter is formatted in this way to simplify sorting), i.e. path01. However this does sound like a reasonable request to me. Where should we put it though? Stick it into ZooKeeper class, or in some new ZooKeeperUtils class? (both don't seem optimal) As we don't have a ZNode class on the client (Stat is probably the closest) there's no obvious place to put it afaict. Provide a function to parse out the name and the sequence number from a zknode path --- Key: ZOOKEEPER-616 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-616 Project: Zookeeper Issue Type: New Feature Components: c client, java client Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1, 3.2.0, 3.2.1 Reporter: Avery Ching Priority: Minor Fix For: 3.3.0 Given a zookeeper path and knowing it was created with the SEQUENCE flag, it would be nice to be able to get the sequence number and the name. Currently, it is not documented how many bytes the sequence number uses in the path (Mahadev told me 10 for 3.1.1 for example), and having a function to retrieve this data would hide the actual number of bytes used and provide the useful functionality for users. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-600) TODO pondering about allocation behavior in zkpython may be removed
[
https://issues.apache.org/jira/browse/ZOOKEEPER-600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789476#action_12789476
]
Hadoop QA commented on ZOOKEEPER-600:
-
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12426565/deallocate-vector.patch
against trunk revision 888216.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/22/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/22/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/22/console
This message is automatically generated.
TODO pondering about allocation behavior in zkpython may be removed
---
Key: ZOOKEEPER-600
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-600
Project: Zookeeper
Issue Type: Bug
Components: contrib-bindings
Affects Versions: 3.2.1
Reporter: Gustavo Niemeyer
Assignee: Gustavo Niemeyer
Priority: Trivial
Fix For: 3.3.0
Attachments: deallocate-vector.patch
I suppose the TODO below is referring to the path variable which is passed
in as an output variable to PyArg_ParseTuple right below. The TODO may be
removed, since the code is right. Code using PyArg_ParseTuple will borrow
the reference from the calling code, since there's a stack behind the call to
the enclosing function (pyzoo_get_children in this case) which won't go away
until the function returns.
Index: src/contrib/zkpython/src/c/zookeeper.c
===
--- src/contrib/zkpython/src/c/zookeeper.c(revision 885582)
+++ src/contrib/zkpython/src/c/zookeeper.c(working copy)
@@ -774,8 +774,6 @@
static PyObject *pyzoo_get_children(PyObject *self, PyObject *args)
{
- // TO DO: Does Python copy the string or the reference? If it's the former
- // we should free the String_vector
int zkhid;
char *path;
PyObject *watcherfn = Py_None;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-616) Provide a function to parse out the name and the sequence number from a zknode path
[ https://issues.apache.org/jira/browse/ZOOKEEPER-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789479#action_12789479 ] Mahadev konar commented on ZOOKEEPER-616: - Its more appropriate to put it in a zookeeperutils class. We should have one anyway for both c and java. Provide a function to parse out the name and the sequence number from a zknode path --- Key: ZOOKEEPER-616 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-616 Project: Zookeeper Issue Type: New Feature Components: c client, java client Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1, 3.2.0, 3.2.1 Reporter: Avery Ching Priority: Minor Fix For: 3.3.0 Given a zookeeper path and knowing it was created with the SEQUENCE flag, it would be nice to be able to get the sequence number and the name. Currently, it is not documented how many bytes the sequence number uses in the path (Mahadev told me 10 for 3.1.1 for example), and having a function to retrieve this data would hide the actual number of bytes used and provide the useful functionality for users. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-606) bin scripts don't work in cygwin (spaces in paths)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789480#action_12789480 ] Patrick Hunt commented on ZOOKEEPER-606: note to reviewer(s): be sure to verify these on cygwin/unix macosx bin scripts don't work in cygwin (spaces in paths) -- Key: ZOOKEEPER-606 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-606 Project: Zookeeper Issue Type: Bug Components: scripts Affects Versions: 3.2.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.3.0 Attachments: ZOOKEEPER-606.patch, ZOOKEEPER-606.patch the scripts in bin fail under cygwin due to spaces not handled properly -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-615) wrong javadoc for create with a sequence flag
[ https://issues.apache.org/jira/browse/ZOOKEEPER-615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-615: Resolution: Fixed Status: Resolved (was: Patch Available) wrong javadoc for create with a sequence flag - Key: ZOOKEEPER-615 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-615 Project: Zookeeper Issue Type: Bug Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.3.0 Attachments: ZOOKEEPER-615.patch The javadoc for create with a sequence flag mentions a suffix of \_i but the true suffix is just i and no \_. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-615) wrong javadoc for create with a sequence flag
[ https://issues.apache.org/jira/browse/ZOOKEEPER-615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789485#action_12789485 ] Benjamin Reed commented on ZOOKEEPER-615: - Committed revision 889780. wrong javadoc for create with a sequence flag - Key: ZOOKEEPER-615 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-615 Project: Zookeeper Issue Type: Bug Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.3.0 Attachments: ZOOKEEPER-615.patch The javadoc for create with a sequence flag mentions a suffix of \_i but the true suffix is just i and no \_. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-610) cleanup final fields, esp those used for locking
[ https://issues.apache.org/jira/browse/ZOOKEEPER-610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789487#action_12789487 ] Hadoop QA commented on ZOOKEEPER-610: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12426874/ZOOKEEPER-610.patch against trunk revision 888216. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/23/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/23/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/23/console This message is automatically generated. cleanup final fields, esp those used for locking Key: ZOOKEEPER-610 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-610 Project: Zookeeper Issue Type: Bug Components: java client, server Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-610.patch There are a number of places where we have non-final fields that could (should) be declared as final. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-614) Improper synchronisation in getClientCnxnCount
[ https://issues.apache.org/jira/browse/ZOOKEEPER-614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789530#action_12789530 ] Mahadev konar commented on ZOOKEEPER-614: - +1 the patch looks good. ill wait for hudson to run it and will commit it... Improper synchronisation in getClientCnxnCount -- Key: ZOOKEEPER-614 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-614 Project: Zookeeper Issue Type: Bug Components: server Affects Versions: 3.2.1, 3.2.2 Reporter: Henry Robinson Assignee: Henry Robinson Fix For: 3.3.0 Attachments: ZOOKEEPER-614.patch getClientCnxnCount reads from Factory.ipMap without synchronizing. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-614) Improper synchronisation in getClientCnxnCount
[ https://issues.apache.org/jira/browse/ZOOKEEPER-614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-614: Status: Patch Available (was: Open) trying hudson. Improper synchronisation in getClientCnxnCount -- Key: ZOOKEEPER-614 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-614 Project: Zookeeper Issue Type: Bug Components: server Affects Versions: 3.2.1, 3.2.2 Reporter: Henry Robinson Assignee: Henry Robinson Fix For: 3.3.0 Attachments: ZOOKEEPER-614.patch getClientCnxnCount reads from Factory.ipMap without synchronizing. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-614) Improper synchronisation in getClientCnxnCount
[ https://issues.apache.org/jira/browse/ZOOKEEPER-614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-614: Status: Open (was: Patch Available) Improper synchronisation in getClientCnxnCount -- Key: ZOOKEEPER-614 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-614 Project: Zookeeper Issue Type: Bug Components: server Affects Versions: 3.2.1, 3.2.2 Reporter: Henry Robinson Assignee: Henry Robinson Fix For: 3.3.0 Attachments: ZOOKEEPER-614.patch getClientCnxnCount reads from Factory.ipMap without synchronizing. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-614) Improper synchronisation in getClientCnxnCount
[ https://issues.apache.org/jira/browse/ZOOKEEPER-614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789545#action_12789545 ] Hadoop QA commented on ZOOKEEPER-614: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12427252/ZOOKEEPER-614.patch against trunk revision 889797. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/24/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/24/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/24/console This message is automatically generated. Improper synchronisation in getClientCnxnCount -- Key: ZOOKEEPER-614 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-614 Project: Zookeeper Issue Type: Bug Components: server Affects Versions: 3.2.1, 3.2.2 Reporter: Henry Robinson Assignee: Henry Robinson Fix For: 3.3.0 Attachments: ZOOKEEPER-614.patch getClientCnxnCount reads from Factory.ipMap without synchronizing. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [VOTE] Release ZooKeeper 3.2.2 (candidate 1)
+1 looks good to me - ran tests including testing on 3 node quorum (includes zkpython tests exercising the c client) Patrick On 12/08/2009 02:32 PM, Patrick Hunt wrote: I've created a second candidate build for ZooKeeper 3.2.2. This is a bug fix release addressing 13 issues (three critical) -- see the release notes for details. *** Please download, test and VOTE before the *** vote closes 3pm pacific time, Friday, December 11.*** http://people.apache.org/~phunt/zookeeper-3.2.2-candidate-1/ Should we release this? Patrick
Re: [VOTE] Release ZooKeeper 3.1.2 (candidate 1)
+1 looks good to me - ran tests including testing on 3 node quorum Patrick On 12/08/2009 02:30 PM, Patrick Hunt wrote: I've created a second candidate build for ZooKeeper 3.1.2. This is a bug fix release addressing three critical issues -- see the release notes for details. *** Please download, test and VOTE before the *** vote closes 3pm pacific time, Friday, December 11.*** http://people.apache.org/~phunt/zookeeper-3.1.2-candidate-1/ Should we release this? Patrick
[jira] Updated: (ZOOKEEPER-587) client should log timeout negotiated with server
[ https://issues.apache.org/jira/browse/ZOOKEEPER-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-587: Resolution: Fixed Status: Resolved (was: Patch Available) I just committed this. thanks pat. client should log timeout negotiated with server Key: ZOOKEEPER-587 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-587 Project: Zookeeper Issue Type: Bug Components: c client, java client Affects Versions: 3.2.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.3.0 Attachments: ZOOKEEPER-587.patch, ZOOKEEPER-587.patch The ZK client should log the timeout negotiated with the server if the time is different than the timeout parameter specified by the client. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-610) cleanup final fields, esp those used for locking
[ https://issues.apache.org/jira/browse/ZOOKEEPER-610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789578#action_12789578 ] Henry Robinson commented on ZOOKEEPER-610: -- +1 from me, tests don't need to be included as there are no functional changes (compiler would pick up any problems). We are a bit inconsistent about when we initialise inline in the class, and when we initialise in the constructor, but that's not for this patch to fix. Will (attempt to) commit shortly. cleanup final fields, esp those used for locking Key: ZOOKEEPER-610 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-610 Project: Zookeeper Issue Type: Bug Components: java client, server Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-610.patch There are a number of places where we have non-final fields that could (should) be declared as final. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-610) cleanup final fields, esp those used for locking
[ https://issues.apache.org/jira/browse/ZOOKEEPER-610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henry Robinson updated ZOOKEEPER-610: - Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) I just committed this (svn revision 889843). Thanks Patrick! cleanup final fields, esp those used for locking Key: ZOOKEEPER-610 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-610 Project: Zookeeper Issue Type: Bug Components: java client, server Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-610.patch There are a number of places where we have non-final fields that could (should) be declared as final. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-614) Improper synchronisation in getClientCnxnCount
[ https://issues.apache.org/jira/browse/ZOOKEEPER-614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-614: Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) I just committed this. thanks henry! Improper synchronisation in getClientCnxnCount -- Key: ZOOKEEPER-614 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-614 Project: Zookeeper Issue Type: Bug Components: server Affects Versions: 3.2.1, 3.2.2 Reporter: Henry Robinson Assignee: Henry Robinson Fix For: 3.3.0 Attachments: ZOOKEEPER-614.patch getClientCnxnCount reads from Factory.ipMap without synchronizing. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-534) The test target in contib/bookkeeper does not depend on jar target.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-534: Status: Open (was: Patch Available) trying hudson again. The test target in contib/bookkeeper does not depend on jar target. --- Key: ZOOKEEPER-534 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-534 Project: Zookeeper Issue Type: Bug Components: contrib-bookkeeper Affects Versions: 3.2.1, 3.2.0 Reporter: Mahadev konar Assignee: Patrick Hunt Fix For: 3.3.0 Attachments: ZOOKEEPER-534.patch The test target in contib/bookkeeper does not depend on jar target. So the ant test target gives compilation errors if the main is not compiled which can be prevented if it depends on jar. It can then check if main has been compiled or not and throw out a reasonable error. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-534) The test target in contib/bookkeeper does not depend on jar target.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-534: Status: Patch Available (was: Open) The test target in contib/bookkeeper does not depend on jar target. --- Key: ZOOKEEPER-534 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-534 Project: Zookeeper Issue Type: Bug Components: contrib-bookkeeper Affects Versions: 3.2.1, 3.2.0 Reporter: Mahadev konar Assignee: Patrick Hunt Fix For: 3.3.0 Attachments: ZOOKEEPER-534.patch The test target in contib/bookkeeper does not depend on jar target. So the ant test target gives compilation errors if the main is not compiled which can be prevented if it depends on jar. It can then check if main has been compiled or not and throw out a reasonable error. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-534) The test target in contib/bookkeeper does not depend on jar target.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789615#action_12789615 ] Mahadev konar commented on ZOOKEEPER-534: - +1 the patch looks good. ill commit as soon as hudson ok's it. The test target in contib/bookkeeper does not depend on jar target. --- Key: ZOOKEEPER-534 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-534 Project: Zookeeper Issue Type: Bug Components: contrib-bookkeeper Affects Versions: 3.2.0, 3.2.1 Reporter: Mahadev konar Assignee: Patrick Hunt Fix For: 3.3.0 Attachments: ZOOKEEPER-534.patch The test target in contib/bookkeeper does not depend on jar target. So the ant test target gives compilation errors if the main is not compiled which can be prevented if it depends on jar. It can then check if main has been compiled or not and throw out a reasonable error. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-534) The test target in contib/bookkeeper does not depend on jar target.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789616#action_12789616 ] Mahadev konar commented on ZOOKEEPER-534: - +1 the patch looks good. ill commit as soon as hudson ok's it. The test target in contib/bookkeeper does not depend on jar target. --- Key: ZOOKEEPER-534 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-534 Project: Zookeeper Issue Type: Bug Components: contrib-bookkeeper Affects Versions: 3.2.0, 3.2.1 Reporter: Mahadev konar Assignee: Patrick Hunt Fix For: 3.3.0 Attachments: ZOOKEEPER-534.patch The test target in contib/bookkeeper does not depend on jar target. So the ant test target gives compilation errors if the main is not compiled which can be prevented if it depends on jar. It can then check if main has been compiled or not and throw out a reasonable error. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [Fwd: [VOTE] Release ZooKeeper 3.1.2 (candidate 1)]
+1 Ran unit tests, md5 and signature match. -C On Tue, Dec 8, 2009 at 2:33 PM, Patrick Hunt ph...@apache.org wrote: Hadoop PMC, Please test and vote on this release in zookeeper-dev list. Thanks, Patrick I've created a second candidate build for ZooKeeper 3.1.2. This is a bug fix release addressing three critical issues -- see the release notes for details. *** Please download, test and VOTE before the *** vote closes 3pm pacific time, Friday, December 11.*** http://people.apache.org/~phunt/zookeeper-3.1.2-candidate-1/ Should we release this? Patrick
[jira] Commented: (ZOOKEEPER-534) The test target in contib/bookkeeper does not depend on jar target.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12789664#action_12789664 ] Hadoop QA commented on ZOOKEEPER-534: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12426643/ZOOKEEPER-534.patch against trunk revision 889848. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/25/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/25/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/25/console This message is automatically generated. The test target in contib/bookkeeper does not depend on jar target. --- Key: ZOOKEEPER-534 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-534 Project: Zookeeper Issue Type: Bug Components: contrib-bookkeeper Affects Versions: 3.2.0, 3.2.1 Reporter: Mahadev konar Assignee: Patrick Hunt Fix For: 3.3.0 Attachments: ZOOKEEPER-534.patch The test target in contib/bookkeeper does not depend on jar target. So the ant test target gives compilation errors if the main is not compiled which can be prevented if it depends on jar. It can then check if main has been compiled or not and throw out a reasonable error. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
