[jira] Created: (ZOOKEEPER-182) zookeeper_init accepts empty host-port string and returns valid pointer to zhandle_t.
zookeeper_init accepts empty host-port string and returns valid pointer to
zhandle_t.
-
Key: ZOOKEEPER-182
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-182
Project: Zookeeper
Issue Type: Bug
Components: c client
Environment: Linux
Reporter: Maxim P. Dementiev
Please, add this test to src/c/tests/TestZookeeperInit.cc to reproduce this:
void testEmptyAddressString()
{
zh=zookeeper_init(,0,0,0,0,0);
CPPUNIT_ASSERT(zh==0);
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-183) Array subscript is above array bounds in od_completion(), src/cli.c.
Array subscript is above array bounds in od_completion(), src/cli.c. Key: ZOOKEEPER-183 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-183 Project: Zookeeper Issue Type: Bug Components: c client Environment: Linux Reporter: Maxim P. Dementiev Having: char buf[4096*16]; Present: buf[sizeof(buf)]=0; Must be: buf[sizeof(buf)-1]=0; -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-183) Array subscript is above array bounds in od_completion(), src/cli.c.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12638826#action_12638826 ] Maxim P. Dementiev commented on ZOOKEEPER-183: -- Thanks for your comment. I will. Array subscript is above array bounds in od_completion(), src/cli.c. Key: ZOOKEEPER-183 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-183 Project: Zookeeper Issue Type: Bug Components: c client Environment: Linux Reporter: Maxim P. Dementiev Having: char buf[4096*16]; Present: buf[sizeof(buf)]=0; Must be: buf[sizeof(buf)-1]=0; -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-182) zookeeper_init accepts empty host-port string and returns valid pointer to zhandle_t.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim P. Dementiev updated ZOOKEEPER-182:
-
Attachment: ZOOKEEPER-182-UnitTests-Init-AddressString.patch
Contains new tests for zookeeper_init() function:
testNullAddressString, estEmptyAddressString, testOneSpaceAddressString,
testTwoSpacesAddressString
zookeeper_init accepts empty host-port string and returns valid pointer to
zhandle_t.
-
Key: ZOOKEEPER-182
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-182
Project: Zookeeper
Issue Type: Bug
Components: c client
Environment: Linux
Reporter: Maxim P. Dementiev
Attachments: ZOOKEEPER-182-UnitTests-Init-AddressString.patch
Please, add this test to src/c/tests/TestZookeeperInit.cc to reproduce this:
void testEmptyAddressString()
{
zh=zookeeper_init(,0,0,0,0,0);
CPPUNIT_ASSERT(zh==0);
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-184) tests: An explicit include derective is needed for the usage of memcpy(), memset(), strlen(), strdup() and free() functions.
tests: An explicit include derective is needed for the usage of memcpy(), memset(), strlen(), strdup() and free() functions. Key: ZOOKEEPER-184 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-184 Project: Zookeeper Issue Type: Bug Components: c client Environment: Linux Reporter: Maxim P. Dementiev Some compilation environments provide implicit inclusion of certain system headers. But any way it's not a reason to exploit it in platform-independent projects. TestHashtable.cc and LibCMocks.h from src/c/tests/ use those functions without including corresponding system headers. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-182) zookeeper_init accepts empty host-port string and returns valid pointer to zhandle_t.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim P. Dementiev updated ZOOKEEPER-182:
-
Attachment: ZOOKEEPER-182.patch
Attachment ZOOKEEPER-182.patch: if we check the input string for , we may
check for NULL first - there is no any drawback.
I think it's good idea to check for NULL and exit with an appropriate error
than do a coredump.
But in any case we have to check the input string before pass it to strdup().
zookeeper_init accepts empty host-port string and returns valid pointer to
zhandle_t.
-
Key: ZOOKEEPER-182
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-182
Project: Zookeeper
Issue Type: Bug
Components: c client
Environment: Linux
Reporter: Maxim P. Dementiev
Attachments: ZOOKEEPER-182-UnitTests-Init-AddressString.patch,
ZOOKEEPER-182.patch
Please, add this test to src/c/tests/TestZookeeperInit.cc to reproduce this:
void testEmptyAddressString()
{
zh=zookeeper_init(,0,0,0,0,0);
CPPUNIT_ASSERT(zh==0);
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-184) tests: An explicit include derective is needed for the usage of memcpy(), memset(), strlen(), strdup() and free() functions.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim P. Dementiev updated ZOOKEEPER-184: - Attachment: ZOOKEEPER-184.patch The patch is obvious: include corresponding system header. tests: An explicit include derective is needed for the usage of memcpy(), memset(), strlen(), strdup() and free() functions. Key: ZOOKEEPER-184 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-184 Project: Zookeeper Issue Type: Bug Components: c client Environment: Linux Reporter: Maxim P. Dementiev Attachments: ZOOKEEPER-184.patch Some compilation environments provide implicit inclusion of certain system headers. But any way it's not a reason to exploit it in platform-independent projects. TestHashtable.cc and LibCMocks.h from src/c/tests/ use those functions without including corresponding system headers. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (ZOOKEEPER-182) zookeeper_init accepts empty host-port string and returns valid pointer to zhandle_t.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12639023#action_12639023
]
dememax edited comment on ZOOKEEPER-182 at 10/13/08 4:14 AM:
Attachment ZOOKEEPER-182-UnitTests-Init-AddressString.patch contains new tests
for zookeeper_init() function:
testNullAddressString, estEmptyAddressString, testOneSpaceAddressString,
testTwoSpacesAddressString
was (Author: dememax):
Contains new tests for zookeeper_init() function:
testNullAddressString, estEmptyAddressString, testOneSpaceAddressString,
testTwoSpacesAddressString
zookeeper_init accepts empty host-port string and returns valid pointer to
zhandle_t.
-
Key: ZOOKEEPER-182
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-182
Project: Zookeeper
Issue Type: Bug
Components: c client
Environment: Linux
Reporter: Maxim P. Dementiev
Attachments: ZOOKEEPER-182-UnitTests-Init-AddressString.patch
Please, add this test to src/c/tests/TestZookeeperInit.cc to reproduce this:
void testEmptyAddressString()
{
zh=zookeeper_init(,0,0,0,0,0);
CPPUNIT_ASSERT(zh==0);
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-183) Array subscript is above array bounds in od_completion(), src/cli.c.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim P. Dementiev updated ZOOKEEPER-183: - Comment: was deleted Array subscript is above array bounds in od_completion(), src/cli.c. Key: ZOOKEEPER-183 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-183 Project: Zookeeper Issue Type: Bug Components: c client Environment: Linux Reporter: Maxim P. Dementiev Having: char buf[4096*16]; Present: buf[sizeof(buf)]=0; Must be: buf[sizeof(buf)-1]=0; -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-196) doxygen comment for state argument of watcher_fn typedef and implementation differ (...one of the *_STATE constants, otherwise -1)
doxygen comment for state argument of watcher_fn typedef and implementation differ (...one of the *_STATE constants, otherwise -1) Key: ZOOKEEPER-196 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-196 Project: Zookeeper Issue Type: Bug Environment: Linux Reporter: Maxim P. Dementiev In zookeeper.h: * \param state connection state. If the type is ZOO_SESSION_EVENT, the state value * will be one of the *_STATE constants, otherwise -1. but for this sequence: 1. zoo_awexists(name) 2. zoo_acreate(name) we've got a watcher callback with type=ZOO_CREATED_EVENT and state!=-1 I think the comment should be altered to underline the difference between zookeeper_init() callback usage and others (the getter API functions with the w prefix in their names) for the new watcher object style. It looks like the type and path argument values are useless for the former (because type is always ZOO_SESSION_EVENT, and path is always empty), and the state is useless for the latter (it is considered to be -1). And more, the state of the legacy style should be commented - will it be marked as obsolete? Or will it be supported in the future? I wonder if there are any plans to split current watcher_fn callback to something like: 1. new watcher_fn: typedef void (*watcher_fn)(zhandle_t *zh, int type, const char *path, void *watcherCtx); 2. connection_fn: typedef void (*watcher_fn)(zhandle_t *zh, int state, void *context); Because, you see, the usage is different and there is no any common set of arguments apart from zh (which is common for API) and context. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-149) c interface is missing tests against java server (mock only)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim P. Dementiev reassigned ZOOKEEPER-149: Assignee: Patrick Hunt This jira item should be altered. Try to do grep localhost:2121 trunk/src/c/tests, there are 31 matches of the usage to call zookeeper_init(). The other problem, you see, is the usage of concrete port on the localhost by a ZooKeeper server instance to run these tests without documenting it. c interface is missing tests against java server (mock only) Key: ZOOKEEPER-149 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-149 Project: Zookeeper Issue Type: Improvement Components: c client Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.1.0 The c client interface has unit tests but they are against mock server implementations only. We need to add tests for the c interface against live java server. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-196) doxygen comment for state argument of watcher_fn typedef and implementation differ (...one of the *_STATE constants, otherwise -1)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim P. Dementiev updated ZOOKEEPER-196: - Component/s: c client doxygen comment for state argument of watcher_fn typedef and implementation differ (...one of the *_STATE constants, otherwise -1) Key: ZOOKEEPER-196 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-196 Project: Zookeeper Issue Type: Bug Components: c client Environment: Linux Reporter: Maxim P. Dementiev In zookeeper.h: * \param state connection state. If the type is ZOO_SESSION_EVENT, the state value * will be one of the *_STATE constants, otherwise -1. but for this sequence: 1. zoo_awexists(name) 2. zoo_acreate(name) we've got a watcher callback with type=ZOO_CREATED_EVENT and state!=-1 I think the comment should be altered to underline the difference between zookeeper_init() callback usage and others (the getter API functions with the w prefix in their names) for the new watcher object style. It looks like the type and path argument values are useless for the former (because type is always ZOO_SESSION_EVENT, and path is always empty), and the state is useless for the latter (it is considered to be -1). And more, the state of the legacy style should be commented - will it be marked as obsolete? Or will it be supported in the future? I wonder if there are any plans to split current watcher_fn callback to something like: 1. new watcher_fn: typedef void (*watcher_fn)(zhandle_t *zh, int type, const char *path, void *watcherCtx); 2. connection_fn: typedef void (*watcher_fn)(zhandle_t *zh, int state, void *context); Because, you see, the usage is different and there is no any common set of arguments apart from zh (which is common for API) and context. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Deleted: (ZOOKEEPER-280) Re-distributable bundle zookeeper-3.0.1.tar.gz lacks some important files for c-lib build .
[ https://issues.apache.org/jira/browse/ZOOKEEPER-280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim P. Dementiev deleted ZOOKEEPER-280: - Re-distributable bundle zookeeper-3.0.1.tar.gz lacks some important files for c-lib build . --- Key: ZOOKEEPER-280 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-280 Project: Zookeeper Issue Type: Bug Environment: Linux Reporter: Maxim P. Dementiev There is no configure (try: find zookeeper-3.0.1 -name configure) which is needed for build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-281) autoreconf fails for /zookeeper-3.0.1/src/c/
[ https://issues.apache.org/jira/browse/ZOOKEEPER-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim P. Dementiev updated ZOOKEEPER-281: - Attachment: autoreconf.log Result of autoreconf -i -f -v -v -v autoreconf.log 21. autoreconf fails for /zookeeper-3.0.1/src/c/ Key: ZOOKEEPER-281 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-281 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.0.1 Environment: Linux dememax-laptop 2.6.27-gentoo-r8 #2 SMP Fri Jan 23 13:42:35 MSK 2009 i686 Intel(R) Core(TM)2 CPU T5600 @ 1.83GHz GenuineIntel GNU/Linux autoconf (GNU Autoconf) 2.63 automake (GNU automake) 1.10.2 m4 (GNU M4) 1.4.11 aclocal (GNU automake) 1.10.2 ltmain.sh (GNU libtool) 1.5.26 (1.1220.2.493 2008/02/01 16:58:18) basename (GNU coreutils) 6.10 gettext (GNU gettext-runtime) 0.17 GNU ld (GNU Binutils) 2.18 Reporter: Maxim P. Dementiev Attachments: autoreconf.log autoreconf -i -f -v autoreconf-2.63: Entering directory `.' autoreconf-2.63: configure.ac: not using Gettext autoreconf-2.63: running: aclocal --force configure.ac:21: error: AC_SUBST: `DX_FLAG_[]DX_CURRENT_FEATURE' is not a valid shell variable name acinclude.m4:77: DX_REQUIRE_PROG is expanded from... acinclude.m4:117: DX_ARG_ABLE is expanded from... acinclude.m4:178: DX_INIT_DOXYGEN is expanded from... configure.ac:21: the top level autom4te-2.63: /usr/bin/m4 failed with exit status: 1 aclocal-1.10: autom4te failed with exit status: 1 autoreconf-2.63: aclocal failed with exit status: 1 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-281) autoreconf fails for /zookeeper-3.0.1/src/c/
[ https://issues.apache.org/jira/browse/ZOOKEEPER-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim P. Dementiev reassigned ZOOKEEPER-281: Assignee: Patrick Hunt Sorry for delay. Oh, the formatting is ugly but the result is the same. I'm not a prof in m4 and auto* stuff. Can you propose something else? Do you need an access to the system like mine is? autoreconf fails for /zookeeper-3.0.1/src/c/ Key: ZOOKEEPER-281 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-281 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.0.1 Environment: Linux dememax-laptop 2.6.27-gentoo-r8 #2 SMP Fri Jan 23 13:42:35 MSK 2009 i686 Intel(R) Core(TM)2 CPU T5600 @ 1.83GHz GenuineIntel GNU/Linux autoconf (GNU Autoconf) 2.63 automake (GNU automake) 1.10.2 m4 (GNU M4) 1.4.11 aclocal (GNU automake) 1.10.2 ltmain.sh (GNU libtool) 1.5.26 (1.1220.2.493 2008/02/01 16:58:18) basename (GNU coreutils) 6.10 gettext (GNU gettext-runtime) 0.17 GNU ld (GNU Binutils) 2.18 Reporter: Maxim P. Dementiev Assignee: Patrick Hunt Attachments: autoreconf.log autoreconf -i -f -v autoreconf-2.63: Entering directory `.' autoreconf-2.63: configure.ac: not using Gettext autoreconf-2.63: running: aclocal --force configure.ac:21: error: AC_SUBST: `DX_FLAG_[]DX_CURRENT_FEATURE' is not a valid shell variable name acinclude.m4:77: DX_REQUIRE_PROG is expanded from... acinclude.m4:117: DX_ARG_ABLE is expanded from... acinclude.m4:178: DX_INIT_DOXYGEN is expanded from... configure.ac:21: the top level autom4te-2.63: /usr/bin/m4 failed with exit status: 1 aclocal-1.10: autom4te failed with exit status: 1 autoreconf-2.63: aclocal failed with exit status: 1 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (ZOOKEEPER-281) autoreconf fails for /zookeeper-3.0.1/src/c/
[ https://issues.apache.org/jira/browse/ZOOKEEPER-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12669950#action_12669950 ] dememax edited comment on ZOOKEEPER-281 at 2/3/09 8:21 AM: -- Sorry for delay. Oh, the formatting is ugly but the result is the same. Unfortunately, I'm not a prof in m4 and auto* stuff. Can you propose something else? Do you need an access to the system like mine is? For example, I've got cppunit package, it use the same build system. It might help: http://cppunit.cvs.sourceforge.net/viewvc/cppunit/cppunit/configure.in?view=markuppathrev=HEAD http://cppunit.cvs.sourceforge.net/viewvc/cppunit/cppunit/config/bb_enable_doxygen.m4?view=markuppathrev=HEAD was (Author: dememax): Sorry for delay. Oh, the formatting is ugly but the result is the same. I'm not a prof in m4 and auto* stuff. Can you propose something else? Do you need an access to the system like mine is? autoreconf fails for /zookeeper-3.0.1/src/c/ Key: ZOOKEEPER-281 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-281 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.0.1 Environment: Linux dememax-laptop 2.6.27-gentoo-r8 #2 SMP Fri Jan 23 13:42:35 MSK 2009 i686 Intel(R) Core(TM)2 CPU T5600 @ 1.83GHz GenuineIntel GNU/Linux autoconf (GNU Autoconf) 2.63 automake (GNU automake) 1.10.2 m4 (GNU M4) 1.4.11 aclocal (GNU automake) 1.10.2 ltmain.sh (GNU libtool) 1.5.26 (1.1220.2.493 2008/02/01 16:58:18) basename (GNU coreutils) 6.10 gettext (GNU gettext-runtime) 0.17 GNU ld (GNU Binutils) 2.18 Reporter: Maxim P. Dementiev Assignee: Patrick Hunt Attachments: autoreconf.log autoreconf -i -f -v autoreconf-2.63: Entering directory `.' autoreconf-2.63: configure.ac: not using Gettext autoreconf-2.63: running: aclocal --force configure.ac:21: error: AC_SUBST: `DX_FLAG_[]DX_CURRENT_FEATURE' is not a valid shell variable name acinclude.m4:77: DX_REQUIRE_PROG is expanded from... acinclude.m4:117: DX_ARG_ABLE is expanded from... acinclude.m4:178: DX_INIT_DOXYGEN is expanded from... configure.ac:21: the top level autom4te-2.63: /usr/bin/m4 failed with exit status: 1 aclocal-1.10: autom4te failed with exit status: 1 autoreconf-2.63: aclocal failed with exit status: 1 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-281) autoreconf fails for /zookeeper-3.0.1/src/c/
[ https://issues.apache.org/jira/browse/ZOOKEEPER-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12669943#action_12669943 ] Maxim P. Dementiev commented on ZOOKEEPER-281: -- deme...@dememax-laptop ~/sources/ZooKeeper/zookeeper-3.0.1/src/c $ diff -c __acinclude.m4__ acinclude.m4 *** __acinclude.m4__2009-02-03 16:06:00.0 +0300 --- acinclude.m42009-02-03 16:06:48.0 +0300 *** *** 76,82 # Require the specified program to be found for the DX_CURRENT_FEATURE to work. AC_DEFUN([DX_REQUIRE_PROG], [ AC_PATH_TOOL([$1], [$2]) ! if test $DX_FLAG_[]DX_CURRENT_FEATURE$$1 = 1; then AC_MSG_WARN([$2 not found - will not DX_CURRENT_DESCRIPTION]) AC_SUBST([DX_FLAG_[]DX_CURRENT_FEATURE], 0) fi --- 76,82 # Require the specified program to be found for the DX_CURRENT_FEATURE to work. AC_DEFUN([DX_REQUIRE_PROG], [ AC_PATH_TOOL([$1], [$2]) ! if test $DX_FLAG_$[DX_CURRENT_FEATURE$$1] = 1; then AC_MSG_WARN([$2 not found - will not DX_CURRENT_DESCRIPTION]) AC_SUBST([DX_FLAG_[]DX_CURRENT_FEATURE], 0) fi deme...@dememax-laptop ~/sources/ZooKeeper/zookeeper-3.0.1/src/c $ autoreconf -i -f -v autoreconf-2.63: Entering directory `.' autoreconf-2.63: configure.ac: not using Gettext autoreconf-2.63: running: aclocal --force configure.ac:21: error: AC_SUBST: `DX_FLAG_[]DX_CURRENT_FEATURE' is not a valid shell variable name acinclude.m4:77: DX_REQUIRE_PROG is expanded from... acinclude.m4:117: DX_ARG_ABLE is expanded from... acinclude.m4:178: DX_INIT_DOXYGEN is expanded from... configure.ac:21: the top level autom4te-2.63: /usr/bin/m4 failed with exit status: 1 aclocal-1.10: autom4te failed with exit status: 1 autoreconf-2.63: aclocal failed with exit status: 1 deme...@dememax-laptop ~/sources/ZooKeeper/zookeeper-3.0.1/src/c $ autoreconf fails for /zookeeper-3.0.1/src/c/ Key: ZOOKEEPER-281 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-281 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.0.1 Environment: Linux dememax-laptop 2.6.27-gentoo-r8 #2 SMP Fri Jan 23 13:42:35 MSK 2009 i686 Intel(R) Core(TM)2 CPU T5600 @ 1.83GHz GenuineIntel GNU/Linux autoconf (GNU Autoconf) 2.63 automake (GNU automake) 1.10.2 m4 (GNU M4) 1.4.11 aclocal (GNU automake) 1.10.2 ltmain.sh (GNU libtool) 1.5.26 (1.1220.2.493 2008/02/01 16:58:18) basename (GNU coreutils) 6.10 gettext (GNU gettext-runtime) 0.17 GNU ld (GNU Binutils) 2.18 Reporter: Maxim P. Dementiev Attachments: autoreconf.log autoreconf -i -f -v autoreconf-2.63: Entering directory `.' autoreconf-2.63: configure.ac: not using Gettext autoreconf-2.63: running: aclocal --force configure.ac:21: error: AC_SUBST: `DX_FLAG_[]DX_CURRENT_FEATURE' is not a valid shell variable name acinclude.m4:77: DX_REQUIRE_PROG is expanded from... acinclude.m4:117: DX_ARG_ABLE is expanded from... acinclude.m4:178: DX_INIT_DOXYGEN is expanded from... configure.ac:21: the top level autom4te-2.63: /usr/bin/m4 failed with exit status: 1 aclocal-1.10: autom4te failed with exit status: 1 autoreconf-2.63: aclocal failed with exit status: 1 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-281) autoreconf fails for /zookeeper-3.0.1/src/c/
[ https://issues.apache.org/jira/browse/ZOOKEEPER-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim P. Dementiev updated ZOOKEEPER-281: - Fix Version/s: 3.0.1 Release Note: Introduces compatibility with new GNU Autoconf version 2.63. Status: Patch Available (was: Open) autoreconf fails for /zookeeper-3.0.1/src/c/ Key: ZOOKEEPER-281 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-281 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.0.1 Environment: Linux dememax-laptop 2.6.27-gentoo-r8 #2 SMP Fri Jan 23 13:42:35 MSK 2009 i686 Intel(R) Core(TM)2 CPU T5600 @ 1.83GHz GenuineIntel GNU/Linux autoconf (GNU Autoconf) 2.63 automake (GNU automake) 1.10.2 m4 (GNU M4) 1.4.11 aclocal (GNU automake) 1.10.2 ltmain.sh (GNU libtool) 1.5.26 (1.1220.2.493 2008/02/01 16:58:18) basename (GNU coreutils) 6.10 gettext (GNU gettext-runtime) 0.17 GNU ld (GNU Binutils) 2.18 Reporter: Maxim P. Dementiev Assignee: Patrick Hunt Fix For: 3.0.1 Attachments: autoreconf.log, configure-autoreconf-2.63.gz, configure.gz, ZOOKEEPER-281.patch autoreconf -i -f -v autoreconf-2.63: Entering directory `.' autoreconf-2.63: configure.ac: not using Gettext autoreconf-2.63: running: aclocal --force configure.ac:21: error: AC_SUBST: `DX_FLAG_[]DX_CURRENT_FEATURE' is not a valid shell variable name acinclude.m4:77: DX_REQUIRE_PROG is expanded from... acinclude.m4:117: DX_ARG_ABLE is expanded from... acinclude.m4:178: DX_INIT_DOXYGEN is expanded from... configure.ac:21: the top level autom4te-2.63: /usr/bin/m4 failed with exit status: 1 aclocal-1.10: autom4te failed with exit status: 1 autoreconf-2.63: aclocal failed with exit status: 1 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-292) commit configure scripts (autotools) to svn for c projects and include in release
[ https://issues.apache.org/jira/browse/ZOOKEEPER-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12670712#action_12670712 ] Maxim P. Dementiev commented on ZOOKEEPER-292: -- Patrick, sorry for my perseverance but... What about CFLAGS and CXXFLAGS? Build system doesn't take them into account. Should I create an issue (jira item) for this? commit configure scripts (autotools) to svn for c projects and include in release - Key: ZOOKEEPER-292 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-292 Project: Zookeeper Issue Type: Improvement Components: c client, contrib-zkfuse Reporter: Patrick Hunt Fix For: 3.2.0 We currently don't include configure scripts, just the .ac file itself. This means that users are required to run autoreconf; ./configure rather than just configure. We should commit the configure script(s) to svn (hadoop core does this btw) for our autotools based projects (currently c client api and zkfuse). Also these should be included in the build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-295) prevent multiple namespace pollution by C API
[ https://issues.apache.org/jira/browse/ZOOKEEPER-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12795046#action_12795046 ] Maxim P. Dementiev commented on ZOOKEEPER-295: -- Completely agree. Let's take zerror function name. It was used by many zip/unzip C implementations and linking the whole project (which uses both zk and zip) causes errors. prevent multiple namespace pollution by C API - Key: ZOOKEEPER-295 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-295 Project: Zookeeper Issue Type: Improvement Components: c client Affects Versions: 3.0.0, 3.0.1, 3.1.0 Reporter: Chris Darroch Fix For: 4.0.0 The ZOOKEEPER-6 issue touched on the problem of namespace pollution by the ZooKeeper C API; this report was closed but I don't think the problem has actually been substantially resolved. There are multiple namespaces to consider. First, the names of the C include files should ideally have a common prefix, e.g., zoo_recordio.h, or else be concatenated into a single zookeeper.h file. The zookeeper.jute.h include file has a reasonably good name in this regard. Second, all macros should ideally have a common prefix, e.g., ZOO_ or ZK_ or ZOOKEEPER_. Currently many exported constants (not macros) have the ZOO_ prefix, such as ZOO_PERM_READ, but error codes have a Z prefix, e.g., ZOK, ZNOTEMPTY. Third, all functions should ideally have a common prefix, e.g., zoo_ or zk_ or zookeeper_. Many do already, but there is some variation, such as zookeeper_init(), zookeeper_process(), and there are also a large number of functions which have no prefix. These include many of the functions defined in recordio.h and zookeeper.jute.h, such as get_buffer() and serialize_Id(). Many others are simply used internally within the ZooKeeper C library and not declared in an external include file, but still pollute the caller's namespace, e.g., get_xid(), process_completions(), adaptor_init(), etc. All external symbols in the libraries should have a common prefix. Fourth, all structure and type definitions should also have a common prefix, again, zoo_ or zk_ or zookeeper_. This is especially true of structures which currently have very generic names such as Id, Stat, and ACL from zookeeper.jute.h; buffer, iarchive, and oarchive from recordio.h; and clientid_t and watcher_fn from zookeeper.h. The zhandle_t structure should also be renamed to have the same prefix, e.g., zoo_handle_t. The ZOOKEEPER-6 report includes the comment that the names in zookeeper.jute.h will be difficult to change because they affect the Java code and that there should be limited exposure since jute naming starts with caps. It would be nice to think so, but I fear that a structure named Id or Stat is going to be pretty darn commonplace in other people's code. I would strongly recommend revising the entire set file, function, macro, type and structure names for 4.0.0. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-636) configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS.
configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS. - Key: ZOOKEEPER-636 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-636 Project: Zookeeper Issue Type: Improvement Components: c client Reporter: Maxim P. Dementiev The information mustn't be overridden. The template like «CFLAGS=$CFLAGS -some-option» should be used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-636) configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805239#action_12805239 ] Maxim P. Dementiev commented on ZOOKEEPER-636: -- I don't think I'm an autotools expert, but many things have changed since ZOOKEEPER-281. I even posted an article about Autoconf and CppUnit integration in my blog: http://mpd-eng.livejournal.com/700.html I'll do my best to fix this one issue (CFLAGS overriding). And please, fill free to assign to me any autoconf issue (is there corresponding opened issue with cppunit that you've talked about?). configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS. - Key: ZOOKEEPER-636 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-636 Project: Zookeeper Issue Type: Improvement Components: c client Affects Versions: 3.2.1 Reporter: Maxim P. Dementiev Fix For: 3.3.0 The information mustn't be overridden. The template like «CFLAGS=$CFLAGS -some-option» should be used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-636) configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim P. Dementiev reassigned ZOOKEEPER-636: Assignee: Maxim P. Dementiev configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS. - Key: ZOOKEEPER-636 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-636 Project: Zookeeper Issue Type: Improvement Components: c client Affects Versions: 3.2.1 Reporter: Maxim P. Dementiev Assignee: Maxim P. Dementiev Fix For: 3.3.0 The information mustn't be overridden. The template like «CFLAGS=$CFLAGS -some-option» should be used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Work started: (ZOOKEEPER-636) configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on ZOOKEEPER-636 started by Maxim P. Dementiev. configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS. - Key: ZOOKEEPER-636 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-636 Project: Zookeeper Issue Type: Improvement Components: c client Affects Versions: 3.2.1 Reporter: Maxim P. Dementiev Assignee: Maxim P. Dementiev Fix For: 3.3.0 The information mustn't be overridden. The template like «CFLAGS=$CFLAGS -some-option» should be used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-636) configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim P. Dementiev updated ZOOKEEPER-636: - Attachment: ZOOKEEPER-636.patch This patch modifies src/c/configure.ac and src/c/Makefile.am files in order to not override user values of CFLAGS and CXXFLAGS environment variables like it is expected and defined by design. Some C and C++ options are still in Makefile.am. configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS. - Key: ZOOKEEPER-636 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-636 Project: Zookeeper Issue Type: Improvement Components: build, c client Affects Versions: 3.2.1 Reporter: Maxim P. Dementiev Assignee: Maxim P. Dementiev Fix For: 3.4.0 Attachments: ZOOKEEPER-636.patch The information mustn't be overridden. The template like «CFLAGS=$CFLAGS -some-option» should be used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-636) configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12868297#action_12868297 ] Maxim P. Dementiev commented on ZOOKEEPER-636: -- Sorry for delay. Our project is in trouble (http://mpd-eng.livejournal.com/1159.html). I've changed src/c/Makefile.am: CXXFLAGS should not be overridden. Anyway, I kept some additional options there (AM_CFLAGS = -Wall -Werror and AM_CXXFLAGS = -Wall). I think it must be moved in configure.ac as well. It is possible to parse the contents of CFLAGS and CXXFLAGS variable and to add specific options conditionally (like it is done for example in http://git.gnome.org/browse/gtk+/tree/configure.in?h=gtk-2-18#n320), but we need to define requirements for the platform and tool versions (can we use such a technique or not). configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS. - Key: ZOOKEEPER-636 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-636 Project: Zookeeper Issue Type: Improvement Components: build, c client Affects Versions: 3.2.1 Reporter: Maxim P. Dementiev Assignee: Maxim P. Dementiev Fix For: 3.4.0 Attachments: ZOOKEEPER-636.patch The information mustn't be overridden. The template like «CFLAGS=$CFLAGS -some-option» should be used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-636) configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim P. Dementiev updated ZOOKEEPER-636: - Status: Patch Available (was: In Progress) configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS. - Key: ZOOKEEPER-636 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-636 Project: Zookeeper Issue Type: Improvement Components: build, c client Affects Versions: 3.2.1 Reporter: Maxim P. Dementiev Assignee: Maxim P. Dementiev Fix For: 3.4.0 Attachments: ZOOKEEPER-636.patch The information mustn't be overridden. The template like «CFLAGS=$CFLAGS -some-option» should be used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-636) configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim P. Dementiev reassigned ZOOKEEPER-636: Assignee: Patrick Hunt (was: Maxim P. Dementiev) configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS. - Key: ZOOKEEPER-636 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-636 Project: Zookeeper Issue Type: Improvement Components: build, c client Affects Versions: 3.2.1 Reporter: Maxim P. Dementiev Assignee: Patrick Hunt Fix For: 3.4.0 Attachments: ZOOKEEPER-636.patch The information mustn't be overridden. The template like «CFLAGS=$CFLAGS -some-option» should be used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-636) configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12868382#action_12868382 ] Maxim P. Dementiev commented on ZOOKEEPER-636: -- And I wonder what does this -1 core tests. The patch failed core unit tests. mean for me? Should I correct something? configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS. - Key: ZOOKEEPER-636 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-636 Project: Zookeeper Issue Type: Improvement Components: build, c client Affects Versions: 3.2.1 Reporter: Maxim P. Dementiev Assignee: Patrick Hunt Fix For: 3.4.0 Attachments: ZOOKEEPER-636.patch The information mustn't be overridden. The template like «CFLAGS=$CFLAGS -some-option» should be used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-636) configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim P. Dementiev updated ZOOKEEPER-636: - Status: Open (was: Patch Available) configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS. - Key: ZOOKEEPER-636 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-636 Project: Zookeeper Issue Type: Improvement Components: build, c client Affects Versions: 3.2.1 Reporter: Maxim P. Dementiev Assignee: Patrick Hunt Fix For: 3.4.0 Attachments: ZOOKEEPER-636.patch The information mustn't be overridden. The template like «CFLAGS=$CFLAGS -some-option» should be used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-636) configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim P. Dementiev updated ZOOKEEPER-636: - Status: Patch Available (was: Open) Resubmitting after the fail which isn't related to the patch. configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS. - Key: ZOOKEEPER-636 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-636 Project: Zookeeper Issue Type: Improvement Components: build, c client Affects Versions: 3.2.1 Reporter: Maxim P. Dementiev Assignee: Patrick Hunt Fix For: 3.4.0 Attachments: ZOOKEEPER-636.patch The information mustn't be overridden. The template like «CFLAGS=$CFLAGS -some-option» should be used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-636) configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12869057#action_12869057 ] Maxim P. Dementiev commented on ZOOKEEPER-636: -- Thank you, Patrick! I do hope our team (http://mpd-eng.livejournal.com/1159.html) will find an opportunity to continue work on the project and I will do more for ZooKeeper! configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS. - Key: ZOOKEEPER-636 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-636 Project: Zookeeper Issue Type: Improvement Components: build, c client Affects Versions: 3.2.1 Reporter: Maxim P. Dementiev Assignee: Maxim P. Dementiev Fix For: 3.4.0 Attachments: ZOOKEEPER-636.patch The information mustn't be overridden. The template like «CFLAGS=$CFLAGS -some-option» should be used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
