[jira] Commented: (ZOOKEEPER-99) All MXBeans interfaces that don't use complex paramters need to be renamed as MBean interaces.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-99?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781376#action_12781376 ] Hiram Chirino commented on ZOOKEEPER-99: Hi Patrick, if it runs fine on java 1.5, then it should run fine in JBoss. > All MXBeans interfaces that don't use complex paramters need to be renamed as > MBean interaces. > --- > > Key: ZOOKEEPER-99 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-99 > Project: Zookeeper > Issue Type: Bug > Components: jmx >Reporter: Hiram Chirino > Attachments: ZOOKEEPER-99.patch > > > All the MXBean interfaces that I've looked at are standard MBean interfaces. > The interface names should get renamed to MBean instaead of MXBean. That way > the server can also run on a the Java 1.5 Platform. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-532) java compiler should be target Java 1.5
[ https://issues.apache.org/jira/browse/ZOOKEEPER-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767941#action_12767941 ] Hiram Chirino commented on ZOOKEEPER-532: - Naturally all the features are not going to work on 1.5, for example JMX. So tests will fail. I'm not sure why you expected otherwise. But the fact remains the the core server and client work just fine on 1.5. I've been running them on 1.5 for a long time now. If you want folks to rebuild your jars, you basically saying you want forks of the project floating around out there. If that's the official position that's cool, but it just adds more work onto your downstream users since they now need to re-compile and redistribute. > java compiler should be target Java 1.5 > --- > > Key: ZOOKEEPER-532 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-532 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.2.1 >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-532.patch > > > The jars released in 3.2.1 will not run on Java 1.5. With a small build > change, it is possible to generate jars that will run on Java 1.5. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-224) Deploy ZooKeeper jars/artifacts to a Maven Repository
[ https://issues.apache.org/jira/browse/ZOOKEEPER-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767937#action_12767937 ] Hiram Chirino commented on ZOOKEEPER-224: - If you need to GPG sign the artifacts the by hand you can script it with something like this: echo "$PASSWORD" | gpg --default-key "$DEFAULT_KEY" --detach-sign --armor --no-tty --yes --passphrase-fd 0 "$FILE" > Deploy ZooKeeper jars/artifacts to a Maven Repository > - > > Key: ZOOKEEPER-224 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-224 > Project: Zookeeper > Issue Type: Task > Components: build >Affects Versions: 3.0.0 >Reporter: Hiram Chirino >Assignee: Benjamin Reed >Priority: Critical > Fix For: 3.3.0 > > > I've created the maven poms needed for the 3.0.0 release. > The directory structure and artifacts located at: > http://people.apache.org/~chirino/zk-repo/ > aka > people.apache.org:/x1/users/chirino/public_html/zk-repo > Just need sto get GPG signed by the project KEY and deployed to: > people.apache.org:/www/people.apache.org/repo/m2-ibiblio-rsync-repository > Who's the current ZooKeeper release manager? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-537) The zookeeper jar includes the java source files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767931#action_12767931 ] Hiram Chirino commented on ZOOKEEPER-537: - I think the reported issue is invalid. There are many cases where maven jars contain source code. For example all GWT builds include the source in jars. There has never been a report of this problem. I would close this issue out until the reporter can demonstrate the problem with a test case. > The zookeeper jar includes the java source files > > > Key: ZOOKEEPER-537 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.2.1 >Reporter: Thomas Dudziak > Fix For: 3.3.0 > > > This is a problem if you use zookeeper as a dependency in maven because for > whatever reason the maven compiler plugin will pick up the java files in the > jar and compile them to the output directory. From there they will land in > the generated jar file for whatever project happens to depend on zookeeper > thus introducing duplicate classes (once in zookeeper.jar, once in the > project's artifact). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-532) java compiler should be target Java 1.5
[ https://issues.apache.org/jira/browse/ZOOKEEPER-532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino updated ZOOKEEPER-532: Status: Patch Available (was: Open) > java compiler should be target Java 1.5 > --- > > Key: ZOOKEEPER-532 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-532 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.2.1 >Reporter: Hiram Chirino > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-532.patch > > > The jars released in 3.2.1 will not run on Java 1.5. With a small build > change, it is possible to generate jars that will run on Java 1.5. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-532) java compiler should be target Java 1.5
java compiler should be target Java 1.5 --- Key: ZOOKEEPER-532 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-532 Project: Zookeeper Issue Type: Bug Affects Versions: 3.2.1 Reporter: Hiram Chirino Fix For: 3.3.0 The jars released in 3.2.1 will not run on Java 1.5. With a small build change, it is possible to generate jars that will run on Java 1.5. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-532) java compiler should be target Java 1.5
[ https://issues.apache.org/jira/browse/ZOOKEEPER-532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino updated ZOOKEEPER-532: Attachment: ZOOKEEPER-532.patch Attaching patch which updates the build so that javac targets 1.5. > java compiler should be target Java 1.5 > --- > > Key: ZOOKEEPER-532 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-532 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.2.1 >Reporter: Hiram Chirino > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-532.patch > > > The jars released in 3.2.1 will not run on Java 1.5. With a small build > change, it is possible to generate jars that will run on Java 1.5. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-69) ZooKeeper logo
[ https://issues.apache.org/jira/browse/ZOOKEEPER-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650576#action_12650576 ] Hiram Chirino commented on ZOOKEEPER-69: I think it's important that you get a vector format for whatever logo you accept as the official version. It comes in really handy when you want to print a large poster sized logo for a conference or something. > ZooKeeper logo > -- > > Key: ZOOKEEPER-69 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-69 > Project: Zookeeper > Issue Type: Wish > Components: documentation >Reporter: Flavio Paiva Junqueira >Assignee: Benjamin Reed >Priority: Minor > Fix For: 3.1.0 > > Attachments: pbzk.gif, zk_logo_use.png, zk_logo_use2.png, > zookeeper-sketch.jpg > > > I think we need a cool logo for the project. The ones I've seen so far are a > little lame, and that includes the one I've created for SourceForge. If > anyone on this list has an idea or knows of anyone with some art skills, > plese add a commento to this Jira. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-234) Eliminate using statics to initialize the sever. Should allow server to be more embeddable in OSGi enviorments.
Eliminate using statics to initialize the sever. Should allow server to be
more embeddable in OSGi enviorments.
Key: ZOOKEEPER-234
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-234
Project: Zookeeper
Issue Type: Improvement
Reporter: Hiram Chirino
Assignee: Patrick Hunt
Patrick request I open up this in issue in this [email
thread|http://n2.nabble.com/ActiveMQ-is-now-using-ZooKeeper-td1573272.html]
The main culprit I've noticed is:
{code}
ServerStats.registerAsConcrete();
{code}
But there may be others.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-233) Create a slimer jar for clients to reduce thier disk footprint.
Create a slimer jar for clients to reduce thier disk footprint. --- Key: ZOOKEEPER-233 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-233 Project: Zookeeper Issue Type: New Feature Reporter: Hiram Chirino Assignee: Patrick Hunt Priority: Trivial Patrick request I open up this in issue in this [email thread|http://n2.nabble.com/ActiveMQ-is-now-using-ZooKeeper-td1573272.html] -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-224) Deploy ZooKeeper 3.0.0 to a Maven Repository
[
https://issues.apache.org/jira/browse/ZOOKEEPER-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650272#action_12650272
]
Hiram Chirino commented on ZOOKEEPER-224:
-
Q: How are the .sha1 files generated? What's the command?
A:
{code}
prompt> openssl dgst -md5 < inputfile
prompt> openssl dgst -sha1 < inputfile
{code}
Q: I update maven-metadata.xml and regenerate the md5/sha1?
A: yes. maven-metadata.xml is mainly used by the plugin download system maven
has. it will consult this file to see what the latest version of the artifact
is. So while it's not critical that the metadata is maintained, it is done for
all maven deployed artifacts so ideally it should be done.
Q: And also create a new 3.0.1 subdir at the same level as the 3.0.0 subdir?
A: Yes
Q: Should I include 3.0.0 as well or just 3.0.1?
A: Yes please. That way all your releases are available via Maven.
> Deploy ZooKeeper 3.0.0 to a Maven Repository
>
>
> Key: ZOOKEEPER-224
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-224
> Project: Zookeeper
> Issue Type: Task
> Components: build
>Affects Versions: 3.0.0
>Reporter: Hiram Chirino
>Assignee: Patrick Hunt
>Priority: Critical
>
> I've created the maven poms needed for the 3.0.0 release.
> The directory structure and artifacts located at:
> http://people.apache.org/~chirino/zk-repo/
> aka
> people.apache.org:/x1/users/chirino/public_html/zk-repo
> Just need sto get GPG signed by the project KEY and deployed to:
> people.apache.org:/www/people.apache.org/repo/m2-ibiblio-rsync-repository
> Who's the current ZooKeeper release manager?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-224) Deploy ZooKeeper 3.0.0 to a Maven Repository
[
https://issues.apache.org/jira/browse/ZOOKEEPER-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649119#action_12649119
]
Hiram Chirino commented on ZOOKEEPER-224:
-
Hi Patrick,
1) Yeah.. same key used to sign the distro. Just so that folks who get the
artifacts from maven can verify that it's from a trusted source.
2) The /www/people.apache.org/repo/m2-ibiblio-rsync-repository directory is the
Apache Maven2 release repository. Only official releases should be pushed
there. Artifacts deployed here will get mirrored to the maven central
repository. You deploy to this the same way you deployed the release distro to
people.apache.org:/www/www.apache.org/dist/hadoop/zookeeper. I would just scp
to people.apache.org:/www/people.apache.org/repo/m2-ibiblio-rsync-repository
3) Yes. The entire directory structure and files contained within the
http://people.apache.org/~chirino/zk-repo/ directory need to be preserved. If
my directory had GPG signed all the artifacts (including poms), you would have
been able to ssh into the people.apache.org machine and run:
{code}
cp -r /x1/users/chirino/public_html/zk-repo/*
/www/people.apache.org/repo/m2-ibiblio-rsync-repository
{code}
4) Same implications that you have when your deploy your release distro to the
people.apache.org:/www/www.apache.org/dist/hadoop/zookeeper directory. As long
as the people.apache.org does not get hacked only Apache committers can deploy
a signed zk jar. Just like with release distros, the onus of verifying jar
signatures lies with the downstream user. You guys should document this well
on your website along with the KEYS file they should validate against. And
hope that the website hosting the KEYS file does not get hacked too :) (The
chain of trust and security is so fragile!)
> Deploy ZooKeeper 3.0.0 to a Maven Repository
>
>
> Key: ZOOKEEPER-224
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-224
> Project: Zookeeper
> Issue Type: Task
> Components: build
>Affects Versions: 3.0.0
>Reporter: Hiram Chirino
>Assignee: Patrick Hunt
>Priority: Critical
>
> I've created the maven poms needed for the 3.0.0 release.
> The directory structure and artifacts located at:
> http://people.apache.org/~chirino/zk-repo/
> aka
> people.apache.org:/x1/users/chirino/public_html/zk-repo
> Just need sto get GPG signed by the project KEY and deployed to:
> people.apache.org:/www/people.apache.org/repo/m2-ibiblio-rsync-repository
> Who's the current ZooKeeper release manager?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-224) Deploy ZooKeeper 3.0.0 to a Maven Repository
[ https://issues.apache.org/jira/browse/ZOOKEEPER-224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino reassigned ZOOKEEPER-224: --- Assignee: Patrick Hunt assigning to the guy that can do it :) > Deploy ZooKeeper 3.0.0 to a Maven Repository > > > Key: ZOOKEEPER-224 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-224 > Project: Zookeeper > Issue Type: Task > Components: build >Affects Versions: 3.0.0 >Reporter: Hiram Chirino >Assignee: Patrick Hunt >Priority: Critical > > I've created the maven poms needed for the 3.0.0 release. > The directory structure and artifacts located at: > http://people.apache.org/~chirino/zk-repo/ > aka > people.apache.org:/x1/users/chirino/public_html/zk-repo > Just need sto get GPG signed by the project KEY and deployed to: > people.apache.org:/www/people.apache.org/repo/m2-ibiblio-rsync-repository > Who's the current ZooKeeper release manager? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-224) Deploy ZooKeeper 3.0.0 to a Maven Repository
Deploy ZooKeeper 3.0.0 to a Maven Repository Key: ZOOKEEPER-224 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-224 Project: Zookeeper Issue Type: Task Components: build Affects Versions: 3.0.0 Reporter: Hiram Chirino Priority: Critical I've created the maven poms needed for the 3.0.0 release. The directory structure and artifacts located at: http://people.apache.org/~chirino/zk-repo/ aka people.apache.org:/x1/users/chirino/public_html/zk-repo Just need sto get GPG signed by the project KEY and deployed to: people.apache.org:/www/people.apache.org/repo/m2-ibiblio-rsync-repository Who's the current ZooKeeper release manager? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-82) Make the ZooKeeperServer more DI friendly
[ https://issues.apache.org/jira/browse/ZOOKEEPER-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino updated ZOOKEEPER-82: --- Status: Patch Available (was: Open) > Make the ZooKeeperServer more DI friendly > - > > Key: ZOOKEEPER-82 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-82 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Attachments: ZOOKEEPER-82-b.patch, ZOOKEEPER-82-b.patch > > > Proposed changes were discussed in [this mailing list > thread|http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/200807.mbox/[EMAIL > PROTECTED]: > Basic goals are: > * Decouple the current configuration system from the public API. I > see stuff like ZooKeeperServer being coupled to ServerConfig a bit. > * Allow the use of setter injection in addition to constructor > injection. This is the most important thing needed to let spring more > easily configure the objects. > * Move the main() methods out of the ZooKeeperServer class. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620004#action_12620004 ] Hiram Chirino commented on ZOOKEEPER-103: - I think this patch is a nice middle ground. It's using only ANT, but adopting the maven directory conventions. So Pat's -1 does not really apply to this issue since ant is the only build system being used. Could the rest of the committers please post their thoughts on this? BTW once this is implemented, it should be easier to implement: ZOOKEEPER-95 and ZOOKEEPER-98 > Reorganize the ZooKeeper source distro to follow maven conventions > -- > > Key: ZOOKEEPER-103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh > > > This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino updated ZOOKEEPER-103: Status: Patch Available (was: Open) > Reorganize the ZooKeeper source distro to follow maven conventions > -- > > Key: ZOOKEEPER-103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh > > > This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619871#action_12619871 ] Hiram Chirino commented on ZOOKEEPER-103: - On ZOOKEEPER-83 we plainly agreed that we were going to compromise and use maven conventions for the directory structure but only include a ant build. And yes.. it's suspicious because it IS using the maven conventions. There is no doubt about it. That was part of the compromise. > Reorganize the ZooKeeper source distro to follow maven conventions > -- > > Key: ZOOKEEPER-103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh > > > This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619658#action_12619658 ] Hiram Chirino commented on ZOOKEEPER-103: - The redundancy is a good convention since it makes it obvious which directory builds which jar file. And prefixing all the zookeeper jars with zookeeper- is a good convention too since it will help uniquely identify your jars in a project that uses multiple 3rd party jars. For example if ActiveMQ starts shipping some of the zookeeper bits in it's distribution. > Reorganize the ZooKeeper source distro to follow maven conventions > -- > > Key: ZOOKEEPER-103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh > > > This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619239#action_12619239 ] Hiram Chirino commented on ZOOKEEPER-83: I've created a maven plugin that can be used to verify integrity of downloaded dependencies. This should cross out the biggest concern that the hadoop folks had with maven. The plugin can be found here: https://svn.apache.org/repos/asf/servicemix/maven-plugins/checksum-maven-plugin/trunk > Switch to using maven to build ZooKeeper > > > Key: ZOOKEEPER-83 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > > Maven is a great too for building java projects at the ASF. It helps > standardize the build a bit since it's a convention oriented. > It's dependency auto downloading would remove the need to store the > dependencies in svn, and it will handle many of the suggested ASF policies > like gpg signing of the releases and such. > The ZooKeeper build is almost vanilla except for the jute compiler bits. > Things that would need to change are: > * re-organize the source tree a little so that it uses the maven directory > conventions > * seperate the jute bits out into seperate modules so that a maven plugin > can be with it > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619107#action_12619107 ] Hiram Chirino commented on ZOOKEEPER-103: - The maven convention is to have each module/jar the it's own directory who's name matches the module/jar name. The ant build does not do this (yet) but in the maven build, you end up with zookeeper-xxx.jar files. > Reorganize the ZooKeeper source distro to follow maven conventions > -- > > Key: ZOOKEEPER-103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh > > > This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-107) Allow dynamic changes to server cluster membership
[
https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619106#action_12619106
]
Hiram Chirino commented on ZOOKEEPER-107:
-
I personally think that this needs to stay decoupled so that group membership
can be controlled via different implementations. In other words, I think that
the QuorumPeer should not have to have any constructor args for it to know it's
peers. It should persistently store/remember what the list of peers are part
of the group since it last started.
Not sure if it makes sense to keep that list in the ZK db or not.
When a node that is not part of a cluster first starts up, it needs to know if
it's starting a new cluster or if it is joining an existing cluster.
Therefore, I think the QuorumPeer class needs methods like the following:
{code}
/**
* Contacts a ZK server in the cluster, adds this peer to the cluster and gets
a listing of the rest of the peers in
* the cluster.
*
* Optional: is slaveOnly is true, then this peer should never be elected
master.
*
* Throws an error if this peer is already part of a cluster.
*/
void joinCluster( URI server, bool slaveOnly )
/**
* Starts this peer as the first node in the cluster and makes him the master.
*
* Throws an error if this peer is already part of a cluster.
*/
void createCluster()
/**
* Removes this peer from the peer list maintained by the cluster.
*
* Throws an error if this peer is not part of a cluster.
*/
void leaveCluster()
/**
* Gets a list of peers in the cluser.
*
* @return null if not part of a cluster yet.
*/
List getClusterPeers()
{code}
If methods like the above are available, then an administrator can dynamically
manage adding/removing nodes on an existing ZooKeeper cluster. or some
automated agent could do it. Note that the peer list needs to get replicated
to all cluster members and persisted to avoid split brain issues on peer
restart. Operations like joinCluster(), leaveCluster(), getClusterPeers()
would block until a master is elected in the cluster.
Please note the 'nice to have feature' where you have the ability to designate
some peers as NOT being eligible to become a master. This would allow you to
support using heterogeneous peers, and enforce only allowing the higher end
machines to become the masters.
> Allow dynamic changes to server cluster membership
> --
>
> Key: ZOOKEEPER-107
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-107
> Project: Zookeeper
> Issue Type: Improvement
> Components: server
>Reporter: Patrick Hunt
>
> Currently cluster membership is statically defined, adding/removing hosts
> to/from the server cluster dynamically needs to be supported.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-80) Document process for client recipe contributions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617868#action_12617868 ] Hiram Chirino commented on ZOOKEEPER-80: Patrick, no.. as the recipes will be grouped by language. I only see a few top level dirs being created. > Document process for client recipe contributions > > > Key: ZOOKEEPER-80 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-80 > Project: Zookeeper > Issue Type: Task > Components: documentation >Reporter: Patrick Hunt >Assignee: Patrick Hunt > > Per Doug's suggestion I'll use a link instead of copy/paste: > http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/200807.mbox/[EMAIL > PROTECTED] -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617859#action_12617859 ] Hiram Chirino commented on ZOOKEEPER-103: - Generally it's just a good sign showing that stuff is decoupled. we could group things into directories but that would just deepen the directory tree and not add tremendous amount of value. > Reorganize the ZooKeeper source distro to follow maven conventions > -- > > Key: ZOOKEEPER-103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh > > > This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-80) Document process for client recipe contributions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617827#action_12617827 ] Hiram Chirino commented on ZOOKEEPER-80: Hi, Here are my 2 cents for how to implement this so it co-exists nicely with ZOOKEEPER-103 For java at least, you want to group lots of small disjoint contributions into one jar. If they become more massive, it may be worth splitting it out to independent jars, but simplicities sake/maintenance needed to manage small contributions, one jar should be enough. The only tricky bit is that we also want to support implementing the recipe in other languages, so we want to also support multiple module directories. So my proposal is to have a module which would mainly hold the general documentation for the protocol which should be language agnostic: trunk/zookeeper-recipes/ trunk/zookeeper-recipes/src/docs And then we just have sub modules for the implementation of those recipes for the different languages. The java module would use maven directory layouts trunk/zookeeper-recipes/zookeeper-java-recipes trunk/zookeeper-recipes/zookeeper-java-recipes/src/main/java The c stuff would standard GNU c source layout trunk/zookeeper-recipes/zookeeper-c-recipes trunk/zookeeper-recipes/zookeeper-c-recipes/src ruby would use what every ruby folks are used to. trunk/zookeeper-recipes/zookeeper-ruby-recipes Also note that it might be better to replace 'recipes' term with 'protocols'. > Document process for client recipe contributions > > > Key: ZOOKEEPER-80 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-80 > Project: Zookeeper > Issue Type: Task > Components: documentation >Reporter: Patrick Hunt >Assignee: Patrick Hunt > > Per Doug's suggestion I'll use a link instead of copy/paste: > http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/200807.mbox/[EMAIL > PROTECTED] -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617823#action_12617823 ] Hiram Chirino commented on ZOOKEEPER-103: - Benjamin, Good point.. I'll comment on ZOOKEERER-80 on how best to sort out the recipies/contrib stuff. > Reorganize the ZooKeeper source distro to follow maven conventions > -- > > Key: ZOOKEEPER-103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh > > > This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617505#action_12617505 ] Hiram Chirino commented on ZOOKEEPER-83: FYI: The maven folks are working on the security issue: http://docs.codehaus.org/display/MAVEN/Repository+Security > Switch to using maven to build ZooKeeper > > > Key: ZOOKEEPER-83 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > > Maven is a great too for building java projects at the ASF. It helps > standardize the build a bit since it's a convention oriented. > It's dependency auto downloading would remove the need to store the > dependencies in svn, and it will handle many of the suggested ASF policies > like gpg signing of the releases and such. > The ZooKeeper build is almost vanilla except for the jute compiler bits. > Things that would need to change are: > * re-organize the source tree a little so that it uses the maven directory > conventions > * seperate the jute bits out into seperate modules so that a maven plugin > can be with it > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617503#action_12617503 ] Hiram Chirino commented on ZOOKEEPER-103: - Any updates on this? > Reorganize the ZooKeeper source distro to follow maven conventions > -- > > Key: ZOOKEEPER-103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh > > > This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-102) Need to replace Jute with supported code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617226#action_12617226 ] Hiram Chirino commented on ZOOKEEPER-102: - [protobuf|http://code.google.com/p/protobuf/] might be an option. > Need to replace Jute with supported code > > > Key: ZOOKEEPER-102 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-102 > Project: Zookeeper > Issue Type: Improvement >Reporter: Benjamin Reed > > ZooKeeper currently uses Jute to serialize objects to put on the wire and on > disk. We pulled Jute out of Hadoop and added a C binding. Both versions of > Jute have evolved (although Hadoop still doesn't have a C binding). It would > be nice to use a more standard serialization library. Some options include > Thrift or Google's protocol buffers. > Our main requirements would be Java and C bindings and good performance. (For > example, serializing to XML would give us incredibly bad performance and > would not be acceptible!) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617089#action_12617089 ] Hiram Chirino commented on ZOOKEEPER-103: - Hi Patrick yes. Lots projects just keep it flat like that. Some project will group stuff in a directory if there is a specific grouping to the modules. Generally it's more specific than a general 'contrib' grouping though. Also something to think about is the possibility of having independent release cycles for some of the modules. At this stage of the I don't think we need to worry about that complexity. Benjamin, Generally the final binary distribution does make that distinction. Some organize as: /bin : start scripts /lib : the main zoo keeper jar /lib/extras or /lib/contrib: optional libs that are not required to run ZK /doc : /src etc. etc. > Reorganize the ZooKeeper source distro to follow maven conventions > -- > > Key: ZOOKEEPER-103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh > > > This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-96) The jute parser should get generated from the jj files instead of checking in the generated sources
[ https://issues.apache.org/jira/browse/ZOOKEEPER-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617087#action_12617087 ] Hiram Chirino commented on ZOOKEEPER-96: +1 on checking in the jar > The jute parser should get generated from the jj files instead of checking in > the generated sources > --- > > Key: ZOOKEEPER-96 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-96 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-98) Make the ZooKeeper optional bits seperate jars.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617072#action_12617072 ] Hiram Chirino commented on ZOOKEEPER-98: It just means the build needs to get updated so that each modules javac output has it's own directory so that a proper jar for each can get created. Right now all the modules: jmx, source code generators, main stuff all get dumped into one classes directory. > Make the ZooKeeper optional bits seperate jars. > --- > > Key: ZOOKEEPER-98 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-98 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino > > Optional bits like the ZooKeeper jmx module and the upcoming protocol and > spring support stuff should get packaged as separate jars so that they don't > keep bloating up the main ZooKeeper jar. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617070#action_12617070 ] Hiram Chirino commented on ZOOKEEPER-83: Re-opened as a new issue ZOOKEEPER-103 it reduces the scope of the patch to just be implementing the maven directory conventions. > Switch to using maven to build ZooKeeper > > > Key: ZOOKEEPER-83 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > > Maven is a great too for building java projects at the ASF. It helps > standardize the build a bit since it's a convention oriented. > It's dependency auto downloading would remove the need to store the > dependencies in svn, and it will handle many of the suggested ASF policies > like gpg signing of the releases and such. > The ZooKeeper build is almost vanilla except for the jute compiler bits. > Things that would need to change are: > * re-organize the source tree a little so that it uses the maven directory > conventions > * seperate the jute bits out into seperate modules so that a maven plugin > can be with it > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino updated ZOOKEEPER-103: Fix Version/s: 3.0.0 Affects Version/s: (was: 3.0.0) Status: Patch Available (was: Open) > Reorganize the ZooKeeper source distro to follow maven conventions > -- > > Key: ZOOKEEPER-103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh > > > This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino updated ZOOKEEPER-103: Attachment: ZOOKEEPER-103.patch Attaching patch file for ant build so that it works using the new directory organization. > Reorganize the ZooKeeper source distro to follow maven conventions > -- > > Key: ZOOKEEPER-103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-103.patch, ZOOKEEPER-103.sh > > > This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
[ https://issues.apache.org/jira/browse/ZOOKEEPER-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino updated ZOOKEEPER-103: Attachment: ZOOKEEPER-103.sh This the shell script that will reorgnaize the source locations. > Reorganize the ZooKeeper source distro to follow maven conventions > -- > > Key: ZOOKEEPER-103 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 > Project: Zookeeper > Issue Type: Improvement > Components: build >Affects Versions: 3.0.0 >Reporter: Hiram Chirino > Attachments: ZOOKEEPER-103.sh > > > This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-103) Reorganize the ZooKeeper source distro to follow maven conventions
Reorganize the ZooKeeper source distro to follow maven conventions -- Key: ZOOKEEPER-103 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-103 Project: Zookeeper Issue Type: Improvement Components: build Affects Versions: 3.0.0 Reporter: Hiram Chirino Attachments: ZOOKEEPER-103.sh This was sugested as way to bridge the gap in ZOOKEEPER-83 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino updated ZOOKEEPER-83: --- Attachment: (was: zookeeper-mavened.tgz) > Switch to using maven to build ZooKeeper > > > Key: ZOOKEEPER-83 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > > Maven is a great too for building java projects at the ASF. It helps > standardize the build a bit since it's a convention oriented. > It's dependency auto downloading would remove the need to store the > dependencies in svn, and it will handle many of the suggested ASF policies > like gpg signing of the releases and such. > The ZooKeeper build is almost vanilla except for the jute compiler bits. > Things that would need to change are: > * re-organize the source tree a little so that it uses the maven directory > conventions > * seperate the jute bits out into seperate modules so that a maven plugin > can be with it > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-97) The code generators should support an optional output directory
[ https://issues.apache.org/jira/browse/ZOOKEEPER-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino updated ZOOKEEPER-97: --- Attachment: ZOOKEEPER-97.patch Attaching patch that implements the feature. > The code generators should support an optional output directory > --- > > Key: ZOOKEEPER-97 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-97 > Project: Zookeeper > Issue Type: Improvement >Reporter: Hiram Chirino > Attachments: ZOOKEEPER-97.patch > > > Currently the code generators (jute compiler and version gen) generate code > the current directory. If these tools are to be re-used by smart ides, ant > tasks, or maven plugins, the output directory needs to be parameter to the > tools. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-97) The code generators should support an optional output directory
[ https://issues.apache.org/jira/browse/ZOOKEEPER-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617034#action_12617034 ] Hiram Chirino commented on ZOOKEEPER-97: This was actually extracted from the change proposed in ZOOKEEPER-82 > The code generators should support an optional output directory > --- > > Key: ZOOKEEPER-97 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-97 > Project: Zookeeper > Issue Type: Improvement >Reporter: Hiram Chirino > Attachments: ZOOKEEPER-97.patch > > > Currently the code generators (jute compiler and version gen) generate code > the current directory. If these tools are to be re-used by smart ides, ant > tasks, or maven plugins, the output directory needs to be parameter to the > tools. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-97) The code generators should support an optional output directory
[ https://issues.apache.org/jira/browse/ZOOKEEPER-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino updated ZOOKEEPER-97: --- Status: Patch Available (was: Open) > The code generators should support an optional output directory > --- > > Key: ZOOKEEPER-97 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-97 > Project: Zookeeper > Issue Type: Improvement >Reporter: Hiram Chirino > Attachments: ZOOKEEPER-97.patch > > > Currently the code generators (jute compiler and version gen) generate code > the current directory. If these tools are to be re-used by smart ides, ant > tasks, or maven plugins, the output directory needs to be parameter to the > tools. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-82) Make the ZooKeeperServer more DI friendly
[ https://issues.apache.org/jira/browse/ZOOKEEPER-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617028#action_12617028 ] Hiram Chirino commented on ZOOKEEPER-82: created issue ZOOKEEPER-100 to track that Thread change idea. > Make the ZooKeeperServer more DI friendly > - > > Key: ZOOKEEPER-82 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-82 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Attachments: ZOOKEEPER-82-b.patch > > > Proposed changes were discussed in [this mailing list > thread|http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/200807.mbox/[EMAIL > PROTECTED]: > Basic goals are: > * Decouple the current configuration system from the public API. I > see stuff like ZooKeeperServer being coupled to ServerConfig a bit. > * Allow the use of setter injection in addition to constructor > injection. This is the most important thing needed to let spring more > easily configure the objects. > * Move the main() methods out of the ZooKeeperServer class. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-82) Make the ZooKeeperServer more DI friendly
[ https://issues.apache.org/jira/browse/ZOOKEEPER-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino updated ZOOKEEPER-82: --- Attachment: (was: ZOOKEEPER-82.patch) > Make the ZooKeeperServer more DI friendly > - > > Key: ZOOKEEPER-82 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-82 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Attachments: ZOOKEEPER-82-b.patch > > > Proposed changes were discussed in [this mailing list > thread|http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/200807.mbox/[EMAIL > PROTECTED]: > Basic goals are: > * Decouple the current configuration system from the public API. I > see stuff like ZooKeeperServer being coupled to ServerConfig a bit. > * Allow the use of setter injection in addition to constructor > injection. This is the most important thing needed to let spring more > easily configure the objects. > * Move the main() methods out of the ZooKeeperServer class. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-82) Make the ZooKeeperServer more DI friendly
[ https://issues.apache.org/jira/browse/ZOOKEEPER-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino updated ZOOKEEPER-82: --- Status: Patch Available (was: Open) > Make the ZooKeeperServer more DI friendly > - > > Key: ZOOKEEPER-82 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-82 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Attachments: ZOOKEEPER-82-b.patch > > > Proposed changes were discussed in [this mailing list > thread|http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/200807.mbox/[EMAIL > PROTECTED]: > Basic goals are: > * Decouple the current configuration system from the public API. I > see stuff like ZooKeeperServer being coupled to ServerConfig a bit. > * Allow the use of setter injection in addition to constructor > injection. This is the most important thing needed to let spring more > easily configure the objects. > * Move the main() methods out of the ZooKeeperServer class. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-82) Make the ZooKeeperServer more DI friendly
[ https://issues.apache.org/jira/browse/ZOOKEEPER-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino updated ZOOKEEPER-82: --- Attachment: (was: ZOOKEEPER-82-b.patch) > Make the ZooKeeperServer more DI friendly > - > > Key: ZOOKEEPER-82 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-82 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Attachments: ZOOKEEPER-82-b.patch > > > Proposed changes were discussed in [this mailing list > thread|http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/200807.mbox/[EMAIL > PROTECTED]: > Basic goals are: > * Decouple the current configuration system from the public API. I > see stuff like ZooKeeperServer being coupled to ServerConfig a bit. > * Allow the use of setter injection in addition to constructor > injection. This is the most important thing needed to let spring more > easily configure the objects. > * Move the main() methods out of the ZooKeeperServer class. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-82) Make the ZooKeeperServer more DI friendly
[ https://issues.apache.org/jira/browse/ZOOKEEPER-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino updated ZOOKEEPER-82: --- Attachment: ZOOKEEPER-82-b.patch Attaching updated patch. > Make the ZooKeeperServer more DI friendly > - > > Key: ZOOKEEPER-82 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-82 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Attachments: ZOOKEEPER-82-b.patch > > > Proposed changes were discussed in [this mailing list > thread|http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/200807.mbox/[EMAIL > PROTECTED]: > Basic goals are: > * Decouple the current configuration system from the public API. I > see stuff like ZooKeeperServer being coupled to ServerConfig a bit. > * Allow the use of setter injection in addition to constructor > injection. This is the most important thing needed to let spring more > easily configure the objects. > * Move the main() methods out of the ZooKeeperServer class. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-82) Make the ZooKeeperServer more DI friendly
[ https://issues.apache.org/jira/browse/ZOOKEEPER-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino updated ZOOKEEPER-82: --- Attachment: ZOOKEEPER-82-b.patch Attaching updated patch. > Make the ZooKeeperServer more DI friendly > - > > Key: ZOOKEEPER-82 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-82 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Attachments: ZOOKEEPER-82-b.patch > > > Proposed changes were discussed in [this mailing list > thread|http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/200807.mbox/[EMAIL > PROTECTED]: > Basic goals are: > * Decouple the current configuration system from the public API. I > see stuff like ZooKeeperServer being coupled to ServerConfig a bit. > * Allow the use of setter injection in addition to constructor > injection. This is the most important thing needed to let spring more > easily configure the objects. > * Move the main() methods out of the ZooKeeperServer class. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-100) Avoid extending Thread in the public ZooKeeper API
Avoid extending Thread in the public ZooKeeper API -- Key: ZOOKEEPER-100 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-100 Project: Zookeeper Issue Type: Improvement Reporter: Hiram Chirino This was discussed in ZOOKEEPER-82 This would allow proper checked exceptions to get thrown when the objects are started/stopped. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-82) Make the ZooKeeperServer more DI friendly
[ https://issues.apache.org/jira/browse/ZOOKEEPER-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616954#action_12616954 ] Hiram Chirino commented on ZOOKEEPER-82: Weird the patch did not change QuorumPeer at all. QuorumPeer did not currently have a main method. Seem someone else moved it to ManagedQuorumPeer. But in my next patch I'll move those java docs and update the scripts. Yes main was moved from ZooKeeperServer to new class which my patch failed to include. Sorry I'll to a attach a new patch asap. Will also add some doco for the getters/setters. BTW > Make the ZooKeeperServer more DI friendly > - > > Key: ZOOKEEPER-82 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-82 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Attachments: ZOOKEEPER-82.patch > > > Proposed changes were discussed in [this mailing list > thread|http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/200807.mbox/[EMAIL > PROTECTED]: > Basic goals are: > * Decouple the current configuration system from the public API. I > see stuff like ZooKeeperServer being coupled to ServerConfig a bit. > * Allow the use of setter injection in addition to constructor > injection. This is the most important thing needed to let spring more > easily configure the objects. > * Move the main() methods out of the ZooKeeperServer class. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (ZOOKEEPER-82) Make the ZooKeeperServer more DI friendly
[ https://issues.apache.org/jira/browse/ZOOKEEPER-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616954#action_12616954 ] chirino edited comment on ZOOKEEPER-82 at 7/25/08 10:13 AM: -- Weird the patch did not change QuorumPeer at all. QuorumPeer did not currently have a main method. Seem someone else moved it to ManagedQuorumPeer. But in my next patch I'll move those java docs and update the scripts. Yes main was moved from ZooKeeperServer to new class which my patch failed to include. Sorry I'll to a attach a new patch asap. Will also add some doco for the getters/setters. was (Author: chirino): Weird the patch did not change QuorumPeer at all. QuorumPeer did not currently have a main method. Seem someone else moved it to ManagedQuorumPeer. But in my next patch I'll move those java docs and update the scripts. Yes main was moved from ZooKeeperServer to new class which my patch failed to include. Sorry I'll to a attach a new patch asap. Will also add some doco for the getters/setters. BTW > Make the ZooKeeperServer more DI friendly > - > > Key: ZOOKEEPER-82 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-82 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Attachments: ZOOKEEPER-82.patch > > > Proposed changes were discussed in [this mailing list > thread|http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/200807.mbox/[EMAIL > PROTECTED]: > Basic goals are: > * Decouple the current configuration system from the public API. I > see stuff like ZooKeeperServer being coupled to ServerConfig a bit. > * Allow the use of setter injection in addition to constructor > injection. This is the most important thing needed to let spring more > easily configure the objects. > * Move the main() methods out of the ZooKeeperServer class. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-99) All MXBeans interfaces that don't use complex paramters need to be renamed as MBean interaces.
All MXBeans interfaces that don't use complex paramters need to be renamed as MBean interaces. --- Key: ZOOKEEPER-99 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-99 Project: Zookeeper Issue Type: Bug Components: server Reporter: Hiram Chirino Fix For: 3.0.0 All the MXBean interfaces that I've looked at are standard MBean interfaces. The interface names should get renamed to MBean instaead of MXBean. That way the server can also run on a the Java 1.5 Platform. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-98) Make the ZooKeeper optional bits seperate jars.
Make the ZooKeeper optional bits seperate jars. --- Key: ZOOKEEPER-98 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-98 Project: Zookeeper Issue Type: Improvement Components: build Reporter: Hiram Chirino Optional bits like the ZooKeeper jmx module and the upcoming protocol and spring support stuff should get packaged as separate jars so that they don't keep bloating up the main ZooKeeper jar. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-97) The code generators should support an optional output directory
The code generators should support an optional output directory --- Key: ZOOKEEPER-97 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-97 Project: Zookeeper Issue Type: Improvement Reporter: Hiram Chirino Currently the code generators (jute compiler and version gen) generate code the current directory. If these tools are to be re-used by smart ides, ant tasks, or maven plugins, the output directory needs to be parameter to the tools. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-96) The jute parser should get generated from the jj files instead of checking in the generated sources
The jute parser should get generated from the jj files instead of checking in the generated sources --- Key: ZOOKEEPER-96 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-96 Project: Zookeeper Issue Type: Improvement Components: build Reporter: Hiram Chirino -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-94) JMX tests are needed to verify that the JMX MBeans work properly
JMX tests are needed to verify that the JMX MBeans work properly Key: ZOOKEEPER-94 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-94 Project: Zookeeper Issue Type: Bug Components: server Reporter: Hiram Chirino Fix For: 3.0.0 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-95) There is no need to include the code generators in the zookeeper jar
There is no need to include the code generators in the zookeeper jar Key: ZOOKEEPER-95 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-95 Project: Zookeeper Issue Type: Improvement Components: build Reporter: Hiram Chirino -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616577#action_12616577 ] Hiram Chirino commented on ZOOKEEPER-83: BTW Hudson does support maven.. see: http://weblogs.java.net/blog/kohsuke/archive/2007/02/maven_2_integra.html > Switch to using maven to build ZooKeeper > > > Key: ZOOKEEPER-83 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino > Attachments: zookeeper-mavened.tgz > > > Maven is a great too for building java projects at the ASF. It helps > standardize the build a bit since it's a convention oriented. > It's dependency auto downloading would remove the need to store the > dependencies in svn, and it will handle many of the suggested ASF policies > like gpg signing of the releases and such. > The ZooKeeper build is almost vanilla except for the jute compiler bits. > Things that would need to change are: > * re-organize the source tree a little so that it uses the maven directory > conventions > * seperate the jute bits out into seperate modules so that a maven plugin > can be with it > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616575#action_12616575 ] Hiram Chirino commented on ZOOKEEPER-83: BTW there are lots of CI tools used at the ASF which DO support maven. But hey if you like Hudson that's cool. Can we at least merge the patch in so that the maven directory convention is preserved and then we can delete the maven build files if you like. The ant build can work with that structure just fine. If we do that then I can provide folks who are interested in a maven build the pom files that just overlay onto the project do they can use maven to build it. So we both win. ZooKeeper only has 1 build system ant. Maven users also win cause they can get some optional poms from me to build the project with. What do you think? > Switch to using maven to build ZooKeeper > > > Key: ZOOKEEPER-83 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino > Attachments: zookeeper-mavened.tgz > > > Maven is a great too for building java projects at the ASF. It helps > standardize the build a bit since it's a convention oriented. > It's dependency auto downloading would remove the need to store the > dependencies in svn, and it will handle many of the suggested ASF policies > like gpg signing of the releases and such. > The ZooKeeper build is almost vanilla except for the jute compiler bits. > Things that would need to change are: > * re-organize the source tree a little so that it uses the maven directory > conventions > * seperate the jute bits out into seperate modules so that a maven plugin > can be with it > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (ZOOKEEPER-78) added a high level protocol/feature - for easy Leader Election or exclusive Write Lock creation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616567#action_12616567 ] chirino edited comment on ZOOKEEPER-78 at 7/24/08 11:30 AM: -- Hi Patrick, The "Notice on the "attach patch" JIRA page that it has the " Grant license to ASF for inclusion in ASF works " option. This has to be checked for us to consider a patch for inclusion. " is not accurate in this case. James and I are are both Apache committers and Members, and as such, when we commit code to the ASF repository a license is granted to the ASF. The jira feature is really only there to be able to accept code from folks who have not filed an ICLA with the ASF. Another way to view this development model is as if we were ZooKeeper committers who do not commit to trunk but which develop new features and bug fixes in development branches. This model of development is use extensively in projects who are adverse to destabilizing the trunk. They develop and test new features in a branch and then merge back once folks are happy with it. This model is also outlined at [Rules for Revolutionaries|http://incubator.apache.org/learn/rules-for-revolutionaries.html] was (Author: chirino): Hi Patrick, The "Notice on the "attach patch" JIRA page that it has the " Grant license to ASF for inclusion in ASF works " option. This has to be checked for us to consider a patch for inclusion. " is not accurate in this case. James and I are are bother Apache committers and Members, and as such, when we commit code to the ASF repository a license is granted to the ASF. The jira feature is really only there to be able to accept code from folks who have not filed an ICLA with the ASF. Another way to view this development model is as if we were ZooKeeper committers who do not commit to trunk but which develop new features and bug fixes in development branches. This model of development is use extensively in projects who are adverse to destabilizing the trunk. They develop and test new features in a branch and then merge back once folks are happy with it. This model is also outlined at [Rules for Revolutionaries|http://incubator.apache.org/learn/rules-for-revolutionaries.html] > added a high level protocol/feature - for easy Leader Election or exclusive > Write Lock creation > --- > > Key: ZOOKEEPER-78 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-78 > Project: Zookeeper > Issue Type: New Feature > Components: java client >Affects Versions: 3.0.0 >Reporter: james strachan > Attachments: patch_with_including_Benjamin's_fix.patch, > using_zookeeper_facade.patch > > > Here's a patch which adds a little WriteLock helper class for performing > leader elections or creating exclusive locks in some directory znode. Note > its an early cut; am sure we can improve it over time. The aim is to avoid > folks having to use the low level ZK stuff but provide a simpler high level > abstraction. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (ZOOKEEPER-78) added a high level protocol/feature - for easy Leader Election or exclusive Write Lock creation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616567#action_12616567 ] chirino edited comment on ZOOKEEPER-78 at 7/24/08 11:28 AM: -- Hi Patrick, The "Notice on the "attach patch" JIRA page that it has the " Grant license to ASF for inclusion in ASF works " option. This has to be checked for us to consider a patch for inclusion. " is not accurate in this case. James and I are are bother Apache committers and Members, and as such, when we commit code to the ASF repository a license is granted to the ASF. The jira feature is really only there to be able to accept code from folks who have not filed an ICLA with the ASF. Another way to view this development model is as if we were ZooKeeper committers who do not commit to trunk but which develop new features and bug fixes in development branches. This model of development is use extensively in projects who are adverse to destabilizing the trunk. They develop and test new features in a branch and then merge back once folks are happy with it. This model is also outlined at [Rules for Revolutionaries|http://incubator.apache.org/learn/rules-for-revolutionaries.html] was (Author: chirino): Hi Patrick, The "Notice on the "attach patch" JIRA page that it has the " Grant license to ASF for inclusion in ASF works " option. This has to be checked for us to consider a patch for inclusion. " is not accurate in this case. James and I are are bother Apache committers and Members, as such when we commit code to the ASF repository like what James had done, and like when you do when you commit code to zookeeper trunk, a license is granted to the ASF. The jira feature is really only there to be able to accept code from folks who have not filed an ICLA with the ASF. Another way to view this development model is as if we were ZooKeeper committers who do not commit to trunk but which develop new features and bug fixes in development branches. This model of development is use extensively in projects who are adverse to destabilizing the trunk. They develop and test new features in a branch and then merge back once folks are happy with it. This model is also outlined at [Rules for Revolutionaries|http://incubator.apache.org/learn/rules-for-revolutionaries.html] > added a high level protocol/feature - for easy Leader Election or exclusive > Write Lock creation > --- > > Key: ZOOKEEPER-78 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-78 > Project: Zookeeper > Issue Type: New Feature > Components: java client >Affects Versions: 3.0.0 >Reporter: james strachan > Attachments: patch_with_including_Benjamin's_fix.patch, > using_zookeeper_facade.patch > > > Here's a patch which adds a little WriteLock helper class for performing > leader elections or creating exclusive locks in some directory znode. Note > its an early cut; am sure we can improve it over time. The aim is to avoid > folks having to use the low level ZK stuff but provide a simpler high level > abstraction. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-78) added a high level protocol/feature - for easy Leader Election or exclusive Write Lock creation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616567#action_12616567 ] Hiram Chirino commented on ZOOKEEPER-78: Hi Patrick, The "Notice on the "attach patch" JIRA page that it has the " Grant license to ASF for inclusion in ASF works " option. This has to be checked for us to consider a patch for inclusion. " is not accurate in this case. James and I are are bother Apache committers and Members, as such when we commit code to the ASF repository like what James had done, and like when you do when you commit code to zookeeper trunk, a license is granted to the ASF. The jira feature is really only there to be able to accept code from folks who have not filed an ICLA with the ASF. Another way to view this development model is as if we were ZooKeeper committers who do not commit to trunk but which develop new features and bug fixes in development branches. This model of development is use extensively in projects who are adverse to destabilizing the trunk. They develop and test new features in a branch and then merge back once folks are happy with it. This model is also outlined at [Rules for Revolutionaries|http://incubator.apache.org/learn/rules-for-revolutionaries.html] > added a high level protocol/feature - for easy Leader Election or exclusive > Write Lock creation > --- > > Key: ZOOKEEPER-78 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-78 > Project: Zookeeper > Issue Type: New Feature > Components: java client >Affects Versions: 3.0.0 >Reporter: james strachan > Attachments: patch_with_including_Benjamin's_fix.patch, > using_zookeeper_facade.patch > > > Here's a patch which adds a little WriteLock helper class for performing > leader elections or creating exclusive locks in some directory znode. Note > its an early cut; am sure we can improve it over time. The aim is to avoid > folks having to use the low level ZK stuff but provide a simpler high level > abstraction. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino updated ZOOKEEPER-83: --- Assignee: (was: Hiram Chirino) Status: Patch Available (was: Open) > Switch to using maven to build ZooKeeper > > > Key: ZOOKEEPER-83 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino > Attachments: zookeeper-mavened.tgz > > > Maven is a great too for building java projects at the ASF. It helps > standardize the build a bit since it's a convention oriented. > It's dependency auto downloading would remove the need to store the > dependencies in svn, and it will handle many of the suggested ASF policies > like gpg signing of the releases and such. > The ZooKeeper build is almost vanilla except for the jute compiler bits. > Things that would need to change are: > * re-organize the source tree a little so that it uses the maven directory > conventions > * seperate the jute bits out into seperate modules so that a maven plugin > can be with it > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-82) Make the ZooKeeperServer more DI friendly
[ https://issues.apache.org/jira/browse/ZOOKEEPER-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino updated ZOOKEEPER-82: --- Assignee: (was: Hiram Chirino) Status: Patch Available (was: Open) > Make the ZooKeeperServer more DI friendly > - > > Key: ZOOKEEPER-82 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-82 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino > Attachments: ZOOKEEPER-82.patch > > > Proposed changes were discussed in [this mailing list > thread|http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/200807.mbox/[EMAIL > PROTECTED]: > Basic goals are: > * Decouple the current configuration system from the public API. I > see stuff like ZooKeeperServer being coupled to ServerConfig a bit. > * Allow the use of setter injection in addition to constructor > injection. This is the most important thing needed to let spring more > easily configure the objects. > * Move the main() methods out of the ZooKeeperServer class. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper
[
https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616200#action_12616200
]
chirino edited comment on ZOOKEEPER-83 at 7/23/08 11:18 AM:
--
Hi folks..
To make the maven re-org super simple to apply I created a temp private branch
so that the changes can easily be merged into trunk.
This branch also has an updated ant build which works with the new maven
directory structure.
To merge the changes back into trunk, just run the follow in a clean trunk
checkout:
{code}
svn merge -r 679094:679134
https://svn.apache.org/repos/asf/activemq/sandbox/zookeeper
{code}
was (Author: chirino):
Hi folks..
To make the maven re-org super simple to apply I created a temp private branch
so that the changes can easily be merged into trunk.
This branch also has an updated ant build which works with the new maven
directory structure.
To merge the changes back into trunk, just run the follow in a clean trunk
checkout:
[code}
svn merge -r 679094:679134
https://svn.apache.org/repos/asf/activemq/sandbox/zookeeper
{code}
> Switch to using maven to build ZooKeeper
>
>
> Key: ZOOKEEPER-83
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
>Reporter: Hiram Chirino
>Assignee: Hiram Chirino
> Attachments: zookeeper-mavened.tgz
>
>
> Maven is a great too for building java projects at the ASF. It helps
> standardize the build a bit since it's a convention oriented.
> It's dependency auto downloading would remove the need to store the
> dependencies in svn, and it will handle many of the suggested ASF policies
> like gpg signing of the releases and such.
> The ZooKeeper build is almost vanilla except for the jute compiler bits.
> Things that would need to change are:
> * re-organize the source tree a little so that it uses the maven directory
> conventions
> * seperate the jute bits out into seperate modules so that a maven plugin
> can be with it
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper
[
https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616200#action_12616200
]
Hiram Chirino commented on ZOOKEEPER-83:
Hi folks..
To make the maven re-org super simple to apply I created a temp private branch
so that the changes can easily be merged into trunk.
This branch also has an updated ant build which works with the new maven
directory structure.
To merge the changes back into trunk, just run the follow in a clean trunk
checkout:
[code}
svn merge -r 679094:679134
https://svn.apache.org/repos/asf/activemq/sandbox/zookeeper
{code}
> Switch to using maven to build ZooKeeper
>
>
> Key: ZOOKEEPER-83
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
>Reporter: Hiram Chirino
>Assignee: Hiram Chirino
> Attachments: zookeeper-mavened.tgz
>
>
> Maven is a great too for building java projects at the ASF. It helps
> standardize the build a bit since it's a convention oriented.
> It's dependency auto downloading would remove the need to store the
> dependencies in svn, and it will handle many of the suggested ASF policies
> like gpg signing of the releases and such.
> The ZooKeeper build is almost vanilla except for the jute compiler bits.
> Things that would need to change are:
> * re-organize the source tree a little so that it uses the maven directory
> conventions
> * seperate the jute bits out into seperate modules so that a maven plugin
> can be with it
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-82) Make the ZooKeeperServer more DI friendly
[ https://issues.apache.org/jira/browse/ZOOKEEPER-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616025#action_12616025 ] Hiram Chirino commented on ZOOKEEPER-82: Anybody have a chance to review the patch? > Make the ZooKeeperServer more DI friendly > - > > Key: ZOOKEEPER-82 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-82 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Attachments: ZOOKEEPER-82.patch > > > Proposed changes were discussed in [this mailing list > thread|http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/200807.mbox/[EMAIL > PROTECTED]: > Basic goals are: > * Decouple the current configuration system from the public API. I > see stuff like ZooKeeperServer being coupled to ServerConfig a bit. > * Allow the use of setter injection in addition to constructor > injection. This is the most important thing needed to let spring more > easily configure the objects. > * Move the main() methods out of the ZooKeeperServer class. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616020#action_12616020 ] Hiram Chirino commented on ZOOKEEPER-83: James is right. An ant build could easily co-exist with the maven one if folks feel that adverse to maven. > Switch to using maven to build ZooKeeper > > > Key: ZOOKEEPER-83 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Attachments: zookeeper-mavened.tgz > > > Maven is a great too for building java projects at the ASF. It helps > standardize the build a bit since it's a convention oriented. > It's dependency auto downloading would remove the need to store the > dependencies in svn, and it will handle many of the suggested ASF policies > like gpg signing of the releases and such. > The ZooKeeper build is almost vanilla except for the jute compiler bits. > Things that would need to change are: > * re-organize the source tree a little so that it uses the maven directory > conventions > * seperate the jute bits out into seperate modules so that a maven plugin > can be with it > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615793#action_12615793 ] Hiram Chirino commented on ZOOKEEPER-83: Sure.. maven is not yet impervious to having it's repository hacked. But does it actually happen? No. But then again any repository can get hacked.. even the one we deploy our distributions to. Yes we sign the releases, but how often do folks actually validate against it? So in most systems that kind of attack will happen. Is that the only issue? > Switch to using maven to build ZooKeeper > > > Key: ZOOKEEPER-83 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Attachments: zookeeper-mavened.tgz > > > Maven is a great too for building java projects at the ASF. It helps > standardize the build a bit since it's a convention oriented. > It's dependency auto downloading would remove the need to store the > dependencies in svn, and it will handle many of the suggested ASF policies > like gpg signing of the releases and such. > The ZooKeeper build is almost vanilla except for the jute compiler bits. > Things that would need to change are: > * re-organize the source tree a little so that it uses the maven directory > conventions > * seperate the jute bits out into seperate modules so that a maven plugin > can be with it > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615764#action_12615764 ] Hiram Chirino commented on ZOOKEEPER-83: Flavio, maven provides a much more standardize build process than ant. Any maven java project has the same directory structure and build/release procedure. Therefore new contributors who are familiar with maven will be more comfortable contributing to ZooKeeper because of it. It handles lots of the wonky ASF relase rules like: * GPG sighing * staging release artifacts to get voted on. * building binary distros with api docs * building source distros * including and verifying LICENSE and NOTICE files are in all jars * It can run the rat tool for you to verify that all source files have the right headers on them It encourages folks to use your project * It deploys your jar artifacts to a centralized maven repository where other projects can automatically pull your libs into their builds. * the maven repo is a sort of eco system, where if your artifacts are available in it, folks are more willing to use your stuff, and they in turn pubish artifacts the depend on ZooKeeper which in turn might get used by someone else who transitively gets ZooKeeper * It encourages good release patterns like including the version number in the jar. Nice to have so that when folks use your jars it is obvious what version they are using. It encourages good modularization/decoupling: * It's easy to add additional jars to the project and then add dependencies between them. This encourage folks to decouple their code properly. * Once you have a nicely modular project, it easy for folks to add additional optional modules for new features. For example I could see folks wanting a zookeeper-spring module. Plus it does lots of useful things like: * generate IDE project files so that they don't need to be manually maintained. * it can enforce checkstyle rules if desired * Runs findbugs and cobertura * It can creates great set of cross indexed html docs about the build including Plus since it's declarative in a nature, folks can use other maven plugins against the build (without changing the build files) to access additional interesting features. Maven in general is more higher level concept than ANT. It brings power and flexibility to the table. Plus it's the direction most new java projects are taking these days. So I think the question really is why keep ANT? > Switch to using maven to build ZooKeeper > > > Key: ZOOKEEPER-83 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Attachments: zookeeper-mavened.tgz > > > Maven is a great too for building java projects at the ASF. It helps > standardize the build a bit since it's a convention oriented. > It's dependency auto downloading would remove the need to store the > dependencies in svn, and it will handle many of the suggested ASF policies > like gpg signing of the releases and such. > The ZooKeeper build is almost vanilla except for the jute compiler bits. > Things that would need to change are: > * re-organize the source tree a little so that it uses the maven directory > conventions > * seperate the jute bits out into seperate modules so that a maven plugin > can be with it > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-81) JMX module is using 1 java 6 method that has a java 5 equivalent
[ https://issues.apache.org/jira/browse/ZOOKEEPER-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615749#action_12615749 ] Hiram Chirino commented on ZOOKEEPER-81: Sure.. could we get this patch committed first? I really do fail to see what harm could come from it being committed. > JMX module is using 1 java 6 method that has a java 5 equivalent > > > Key: ZOOKEEPER-81 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-81 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino >Assignee: Andrew Kornev > Attachments: ZOOKEEPER-81.patch > > > It would be nice if the jmx module compiled and ran on java 5 too. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-81) JMX module is using 1 java 6 method that has a java 5 equivalent
[ https://issues.apache.org/jira/browse/ZOOKEEPER-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615719#action_12615719 ] Hiram Chirino commented on ZOOKEEPER-81: Furthermore, I've been looking at your the MXBean interfaces and I don't see them being actual MXBeans.. they are just standard MBeans. They would only be MXBeans if the methods they defined used complex object types as parameters or return values. Are you sure that you even have a Java 6 runtime dependency? > JMX module is using 1 java 6 method that has a java 5 equivalent > > > Key: ZOOKEEPER-81 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-81 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino >Assignee: Andrew Kornev > Attachments: ZOOKEEPER-81.patch > > > It would be nice if the jmx module compiled and ran on java 5 too. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-81) JMX module is using 1 java 6 method that has a java 5 equivalent
[ https://issues.apache.org/jira/browse/ZOOKEEPER-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615711#action_12615711 ] Hiram Chirino commented on ZOOKEEPER-81: lol.. I don't understand the aversion to the patch. it changes NOTHING significant and lets the module compile under java 1.5 have you seen that it just changes ONE line? it changes "s.isEmpty()" to "s.length()==0" please commit. > JMX module is using 1 java 6 method that has a java 5 equivalent > > > Key: ZOOKEEPER-81 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-81 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino >Assignee: Andrew Kornev > Attachments: ZOOKEEPER-81.patch > > > It would be nice if the jmx module compiled and ran on java 5 too. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-78) added a high level protocol/feature - for easy Leader Election or exclusive Write Lock creation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615628#action_12615628 ] Hiram Chirino commented on ZOOKEEPER-78: If possible, it might be nice if the WriteLock implemented the [Lock|http://java.sun.com/j2se/1.5.0/docs/api/java/util/concurrent/locks/Lock.html] interface. > added a high level protocol/feature - for easy Leader Election or exclusive > Write Lock creation > --- > > Key: ZOOKEEPER-78 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-78 > Project: Zookeeper > Issue Type: New Feature > Components: java client >Affects Versions: 3.0.0 >Reporter: james strachan >Assignee: james strachan > Attachments: writeLock_protocol_version3.patch > > > Here's a patch which adds a little WriteLock helper class for performing > leader elections or creating exclusive locks in some directory znode. Note > its an early cut; am sure we can improve it over time. The aim is to avoid > folks having to use the low level ZK stuff but provide a simpler high level > abstraction. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-81) JMX module is using 1 java 6 method that has a java 5 equivalent
[ https://issues.apache.org/jira/browse/ZOOKEEPER-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615623#action_12615623 ] Hiram Chirino commented on ZOOKEEPER-81: Java 1.5 can compile this for sure with the given patch. > JMX module is using 1 java 6 method that has a java 5 equivalent > > > Key: ZOOKEEPER-81 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-81 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino >Assignee: Andrew Kornev > Attachments: ZOOKEEPER-81.patch > > > It would be nice if the jmx module compiled and ran on java 5 too. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615620#action_12615620 ] Hiram Chirino commented on ZOOKEEPER-83: James, I think you missed it but, the build dues include a module to create a uber-jar, look at the zookeeper-all module. This creates a jar with all the runtime dependencies needed to run a zookeeper server (yes this includes log4j). > Switch to using maven to build ZooKeeper > > > Key: ZOOKEEPER-83 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Attachments: zookeeper-mavened.tgz > > > Maven is a great too for building java projects at the ASF. It helps > standardize the build a bit since it's a convention oriented. > It's dependency auto downloading would remove the need to store the > dependencies in svn, and it will handle many of the suggested ASF policies > like gpg signing of the releases and such. > The ZooKeeper build is almost vanilla except for the jute compiler bits. > Things that would need to change are: > * re-organize the source tree a little so that it uses the maven directory > conventions > * seperate the jute bits out into seperate modules so that a maven plugin > can be with it > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615619#action_12615619 ] Hiram Chirino commented on ZOOKEEPER-83: Besides the re-organization of the directory structures, I added a couple Mojo.java files for to create the maven plugins for the source code generation bits. And I modified the jute and version gen stuff so that you can specify an output directory. Also several files got deleted like all the jar files in the lib dir, and the checked in javacc generated files since maven is now running javacc to generate them from the .jj file. > Switch to using maven to build ZooKeeper > > > Key: ZOOKEEPER-83 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Attachments: zookeeper-mavened.tgz > > > Maven is a great too for building java projects at the ASF. It helps > standardize the build a bit since it's a convention oriented. > It's dependency auto downloading would remove the need to store the > dependencies in svn, and it will handle many of the suggested ASF policies > like gpg signing of the releases and such. > The ZooKeeper build is almost vanilla except for the jute compiler bits. > Things that would need to change are: > * re-organize the source tree a little so that it uses the maven directory > conventions > * seperate the jute bits out into seperate modules so that a maven plugin > can be with it > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615494#action_12615494 ] Hiram Chirino commented on ZOOKEEPER-83: I just attached a mavenized version of ZooKeeper based on rev 677371 I would have provided a patch, but due to the directory re-organizations, it would be too hard to produce and apply. So attached is a full source distro, please evaluate and comment. Hopefully if folks like it, it can be used as a guide. For folks who are new to maven, here is a quick guide: to build: mvn install to clean mvn clean to clean build: mvn clean install to skip tests during a build: mvn install -Dtest=false to create eclipse project files: mvn eclipse:eclipse to create intelij projects files: mvn idea:idea > Switch to using maven to build ZooKeeper > > > Key: ZOOKEEPER-83 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Attachments: zookeeper-mavened.tgz > > > Maven is a great too for building java projects at the ASF. It helps > standardize the build a bit since it's a convention oriented. > It's dependency auto downloading would remove the need to store the > dependencies in svn, and it will handle many of the suggested ASF policies > like gpg signing of the releases and such. > The ZooKeeper build is almost vanilla except for the jute compiler bits. > Things that would need to change are: > * re-organize the source tree a little so that it uses the maven directory > conventions > * seperate the jute bits out into seperate modules so that a maven plugin > can be with it > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper
Switch to using maven to build ZooKeeper Key: ZOOKEEPER-83 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83 Project: Zookeeper Issue Type: Improvement Components: build Reporter: Hiram Chirino Assignee: Hiram Chirino Attachments: zookeeper-mavened.tgz Maven is a great too for building java projects at the ASF. It helps standardize the build a bit since it's a convention oriented. It's dependency auto downloading would remove the need to store the dependencies in svn, and it will handle many of the suggested ASF policies like gpg signing of the releases and such. The ZooKeeper build is almost vanilla except for the jute compiler bits. Things that would need to change are: * re-organize the source tree a little so that it uses the maven directory conventions * seperate the jute bits out into seperate modules so that a maven plugin can be with it -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino updated ZOOKEEPER-83: --- Attachment: zookeeper-mavened.tgz > Switch to using maven to build ZooKeeper > > > Key: ZOOKEEPER-83 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Attachments: zookeeper-mavened.tgz > > > Maven is a great too for building java projects at the ASF. It helps > standardize the build a bit since it's a convention oriented. > It's dependency auto downloading would remove the need to store the > dependencies in svn, and it will handle many of the suggested ASF policies > like gpg signing of the releases and such. > The ZooKeeper build is almost vanilla except for the jute compiler bits. > Things that would need to change are: > * re-organize the source tree a little so that it uses the maven directory > conventions > * seperate the jute bits out into seperate modules so that a maven plugin > can be with it > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-82) Make the ZooKeeperServer more DI friendly
[
https://issues.apache.org/jira/browse/ZOOKEEPER-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615381#action_12615381
]
Hiram Chirino commented on ZOOKEEPER-82:
While implementing this.. some smelly issues kinda poped out at me.
The jmx stuff wants to be able to access the client port, to avoid tight
coupling the jmx stuff to the ServerConfig stuff, I added a clientPort field to
the ZKServer. Now that seems a little smelly cause I can imagine that the
ZKServer could in theory one day be extended to operate on multiple ports.
In QuorumPeer, the constructor used to initialize sockets and other usefull
bits. To support setter based injection, I moved this initialization to the
start() method, so that users can:
{code}
QuorumPeer qp = new QuorumPeer();
qp.setDataLogDir( dir );
// more setter injection
qp.start();
{code}
The big difference is that QuorumPeer used to throw an IOException if the
initialization failed, now that exception occurs on qp.start() instead and it
is wrapped up as a RuntimeException since it's extending the Thread.start()
method which does not allow IOExceptions to be thrown.
Perhaps QuorumPeer should implement Runnable instead of extending Thread so
that a start() method can be defined which does have the right signature.
> Make the ZooKeeperServer more DI friendly
> -
>
> Key: ZOOKEEPER-82
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-82
> Project: Zookeeper
> Issue Type: Improvement
> Components: server
>Reporter: Hiram Chirino
> Attachments: ZOOKEEPER-82.patch
>
>
> Proposed changes were discussed in [this mailing list
> thread|http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/200807.mbox/[EMAIL
> PROTECTED]:
> Basic goals are:
> * Decouple the current configuration system from the public API. I
> see stuff like ZooKeeperServer being coupled to ServerConfig a bit.
> * Allow the use of setter injection in addition to constructor
> injection. This is the most important thing needed to let spring more
> easily configure the objects.
> * Move the main() methods out of the ZooKeeperServer class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-82) Make the ZooKeeperServer more DI friendly
[ https://issues.apache.org/jira/browse/ZOOKEEPER-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino updated ZOOKEEPER-82: --- Attachment: ZOOKEEPER-82.patch Attaching patch that implements most of what was proposed. > Make the ZooKeeperServer more DI friendly > - > > Key: ZOOKEEPER-82 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-82 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino > Attachments: ZOOKEEPER-82.patch > > > Proposed changes were discussed in [this mailing list > thread|http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/200807.mbox/[EMAIL > PROTECTED]: > Basic goals are: > * Decouple the current configuration system from the public API. I > see stuff like ZooKeeperServer being coupled to ServerConfig a bit. > * Allow the use of setter injection in addition to constructor > injection. This is the most important thing needed to let spring more > easily configure the objects. > * Move the main() methods out of the ZooKeeperServer class. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-82) Make the ZooKeeperServer more DI friendly
Make the ZooKeeperServer more DI friendly - Key: ZOOKEEPER-82 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-82 Project: Zookeeper Issue Type: Improvement Components: server Reporter: Hiram Chirino Proposed changes were discussed in [this mailing list thread|http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/200807.mbox/[EMAIL PROTECTED]: Basic goals are: * Decouple the current configuration system from the public API. I see stuff like ZooKeeperServer being coupled to ServerConfig a bit. * Allow the use of setter injection in addition to constructor injection. This is the most important thing needed to let spring more easily configure the objects. * Move the main() methods out of the ZooKeeperServer class. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-81) JMX module is using 1 java 6 method that has a java 5 equivalent
[ https://issues.apache.org/jira/browse/ZOOKEEPER-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615370#action_12615370 ] Hiram Chirino commented on ZOOKEEPER-81: The build lets me build under 1.5 and if I apply that patch it compiles and tests fine. Perhaps that mxbean feature is only needed at runtime? > JMX module is using 1 java 6 method that has a java 5 equivalent > > > Key: ZOOKEEPER-81 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-81 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino > Attachments: ZOOKEEPER-81.patch > > > It would be nice if the jmx module compiled and ran on java 5 too. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-81) JMX module is using 1 java 6 method that has a java 5 equivalent
JMX module is using 1 java 6 method that has a java 5 equivalent Key: ZOOKEEPER-81 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-81 Project: Zookeeper Issue Type: Improvement Components: server Reporter: Hiram Chirino Attachments: ZOOKEEPER-81.patch It would be nice if the jmx module compiled and ran on java 5 too. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-81) JMX module is using 1 java 6 method that has a java 5 equivalent
[
https://issues.apache.org/jira/browse/ZOOKEEPER-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hiram Chirino updated ZOOKEEPER-81:
---
Status: Patch Available (was: Open)
{code}
Index: src/java/jmx/org/apache/zookeeper/jmx/MBeanRegistry.java
===
--- src/java/jmx/org/apache/zookeeper/jmx/MBeanRegistry.java(revision
677957)
+++ src/java/jmx/org/apache/zookeeper/jmx/MBeanRegistry.java(working copy)
@@ -143,7 +143,7 @@
private int tokenize(StringBuilder sb, String path, int index){
String[] tokens = path.split("/");
for (String s: tokens) {
-if (s.isEmpty())
+if (s.length()==0)
continue;
sb.append("name").append(index++)
.append("=").append(s).append(",");
{code}
> JMX module is using 1 java 6 method that has a java 5 equivalent
>
>
> Key: ZOOKEEPER-81
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-81
> Project: Zookeeper
> Issue Type: Improvement
> Components: server
>Reporter: Hiram Chirino
> Attachments: ZOOKEEPER-81.patch
>
>
> It would be nice if the jmx module compiled and ran on java 5 too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-81) JMX module is using 1 java 6 method that has a java 5 equivalent
[ https://issues.apache.org/jira/browse/ZOOKEEPER-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiram Chirino updated ZOOKEEPER-81: --- Attachment: ZOOKEEPER-81.patch attaching patch for the fix. > JMX module is using 1 java 6 method that has a java 5 equivalent > > > Key: ZOOKEEPER-81 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-81 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino > Attachments: ZOOKEEPER-81.patch > > > It would be nice if the jmx module compiled and ran on java 5 too. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
