[jira] Commented: (ZOOKEEPER-214) add new stat reset command to server admin port

2008-12-24 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12659086#action_12659086
 ] 

Hudson commented on ZOOKEEPER-214:
--

Integrated in ZooKeeper-trunk #182 (See 
[http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/182/])
. add new stat reset command to server admin port. (pat via mahadev)


 add new stat reset command to server admin port
 -

 Key: ZOOKEEPER-214
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-214
 Project: Zookeeper
  Issue Type: Improvement
  Components: server
Reporter: Patrick Hunt
Assignee: Patrick Hunt
 Fix For: 3.1.0

 Attachments: ZOOKEEPER-214.patch, ZOOKEEPER-214_1.patch


 A new command should be added to the server admin port (client port) that 
 allows users to reset the stats.
 We saw cases during troubleshooting where we would have liked to reset the 
 min/avg/max latency stats, but were unable to do so (short of restarting 
 the server).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-214) add new stat reset command to server admin port

2008-12-23 Thread Patrick Hunt (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12658905#action_12658905
 ] 

Patrick Hunt commented on ZOOKEEPER-214:


We have docs in forrest for each of these detailing what they do (although not 
nec. detail on what information they provide)
It would be good to keep the docs in forrest as much as possible, of course add 
implementation specific detail to he java/javadoc, but in a case like this the 
java/javadoc should probably point to the forrest docs (ie. trunk/docs/...)

 add new stat reset command to server admin port
 -

 Key: ZOOKEEPER-214
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-214
 Project: Zookeeper
  Issue Type: Improvement
  Components: server
Reporter: Patrick Hunt
Assignee: Patrick Hunt
 Fix For: 3.1.0

 Attachments: ZOOKEEPER-214.patch


 A new command should be added to the server admin port (client port) that 
 allows users to reset the stats.
 We saw cases during troubleshooting where we would have liked to reset the 
 min/avg/max latency stats, but were unable to do so (short of restarting 
 the server).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-214) add new stat reset command to server admin port

2008-12-22 Thread Mahadev konar (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12658723#action_12658723
 ] 

Mahadev konar commented on ZOOKEEPER-214:
-

+1 the patch looks good... just a nit... 

 final static int enviCmd = ByteBuffer.wrap(envi.getBytes()).getInt();
 
+final static int srstCmd = ByteBuffer.wrap(srst.getBytes()).getInt();
+
 final static ByteBuffer imok = ByteBuffer.wrap(imok.getBytes());

itll be good to add javadoc for all these vars. Ill add some javadoc and then 
commit... 

 add new stat reset command to server admin port
 -

 Key: ZOOKEEPER-214
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-214
 Project: Zookeeper
  Issue Type: Improvement
  Components: server
Reporter: Patrick Hunt
Assignee: Patrick Hunt
 Fix For: 3.1.0

 Attachments: ZOOKEEPER-214.patch


 A new command should be added to the server admin port (client port) that 
 allows users to reset the stats.
 We saw cases during troubleshooting where we would have liked to reset the 
 min/avg/max latency stats, but were unable to do so (short of restarting 
 the server).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.