[jira] Updated: (ZOOKEEPER-5) Upgrade Feature in Zookeeper server.

2008-10-16 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-5:
-

  Resolution: Fixed
Hadoop Flags: [Reviewed]
  Status: Resolved  (was: Patch Available)

Committed revision 705421.
Committed revision 705424.


> Upgrade Feature in Zookeeper server.
> 
>
> Key: ZOOKEEPER-5
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-5
> Project: Zookeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Mahadev konar
>Assignee: Mahadev konar
> Fix For: 3.0.0
>
> Attachments: log.10001, log.11bf0, snapshot.1, 
> snapshot.11bec, ZOOKEEPER-5.patch, ZOOKEEPER-5.patch, ZOOKEEPER-5.patch, 
> ZOOKEEPER-5.patch, ZOOKEEPER-5.patch, ZOOKEEPER-5.patch
>
>
> We need an upgrade feature in zookeeper where we can upgrade the old 
> databases to a new one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-5) Upgrade Feature in Zookeeper server.

2008-10-16 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-5:
--

Attachment: ZOOKEEPER-5.patch

updated the patc hwith pat's comments...


> Upgrade Feature in Zookeeper server.
> 
>
> Key: ZOOKEEPER-5
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-5
> Project: Zookeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Mahadev konar
>Assignee: Mahadev konar
> Fix For: 3.0.0
>
> Attachments: log.10001, log.11bf0, snapshot.1, 
> snapshot.11bec, ZOOKEEPER-5.patch, ZOOKEEPER-5.patch, ZOOKEEPER-5.patch, 
> ZOOKEEPER-5.patch, ZOOKEEPER-5.patch, ZOOKEEPER-5.patch
>
>
> We need an upgrade feature in zookeeper where we can upgrade the old 
> databases to a new one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-5) Upgrade Feature in Zookeeper server.

2008-10-16 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-5:
--

Status: Patch Available  (was: Open)

> Upgrade Feature in Zookeeper server.
> 
>
> Key: ZOOKEEPER-5
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-5
> Project: Zookeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Mahadev konar
>Assignee: Mahadev konar
> Fix For: 3.0.0
>
> Attachments: log.10001, log.11bf0, snapshot.1, 
> snapshot.11bec, ZOOKEEPER-5.patch, ZOOKEEPER-5.patch, ZOOKEEPER-5.patch, 
> ZOOKEEPER-5.patch, ZOOKEEPER-5.patch, ZOOKEEPER-5.patch
>
>
> We need an upgrade feature in zookeeper where we can upgrade the old 
> databases to a new one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-5) Upgrade Feature in Zookeeper server.

2008-10-16 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-5:
-

Status: Open  (was: Patch Available)

In general I'm +1 on this patch with the following changes:

1) update Upgrade.main to catch any exception (throwable?) and log it before 
exiting. This will ensure we have the issue captured in the log.
2) log the creation of directories, coping of files... renaming, etc...
3) log the various stages of the "runUpgrade" method, ie aftereach step log 
success of step.

I can't tell you how many times I've run into cases where an upgrade fails and 
having this type if information (being able to determine with finer granularity 
what is happening for the customer) would be useful.

I would also suggest that you change Upgrade.java to UpgradeMain.java to be 
consistent w/ the rest of the main utils in zk core.



> Upgrade Feature in Zookeeper server.
> 
>
> Key: ZOOKEEPER-5
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-5
> Project: Zookeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Mahadev konar
>Assignee: Mahadev konar
> Fix For: 3.0.0
>
> Attachments: log.10001, log.11bf0, snapshot.1, 
> snapshot.11bec, ZOOKEEPER-5.patch, ZOOKEEPER-5.patch, ZOOKEEPER-5.patch, 
> ZOOKEEPER-5.patch, ZOOKEEPER-5.patch
>
>
> We need an upgrade feature in zookeeper where we can upgrade the old 
> databases to a new one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-5) Upgrade Feature in Zookeeper server.

2008-10-16 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-5:
--

Attachment: ZOOKEEPER-5.patch

updated patch after removing a few unused methods.

> Upgrade Feature in Zookeeper server.
> 
>
> Key: ZOOKEEPER-5
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-5
> Project: Zookeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Mahadev konar
>Assignee: Mahadev konar
> Fix For: 3.0.0
>
> Attachments: log.10001, log.11bf0, snapshot.1, 
> snapshot.11bec, ZOOKEEPER-5.patch, ZOOKEEPER-5.patch, ZOOKEEPER-5.patch, 
> ZOOKEEPER-5.patch, ZOOKEEPER-5.patch
>
>
> We need an upgrade feature in zookeeper where we can upgrade the old 
> databases to a new one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-5) Upgrade Feature in Zookeeper server.

2008-10-16 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-5:
--

Status: Patch Available  (was: Open)

> Upgrade Feature in Zookeeper server.
> 
>
> Key: ZOOKEEPER-5
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-5
> Project: Zookeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Mahadev konar
>Assignee: Mahadev konar
> Fix For: 3.0.0
>
> Attachments: log.10001, log.11bf0, snapshot.1, 
> snapshot.11bec, ZOOKEEPER-5.patch, ZOOKEEPER-5.patch, ZOOKEEPER-5.patch, 
> ZOOKEEPER-5.patch
>
>
> We need an upgrade feature in zookeeper where we can upgrade the old 
> databases to a new one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-5) Upgrade Feature in Zookeeper server.

2008-10-16 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-5:
--

Attachment: snapshot.1

> Upgrade Feature in Zookeeper server.
> 
>
> Key: ZOOKEEPER-5
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-5
> Project: Zookeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Mahadev konar
>Assignee: Mahadev konar
> Fix For: 3.0.0
>
> Attachments: log.10001, log.11bf0, snapshot.1, 
> snapshot.11bec, ZOOKEEPER-5.patch, ZOOKEEPER-5.patch, ZOOKEEPER-5.patch, 
> ZOOKEEPER-5.patch
>
>
> We need an upgrade feature in zookeeper where we can upgrade the old 
> databases to a new one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-5) Upgrade Feature in Zookeeper server.

2008-10-16 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-5:
--

Attachment: snapshot.11bec

> Upgrade Feature in Zookeeper server.
> 
>
> Key: ZOOKEEPER-5
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-5
> Project: Zookeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Mahadev konar
>Assignee: Mahadev konar
> Fix For: 3.0.0
>
> Attachments: log.10001, log.11bf0, snapshot.1, 
> snapshot.11bec, ZOOKEEPER-5.patch, ZOOKEEPER-5.patch, ZOOKEEPER-5.patch, 
> ZOOKEEPER-5.patch
>
>
> We need an upgrade feature in zookeeper where we can upgrade the old 
> databases to a new one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-5) Upgrade Feature in Zookeeper server.

2008-10-16 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-5:
--

Attachment: log.10001

> Upgrade Feature in Zookeeper server.
> 
>
> Key: ZOOKEEPER-5
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-5
> Project: Zookeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Mahadev konar
>Assignee: Mahadev konar
> Fix For: 3.0.0
>
> Attachments: log.10001, log.11bf0, snapshot.1, 
> snapshot.11bec, ZOOKEEPER-5.patch, ZOOKEEPER-5.patch, ZOOKEEPER-5.patch, 
> ZOOKEEPER-5.patch
>
>
> We need an upgrade feature in zookeeper where we can upgrade the old 
> databases to a new one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-5) Upgrade Feature in Zookeeper server.

2008-10-16 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-5:
--

Attachment: log.11bf0

> Upgrade Feature in Zookeeper server.
> 
>
> Key: ZOOKEEPER-5
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-5
> Project: Zookeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Mahadev konar
>Assignee: Mahadev konar
> Fix For: 3.0.0
>
> Attachments: log.11bf0, ZOOKEEPER-5.patch, ZOOKEEPER-5.patch, 
> ZOOKEEPER-5.patch, ZOOKEEPER-5.patch
>
>
> We need an upgrade feature in zookeeper where we can upgrade the old 
> databases to a new one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-5) Upgrade Feature in Zookeeper server.

2008-10-16 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-5:
--

Attachment: ZOOKEEPER-5.patch

this patch includes tests and fixes issues pointed by ben... This patch 
requires binary files to be added to svn repo under 
src/java/test/data/upgrade/. I am uploading the files seperately from the patch.

> Upgrade Feature in Zookeeper server.
> 
>
> Key: ZOOKEEPER-5
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-5
> Project: Zookeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Mahadev konar
>Assignee: Mahadev konar
> Fix For: 3.0.0
>
> Attachments: log.11bf0, ZOOKEEPER-5.patch, ZOOKEEPER-5.patch, 
> ZOOKEEPER-5.patch, ZOOKEEPER-5.patch
>
>
> We need an upgrade feature in zookeeper where we can upgrade the old 
> databases to a new one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-5) Upgrade Feature in Zookeeper server.

2008-10-16 Thread Benjamin Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Reed updated ZOOKEEPER-5:
--

Status: Open  (was: Patch Available)

-1 SnapshotUpgradeV1 should be UpgradeSnapshotV1 since it implements 
SnapshotUpgrade. createThisSnapshot should be renamed since it doesn't create a 
snapshot. loadOldDataTree maybe? PersistentStat is going to be changing, so 
convertDataNode will need to be able to take the old version. Finally, you need 
test cases.

> Upgrade Feature in Zookeeper server.
> 
>
> Key: ZOOKEEPER-5
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-5
> Project: Zookeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Mahadev konar
>Assignee: Mahadev konar
> Fix For: 3.0.0
>
> Attachments: ZOOKEEPER-5.patch, ZOOKEEPER-5.patch, ZOOKEEPER-5.patch
>
>
> We need an upgrade feature in zookeeper where we can upgrade the old 
> databases to a new one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-5) Upgrade Feature in Zookeeper server.

2008-10-15 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-5:
--

Status: Patch Available  (was: Open)

> Upgrade Feature in Zookeeper server.
> 
>
> Key: ZOOKEEPER-5
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-5
> Project: Zookeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Mahadev konar
>Assignee: Mahadev konar
> Fix For: 3.0.0
>
> Attachments: ZOOKEEPER-5.patch, ZOOKEEPER-5.patch, ZOOKEEPER-5.patch
>
>
> We need an upgrade feature in zookeeper where we can upgrade the old 
> databases to a new one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-5) Upgrade Feature in Zookeeper server.

2008-10-15 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-5:
--

Attachment: ZOOKEEPER-5.patch

latest patch with bug fixes.

> Upgrade Feature in Zookeeper server.
> 
>
> Key: ZOOKEEPER-5
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-5
> Project: Zookeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Mahadev konar
>Assignee: Mahadev konar
> Fix For: 3.0.0
>
> Attachments: ZOOKEEPER-5.patch, ZOOKEEPER-5.patch, ZOOKEEPER-5.patch
>
>
> We need an upgrade feature in zookeeper where we can upgrade the old 
> databases to a new one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-5) Upgrade Feature in Zookeeper server.

2008-10-14 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-5:
--

Attachment: ZOOKEEPER-5.patch

this is a patch that fixes a few bugs in the previous one.. 


the usage of running upgrade is 
bin/zkserver.sh upgrade datadir snapshotdir

if you are not using shell scripts then its 

java -cp log4j.jar:zookeepr.jar org.apache.zookeeper.server.upgrade.Upgrade 
dataDir snapshotDir.

I am still in testing it but it would be great if someone could take a look at 
it  

The patch does this:

1) takes the input datadir and snapshot dir
2) baks up the datadir in datadir/version-1 and snapshotdir in 
snapshotdir/version-1
3) creates directory datadir/version-2 and snapshotdir/version-2
4) reads the snapshots and txns from version-1 dir
5) creates an old datatree in memory
6) converts that old datatree to a new datatree
7) creates a new snapshot
8) done

> Upgrade Feature in Zookeeper server.
> 
>
> Key: ZOOKEEPER-5
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-5
> Project: Zookeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Mahadev konar
>Assignee: Mahadev konar
> Fix For: 3.0.0
>
> Attachments: ZOOKEEPER-5.patch, ZOOKEEPER-5.patch
>
>
> We need an upgrade feature in zookeeper where we can upgrade the old 
> databases to a new one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-5) Upgrade Feature in Zookeeper server.

2008-10-14 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-5:
--

Attachment: ZOOKEEPER-5.patch

this is a preview patch... needs testing and some cleaning up. 

> Upgrade Feature in Zookeeper server.
> 
>
> Key: ZOOKEEPER-5
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-5
> Project: Zookeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Mahadev konar
>Assignee: Mahadev konar
> Fix For: 3.0.0
>
> Attachments: ZOOKEEPER-5.patch
>
>
> We need an upgrade feature in zookeeper where we can upgrade the old 
> databases to a new one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.