[jira] Commented: (ZOOKEEPER-356) Masking bookie failure during writes to a ledger
[ https://issues.apache.org/jira/browse/ZOOKEEPER-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723546#action_12723546 ] Hudson commented on ZOOKEEPER-356: -- Integrated in ZooKeeper-trunk #356 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/356/]) . Masking bookie failure during writes to a ledger > Masking bookie failure during writes to a ledger > > > Key: ZOOKEEPER-356 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-356 > Project: Zookeeper > Issue Type: Improvement > Components: contrib-bookkeeper >Reporter: Flavio Paiva Junqueira >Assignee: Flavio Paiva Junqueira > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, > ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, > ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, > ZOOKEEPER-BOOKKEEPER-356.patch > > > The idea of this jira is to work out the changes necessary to make a client > mask the failure of a bookie while writing to a ledger. I'm submitting a > preliminary patch, but before I submit a final one, I need to have 288 > committed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-356) Masking bookie failure during writes to a ledger
[ https://issues.apache.org/jira/browse/ZOOKEEPER-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723191#action_12723191 ] Flavio Paiva Junqueira commented on ZOOKEEPER-356: -- Thanks, Ben. Here are my answers to your concerns: # If we set stop to true, then the STOP signal (issued from sendStop()) will never be processed; # I have checked them, and changed some. Please let me know if you still see any that is not ok; # Done; # It is not necessary, we only add in the beginning, when opening or creating a ledger, and we remove while adding entries to a ledger, after creating a ledger; # Done. It slows the client down significantly, though; # Done. [ Show ยป ] Benjamin Reed added a comment - 23/Jun/09 09:03 AM just a couple of things: * in BookieHandle, why doesn't stop get set to true on shutdown? * you need to check all your uses of LOG.info most of them seem to really be LOG.debug * in ClientCBWorker stop should be volatile * in LedgerHandle shouldn't add/removeBookie be synchronized? * in QuorumEngine should idCounter be synchronized? * In BookieClient you do a new IOException(), you should provide some hint of the problem in the constructor > Masking bookie failure during writes to a ledger > > > Key: ZOOKEEPER-356 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-356 > Project: Zookeeper > Issue Type: New Feature > Components: contrib-bookkeeper >Reporter: Flavio Paiva Junqueira >Assignee: Flavio Paiva Junqueira > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, > ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, > ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, ZOOKEEPER-BOOKKEEPER-356.patch > > > The idea of this jira is to work out the changes necessary to make a client > mask the failure of a bookie while writing to a ledger. I'm submitting a > preliminary patch, but before I submit a final one, I need to have 288 > committed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-356) Masking bookie failure during writes to a ledger
[ https://issues.apache.org/jira/browse/ZOOKEEPER-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723150#action_12723150 ] Benjamin Reed commented on ZOOKEEPER-356: - just a couple of things: * in BookieHandle, why doesn't stop get set to true on shutdown? * you need to check all your uses of LOG.info most of them seem to really be LOG.debug * in ClientCBWorker stop should be volatile * in LedgerHandle shouldn't add/removeBookie be synchronized? * in QuorumEngine should idCounter be synchronized? * In BookieClient you do a new IOException(), you should provide some hint of the problem in the constructor > Masking bookie failure during writes to a ledger > > > Key: ZOOKEEPER-356 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-356 > Project: Zookeeper > Issue Type: New Feature > Components: contrib-bookkeeper >Reporter: Flavio Paiva Junqueira >Assignee: Flavio Paiva Junqueira > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, > ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, > ZOOKEEPER-356.patch, ZOOKEEPER-BOOKKEEPER-356.patch > > > The idea of this jira is to work out the changes necessary to make a client > mask the failure of a bookie while writing to a ledger. I'm submitting a > preliminary patch, but before I submit a final one, I need to have 288 > committed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-356) Masking bookie failure during writes to a ledger
[ https://issues.apache.org/jira/browse/ZOOKEEPER-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721743#action_12721743 ] Hadoop QA commented on ZOOKEEPER-356: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12411198/ZOOKEEPER-356.patch against trunk revision 786317. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 18 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/126/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/126/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/126/console This message is automatically generated. > Masking bookie failure during writes to a ledger > > > Key: ZOOKEEPER-356 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-356 > Project: Zookeeper > Issue Type: New Feature > Components: contrib-bookkeeper >Reporter: Flavio Paiva Junqueira >Assignee: Flavio Paiva Junqueira > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, > ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, > ZOOKEEPER-356.patch, ZOOKEEPER-BOOKKEEPER-356.patch > > > The idea of this jira is to work out the changes necessary to make a client > mask the failure of a bookie while writing to a ledger. I'm submitting a > preliminary patch, but before I submit a final one, I need to have 288 > committed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-356) Masking bookie failure during writes to a ledger
[ https://issues.apache.org/jira/browse/ZOOKEEPER-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717470#action_12717470 ] Hadoop QA commented on ZOOKEEPER-356: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12410019/ZOOKEEPER-356.patch against trunk revision 782792. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 18 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/104/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/104/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/104/console This message is automatically generated. > Masking bookie failure during writes to a ledger > > > Key: ZOOKEEPER-356 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-356 > Project: Zookeeper > Issue Type: New Feature > Components: contrib-bookkeeper >Reporter: Flavio Paiva Junqueira >Assignee: Flavio Paiva Junqueira > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, > ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, > ZOOKEEPER-BOOKKEEPER-356.patch > > > The idea of this jira is to work out the changes necessary to make a client > mask the failure of a bookie while writing to a ledger. I'm submitting a > preliminary patch, but before I submit a final one, I need to have 288 > committed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-356) Masking bookie failure during writes to a ledger
[ https://issues.apache.org/jira/browse/ZOOKEEPER-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716907#action_12716907 ] Flavio Paiva Junqueira commented on ZOOKEEPER-356: -- You might want to take a look at "org.apache.bookkeeper.client.BKDefs.java" for the ZooKeeper paths we use. > Masking bookie failure during writes to a ledger > > > Key: ZOOKEEPER-356 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-356 > Project: Zookeeper > Issue Type: New Feature > Components: contrib-bookkeeper >Reporter: Flavio Paiva Junqueira >Assignee: Flavio Paiva Junqueira > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, > ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, > ZOOKEEPER-BOOKKEEPER-356.patch > > > The idea of this jira is to work out the changes necessary to make a client > mask the failure of a bookie while writing to a ledger. I'm submitting a > preliminary patch, but before I submit a final one, I need to have 288 > committed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-356) Masking bookie failure during writes to a ledger
[ https://issues.apache.org/jira/browse/ZOOKEEPER-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716793#action_12716793 ] Benjamin Reed commented on ZOOKEEPER-356: - flavio is the zookeeper layout of bookkeeper documented somewhere? it would help a lot with the review. > Masking bookie failure during writes to a ledger > > > Key: ZOOKEEPER-356 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-356 > Project: Zookeeper > Issue Type: New Feature > Components: contrib-bookkeeper >Reporter: Flavio Paiva Junqueira >Assignee: Flavio Paiva Junqueira > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, > ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, > ZOOKEEPER-BOOKKEEPER-356.patch > > > The idea of this jira is to work out the changes necessary to make a client > mask the failure of a bookie while writing to a ledger. I'm submitting a > preliminary patch, but before I submit a final one, I need to have 288 > committed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-356) Masking bookie failure during writes to a ledger
[ https://issues.apache.org/jira/browse/ZOOKEEPER-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716670#action_12716670 ] Flavio Paiva Junqueira commented on ZOOKEEPER-356: -- It was a pretty stupid idea to use a static array of instances for QuorumOpMonitor. That was causing my new test to fail when trying to run multiple times (nothing to do with the test, just that it was keeping instances across runs). Now I'm able to run the failure test four times, failing each time a different bookie. > Masking bookie failure during writes to a ledger > > > Key: ZOOKEEPER-356 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-356 > Project: Zookeeper > Issue Type: New Feature > Components: contrib-bookkeeper >Reporter: Flavio Paiva Junqueira >Assignee: Flavio Paiva Junqueira > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, > ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, ZOOKEEPER-BOOKKEEPER-356.patch > > > The idea of this jira is to work out the changes necessary to make a client > mask the failure of a bookie while writing to a ledger. I'm submitting a > preliminary patch, but before I submit a final one, I need to have 288 > committed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
