[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723191#action_12723191
 ] 

Flavio Paiva Junqueira commented on ZOOKEEPER-356:
--------------------------------------------------

Thanks, Ben. Here are my answers to your concerns:

# If we set stop to true, then the STOP signal (issued from sendStop()) will 
never be processed;
# I have checked them, and changed some. Please let me know if you still see 
any that is not ok;
# Done;
# It is not necessary, we only add in the beginning, when opening or creating a 
ledger, and we remove while adding entries to a ledger, after creating a ledger;
# Done. It slows the client down significantly, though;
# Done.

[ Show ยป ]
Benjamin Reed added a comment - 23/Jun/09 09:03 AM just a couple of things:

    * in BookieHandle, why doesn't stop get set to true on shutdown?
    * you need to check all your uses of LOG.info most of them seem to really 
be LOG.debug
    * in ClientCBWorker stop should be volatile
    * in LedgerHandle shouldn't add/removeBookie be synchronized?
    * in QuorumEngine should idCounter be synchronized?
    * In BookieClient you do a new IOException(), you should provide some hint 
of the problem in the constructor




> Masking bookie failure during writes to a ledger
> ------------------------------------------------
>
>                 Key: ZOOKEEPER-356
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-356
>             Project: Zookeeper
>          Issue Type: New Feature
>          Components: contrib-bookkeeper
>            Reporter: Flavio Paiva Junqueira
>            Assignee: Flavio Paiva Junqueira
>             Fix For: 3.2.0
>
>         Attachments: ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, 
> ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, 
> ZOOKEEPER-356.patch, ZOOKEEPER-356.patch, ZOOKEEPER-BOOKKEEPER-356.patch
>
>
> The idea of this jira is to work out the changes necessary to make a client 
> mask the failure of a bookie while writing to a ledger. I'm submitting a 
> preliminary patch, but before I submit a final one, I need to have 288 
> committed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to