[jira] Commented: (ZOOKEEPER-636) configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12869057#action_12869057 ] Maxim P. Dementiev commented on ZOOKEEPER-636: -- Thank you, Patrick! I do hope our team (http://mpd-eng.livejournal.com/1159.html) will find an opportunity to continue work on the project and I will do more for ZooKeeper! configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS. - Key: ZOOKEEPER-636 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-636 Project: Zookeeper Issue Type: Improvement Components: build, c client Affects Versions: 3.2.1 Reporter: Maxim P. Dementiev Assignee: Maxim P. Dementiev Fix For: 3.4.0 Attachments: ZOOKEEPER-636.patch The information mustn't be overridden. The template like «CFLAGS=$CFLAGS -some-option» should be used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-636) configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12868574#action_12868574 ] Hadoop QA commented on ZOOKEEPER-636: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12444711/ZOOKEEPER-636.patch against trunk revision 944515. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/96/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/96/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/96/console This message is automatically generated. configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS. - Key: ZOOKEEPER-636 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-636 Project: Zookeeper Issue Type: Improvement Components: build, c client Affects Versions: 3.2.1 Reporter: Maxim P. Dementiev Assignee: Patrick Hunt Fix For: 3.4.0 Attachments: ZOOKEEPER-636.patch The information mustn't be overridden. The template like «CFLAGS=$CFLAGS -some-option» should be used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-636) configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12868297#action_12868297 ] Maxim P. Dementiev commented on ZOOKEEPER-636: -- Sorry for delay. Our project is in trouble (http://mpd-eng.livejournal.com/1159.html). I've changed src/c/Makefile.am: CXXFLAGS should not be overridden. Anyway, I kept some additional options there (AM_CFLAGS = -Wall -Werror and AM_CXXFLAGS = -Wall). I think it must be moved in configure.ac as well. It is possible to parse the contents of CFLAGS and CXXFLAGS variable and to add specific options conditionally (like it is done for example in http://git.gnome.org/browse/gtk+/tree/configure.in?h=gtk-2-18#n320), but we need to define requirements for the platform and tool versions (can we use such a technique or not). configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS. - Key: ZOOKEEPER-636 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-636 Project: Zookeeper Issue Type: Improvement Components: build, c client Affects Versions: 3.2.1 Reporter: Maxim P. Dementiev Assignee: Maxim P. Dementiev Fix For: 3.4.0 Attachments: ZOOKEEPER-636.patch The information mustn't be overridden. The template like «CFLAGS=$CFLAGS -some-option» should be used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-636) configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12868320#action_12868320 ] Hadoop QA commented on ZOOKEEPER-636: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12444711/ZOOKEEPER-636.patch against trunk revision 944515. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/92/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/92/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/92/console This message is automatically generated. configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS. - Key: ZOOKEEPER-636 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-636 Project: Zookeeper Issue Type: Improvement Components: build, c client Affects Versions: 3.2.1 Reporter: Maxim P. Dementiev Assignee: Patrick Hunt Fix For: 3.4.0 Attachments: ZOOKEEPER-636.patch The information mustn't be overridden. The template like «CFLAGS=$CFLAGS -some-option» should be used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-636) configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12868382#action_12868382 ] Maxim P. Dementiev commented on ZOOKEEPER-636: -- And I wonder what does this -1 core tests. The patch failed core unit tests. mean for me? Should I correct something? configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS. - Key: ZOOKEEPER-636 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-636 Project: Zookeeper Issue Type: Improvement Components: build, c client Affects Versions: 3.2.1 Reporter: Maxim P. Dementiev Assignee: Patrick Hunt Fix For: 3.4.0 Attachments: ZOOKEEPER-636.patch The information mustn't be overridden. The template like «CFLAGS=$CFLAGS -some-option» should be used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-636) configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12868393#action_12868393 ] Mahadev konar commented on ZOOKEEPER-636: - maxim, looks like the c tests failed. You can take a look at what failed in http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/92/testReport. This does not look like some problem in the patch. To verify, you can cancel and resubmit to see if the test fails again or not. configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS. - Key: ZOOKEEPER-636 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-636 Project: Zookeeper Issue Type: Improvement Components: build, c client Affects Versions: 3.2.1 Reporter: Maxim P. Dementiev Assignee: Patrick Hunt Fix For: 3.4.0 Attachments: ZOOKEEPER-636.patch The information mustn't be overridden. The template like «CFLAGS=$CFLAGS -some-option» should be used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-636) configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12868395#action_12868395 ] Patrick Hunt commented on ZOOKEEPER-636: Maxim, this is a known issue: [exec] [exec] Zookeeper_simpleSystem::testAuth ZooKeeper server started : elapsed 25448 : OK [exec] [exec] zktest-mt: /grid/0/hudson/hudson-slave/workspace/Zookeeper-Patch-h1.grid.sp2.yahoo.net/trunk/src/c/src/zookeeper.c:1950: zookeeper_process: Assertion `cptr' failed. [exec] [exec] Zookeeper_simpleSystem::testHangingClient try retriggering the build. (cancel/submit) configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS. - Key: ZOOKEEPER-636 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-636 Project: Zookeeper Issue Type: Improvement Components: build, c client Affects Versions: 3.2.1 Reporter: Maxim P. Dementiev Assignee: Patrick Hunt Fix For: 3.4.0 Attachments: ZOOKEEPER-636.patch The information mustn't be overridden. The template like «CFLAGS=$CFLAGS -some-option» should be used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-636) configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12805239#action_12805239 ] Maxim P. Dementiev commented on ZOOKEEPER-636: -- I don't think I'm an autotools expert, but many things have changed since ZOOKEEPER-281. I even posted an article about Autoconf and CppUnit integration in my blog: http://mpd-eng.livejournal.com/700.html I'll do my best to fix this one issue (CFLAGS overriding). And please, fill free to assign to me any autoconf issue (is there corresponding opened issue with cppunit that you've talked about?). configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS. - Key: ZOOKEEPER-636 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-636 Project: Zookeeper Issue Type: Improvement Components: c client Affects Versions: 3.2.1 Reporter: Maxim P. Dementiev Fix For: 3.3.0 The information mustn't be overridden. The template like «CFLAGS=$CFLAGS -some-option» should be used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-636) configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12804621#action_12804621 ] Patrick Hunt commented on ZOOKEEPER-636: @maxim, thanks, that's what I was looking for. Not being an expert at autotools myself it's hard to know what correct behavior is. Do you want to take a shot at this? Also, if you had any other ideas how to make our auto* integration better we'd love to have you submit patches. In particular there's a long standing issue that we require cppunit, if you know how to address this we'd love to have a patch (I assume this would be an option to configure to turn off cppunit being required, obv this would make it impossible to run the tests but at least one could compile). We've tried fixing this issue previously but no luck. Please continue making suggestions, patches would even be better! configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS. - Key: ZOOKEEPER-636 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-636 Project: Zookeeper Issue Type: Improvement Components: c client Affects Versions: 3.2.1 Reporter: Maxim P. Dementiev Fix For: 3.3.0 The information mustn't be overridden. The template like «CFLAGS=$CFLAGS -some-option» should be used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-636) configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12803112#action_12803112 ] Patrick Hunt commented on ZOOKEEPER-636: could you provide a bit more detail of the issue. what's the problem? what issue are you seeing, can you give an example where it's a problem? I tried the following with the current code make CFLAGS=-X and -X was used in compiling the source. Isn't this what we want? configure.ac has instructions which override the contents of CFLAGS and CXXFLAGS. - Key: ZOOKEEPER-636 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-636 Project: Zookeeper Issue Type: Improvement Components: c client Affects Versions: 3.2.1 Reporter: Maxim P. Dementiev Fix For: 3.3.0 The information mustn't be overridden. The template like «CFLAGS=$CFLAGS -some-option» should be used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
