Re: [Zope] Re: Upgrading to Zope 2.9.1
On 3/10/06, Martijn Pieters <[EMAIL PROTECTED]> wrote: > Hmm; I'll investigate if I can reproduce this and see if the same fix > (universal line endings) will solve this too. I strongly suspect the > fix will be just as easy (line 81 of FSPageTemplate.py, add a 'U' to > the file opening flags). The harder bit is the tests.. I checked in a testcase and a fix on the CMF Trunk, and will merge it to the 1.5 and 1.6 branches after lunch. Indeed, universal line endings solve the problem here too. -- Martijn Pieters ___ Zope maillist - Zope@zope.org http://mail.zope.org/mailman/listinfo/zope ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope-dev )
Re: [Zope] Re: Upgrading to Zope 2.9.1
On 3/10/06, Max M <[EMAIL PROTECTED]> wrote: > There has been a bug in Zope since ages, where multiline python in tal > fails if it has Window line endings. > > Eg. this will fail with windows line endings: > > Hmm; I'll investigate if I can reproduce this and see if the same fix (universal line endings) will solve this too. I strongly suspect the fix will be just as easy (line 81 of FSPageTemplate.py, add a 'U' to the file opening flags). The harder bit is the tests.. -- Martijn Pieters ___ Zope maillist - Zope@zope.org http://mail.zope.org/mailman/listinfo/zope ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope-dev )
[Zope] Re: Upgrading to Zope 2.9.1
Chris Withers wrote: Dieter Maurer wrote: It does now -- at least for "FSPythonScripts" when you are on a *nix platform and your files contain DOS lineends. Does this only affect (FS)PythonScripts or all disk based python code? There has been a bug in Zope since ages, where multiline python in tal fails if it has Window line endings. Eg. this will fail with windows line endings: This does not have multiline Python in the tal expression and will not fail: I have no idea if it is a manifestation of the same problem. Since no one with the knowledge of the ZPT is willing to fix it, I did it for myself by setting up my svn rules to linux line endings ... But it is clearly an annoying bug. Imagine if plain Python worked that way :-( -- hilsen/regards Max M, Denmark http://www.mxm.dk/ IT's Mad Science Phone: +45 66 11 84 94 Mobile: +45 29 93 42 96 ___ Zope maillist - Zope@zope.org http://mail.zope.org/mailman/listinfo/zope ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope-dev )
