Re: [Zope-CMF] [dev] .zexp imports and notifyWorkflowCreated

2009-02-25 Thread Raphael Ritz
Charlie Clark wrote: Am 18.02.2009 um 21:51 schrieb Wichert Akkerman: In my opinion a copy should produce a full copy, including all state and history. Not sure I would agree here. For a move (cutpaste) yes but for a copy I think there are too many different use cases to justify your

Re: [Zope-CMF] [dev] .zexp imports and notifyWorkflowCreated

2009-02-25 Thread Wichert Akkerman
Previously Raphael Ritz wrote: Charlie Clark wrote: Am 18.02.2009 um 21:51 schrieb Wichert Akkerman: In my opinion a copy should produce a full copy, including all state and history. Not sure I would agree here. For a move (cutpaste) yes but for a copy I think there are too

Re: [Zope-CMF] [dev] .zexp imports and notifyWorkflowCreated

2009-02-25 Thread Charlie Clark
Am 25.02.2009 um 14:18 schrieb Wichert Akkerman: There are many use cases for both options. One aspect is that it is extremely hard to not get the current behaviour. We had to hire Philipp to write z3c.unconfigure for us just to be able to create a system to prevent CMF from making

Re: [Zope-CMF] [dev] .zexp imports and notifyWorkflowCreated

2009-02-25 Thread Raphael Ritz
Wichert Akkerman wrote: Previously Raphael Ritz wrote: Charlie Clark wrote: Am 18.02.2009 um 21:51 schrieb Wichert Akkerman: In my opinion a copy should produce a full copy, including all state and history. Not sure I would agree here. For a move (cutpaste) yes but for a copy I think

Re: [Zope-CMF] [dev] .zexp imports and notifyWorkflowCreated

2009-02-25 Thread Wichert Akkerman
Previously Charlie Clark wrote: Am 25.02.2009 um 14:18 schrieb Wichert Akkerman: There are many use cases for both options. One aspect is that it is extremely hard to not get the current behaviour. We had to hire Philipp to write z3c.unconfigure for us just to be able to create a

Re: [Zope-CMF] [dev] .zexp imports and notifyWorkflowCreated

2009-02-25 Thread Charlie Clark
Am 25.02.2009 um 16:10 schrieb Wichert Akkerman: The workflow tool is not a factor at all here. The problem is that CMF registers some event handlers that do things like clear workflow status and local roles when you create a copy. I realise that but surely the handlers can have a

Re: [Zope-CMF] [dev] .zexp imports and notifyWorkflowCreated

2009-02-25 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Wichert Akkerman wrote: Previously Charlie Clark wrote: Am 25.02.2009 um 16:10 schrieb Wichert Akkerman: The workflow tool is not a factor at all here. The problem is that CMF registers some event handlers that do things like clear workflow

Re: [Zope-CMF] [dev] .zexp imports and notifyWorkflowCreated

2009-02-25 Thread Wichert Akkerman
Previously Tres Seaver wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Wichert Akkerman wrote: Previously Charlie Clark wrote: Am 25.02.2009 um 16:10 schrieb Wichert Akkerman: The workflow tool is not a factor at all here. The problem is that CMF registers some event handlers

Re: [Zope-CMF] [dev] .zexp imports and notifyWorkflowCreated

2009-02-23 Thread Charlie Clark
Am 18.02.2009 um 21:51 schrieb Wichert Akkerman: In my opinion a copy should produce a full copy, including all state and history. Yes, in the technical sense of .copy() but I'm not sure if that is what I as a user expect in a CMS. Do I really want an exact duplicate of everything or

Re: [Zope-CMF] [dev] .zexp imports and notifyWorkflowCreated

2009-02-21 Thread Dieter Maurer
Wichert Akkerman wrote at 2009-2-18 21:51 +0100: ... That's how copy and paste resets the workflow state. Which is argueably a mis-feature: it means you are not just doing a copy and paste, but a copy, paste and modify. ... In my opinion a copy should produce a full copy, including all state

Re: [Zope-CMF] [dev] .zexp imports and notifyWorkflowCreated

2009-02-18 Thread yuppie
Hi! Tres Seaver wrote: yuppie wrote: Moving the notifyWorkflowCreated call from _finishConstruction to the IObjectAddedEvent subscriber changed the behavior of .zexp imports: The workflow state is now always reset to the initial state. AFAICT that's no useful behavior for imports. This

Re: [Zope-CMF] [dev] .zexp imports and notifyWorkflowCreated

2009-02-18 Thread Wichert Akkerman
Previously yuppie wrote: Tres Seaver wrote: yuppie wrote: Moving the notifyWorkflowCreated call from _finishConstruction to the IObjectAddedEvent subscriber changed the behavior of .zexp imports: The workflow state is now always reset to the initial state. AFAICT that's no useful

Re: [Zope-CMF] [dev] .zexp imports and notifyWorkflowCreated

2009-02-18 Thread Andrew Sawyers
On 2/18/09 12:35 PM, yuppie y.2...@wcm-solutions.de wrote: Does it make sense to keep old workflow history records after copy and paste? Or can we just remove the complete workflow_history attribute before notifyCreated is called? I think it shouldn't be kept...and over time this history tends