[Zope-CMF] Successful - CMF-trunk_Zope-trunk - Build # 872
CMF-trunk_Zope-trunk - Build # 872 - Successful: Check console output at https://jenkins.starzel.de/job/CMF-trunk_Zope-trunk/872/ to view the results.___ Zope-CMF maillist - Zope-CMF@zope.org https://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
[Zope-CMF] cmf-tests -
This is the summary for test reports received on the cmf-tests list between 2015-09-21 00:00:00 UTC and 2015-09-22 00:00:00 UTC: See the footnotes for test reports of unsuccessful builds. An up-to date view of the builders is also available in our buildbot documentation: http://docs.zope.org/zopetoolkit/process/buildbots.html#the-nightly-builds Reports received Non-OK results -- ___ Zope-CMF maillist - Zope-CMF@zope.org https://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Re: [Zope-CMF] GenericSetup: Apply profile dependencies only once
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/22/2015 06:30 AM, yuppie wrote: > -1 > > I agree with the goal to try to respect pep8 rules and to use tools > that help doing this. But this is a massive reformatting that adds a > lot of noise if you use blame or similar techniques. And I use often > diffs between different versions to understand the history of the > code. I'm -1 on that one, too, for essentially the same reasons. Tres. - -- === Tres Seaver +1 540-429-0999 tsea...@palladion.com Palladion Software "Excellence by Design"http://palladion.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJWAb/mAAoJEPKpaDSJE9HYlN4QAIaUNifw3HY9DXKEwms+y3yg hMHDtK4Y6kXZgTKQU6BvTtz9jdLhZJoAqgTgFDpjn8LCdMCgLyYa/J7ABDEWdaDk 0pWVQJCg34lIPwHHxyGV6LuV2q7Eqzt6Ht2BzeXKmzcX5650cIAnKtfrVpHfCvqW 2flThW0dl6tTds8qIml6UrQY6f2yndTGOsnTHwPIcnFJ1jgP7hj8mhS9FR6j2wx1 9NkiXbXbJFDKKU0l5QQplEGhWrBiJdeZvJl7lCluKmr3PUhnc+PNW6Cn68izxZzC 9rz0KUUvqdkMcUwEzULDu847Ubo0iN2UcdS2o0dipfBdpQ8F6s4D9e/Bc2gcZHhh Khx7VbZfU8vQI2k2Xu2BProy4oJdANf6lvuLnHJFKJdFYCpdt9n3W8Kc/IRYnLPV TCseACQZ71vkAtbWH8OBtrLmNCfaEn5N6+ckIhlX7kEOMXiFRLalxKsdxpKbl32b Yin+0Nt+iX41D4zZ6rANLmhROqj+GSvP7lzt2yA4U03fuCOFp5jLL6T3mS89Ht99 9U1wZX0GJYqcQmt0evppQdlcutJkZ3cq6l9ebU1C+YnEuhzkZvwj0bCaQgqr/lNY x3ctaxDx+MQ0uX0udT8NSMws/bWEUugojCm3hPKHOzZEwUJtsK26C0KDhAsxwT8N SDC4yNcuvHKDHYw2oJx0 =PTvJ -END PGP SIGNATURE- ___ Zope-CMF maillist - Zope-CMF@zope.org https://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Re: [Zope-CMF] GenericSetup: Apply profile dependencies only once
Op 22-09-15 om 12:30 schreef yuppie:
Hi Maurits,
Maurits van Rees wrote:
Meanwhile, I have added two more pull requests, far smaller in scope:
- Add 'unsetLastVersionForProfile' method to portal_setup. This removes
the profile id from the profile upgrade versions.
+1
Adding 'purgeProfileVersions' is also on my wish list now, which is
really simple:
portal_setup._profile_upgrade_versions = {}
There were a few problems in Plone due to my change with the dependency
strategies. I found that those were caused by importing the base Plone
profile (so no extension profile), so this ran in purge mode, which
meant several settings of add-ons were overwritten. Only a problem you
really ever encounter in test code that tries to do to much.
Purging the profile versions from portal setup helped solve this. And I
would rather call an official method than accessing the private
_profile_upgrade_versions from within Plone code.
- pep8. This fixes over 6000 pep8 errors... Most of them fixed with the
autopep8 command line tool. Small in scope yes, but due to all those
errors a *very* large pull request. All tests pass.
-1
I agree with the goal to try to respect pep8 rules and to use tools that
help doing this. But this is a massive reformatting that adds a lot of
noise if you use blame or similar techniques. And I use often diffs
between different versions to understand the history of the code.
There might be a subset of pep8 rules that is already respected in most
parts of the code and where fixing the rest wouldn't add much noise.
I can imagine your concern about reduced value for 'blame'. You can
still checkout a previous version and do the git blame there, but it is
more of a hassle, I agree. It is personal preference whether this
reduced blame value weighs more heavily than the reduced frustration of
working with ugly looking code.
But actually, it is not that bad I think. When I look at the top level
files at how many lines of them are to 'blame' on my pep8 change, I get
this table. Not sure if this gets across nice in email:
FilenameBlame Lines Percentage
__init__.py 5 55 9%
components.py 28 559 5%
content.py 25 417 6%
context.py 162 723 22%
differ.py 64 196 33%
events.py 0 55 0%
exceptions.py 0 21 0%
interfaces.py 63 847 7%
metadata.py 20 77 26%
permissions.py 0 16 0%
registry.py 44 746 6%
rolemap.py 44 219 20%
testing.py 0 178 0%
tool.py 105 14267%
upgrade.py 14 274 5%
utils.py49 927 5%
zcml.py 20 372 5%
So the file with the biggest percentage of lines changed, is differ.py
with 33 percent. We have context.py, metadata.py and rolemap.py between
20 and 26 percent. The rest is below 10 percent.
The biggest and most central one, tool.py, has 7 percent of its lines
changed.
In the tests directory things are very different, given that there are
about 5000 pep8 errors there. git itself says for three files that it
completely rewrote them:
rewrite Products/GenericSetup/tests/test_differ.py (66%)
rewrite Products/GenericSetup/tests/test_registry.py (78%)
rewrite Products/GenericSetup/tests/test_rolemap.py (64%)
But I would say for the tests a 'git blame' is less needed.
--
Maurits van Rees: http://maurits.vanrees.org/
Zest Software: http://zestsoftware.nl
___
Zope-CMF maillist - Zope-CMF@zope.org
https://mail.zope.org/mailman/listinfo/zope-cmf
See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Re: [Zope-CMF] GenericSetup: Apply profile dependencies only once
Hi Maurits, Maurits van Rees wrote: > Meanwhile, I have added two more pull requests, far smaller in scope: > > - Add 'unsetLastVersionForProfile' method to portal_setup. This removes > the profile id from the profile upgrade versions. +1 > - pep8. This fixes over 6000 pep8 errors... Most of them fixed with the > autopep8 command line tool. Small in scope yes, but due to all those > errors a *very* large pull request. All tests pass. -1 I agree with the goal to try to respect pep8 rules and to use tools that help doing this. But this is a massive reformatting that adds a lot of noise if you use blame or similar techniques. And I use often diffs between different versions to understand the history of the code. There might be a subset of pep8 rules that is already respected in most parts of the code and where fixing the rest wouldn't add much noise. Cheers, Yuppie ___ Zope-CMF maillist - Zope-CMF@zope.org https://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
