Hi Maurits,
Maurits van Rees wrote:
> Meanwhile, I have added two more pull requests, far smaller in scope:
>
> - Add 'unsetLastVersionForProfile' method to portal_setup. This removes
> the profile id from the profile upgrade versions.
+1
> - pep8. This fixes over 6000 pep8 errors... Most of them fixed with the
> autopep8 command line tool. Small in scope yes, but due to all those
> errors a *very* large pull request. All tests pass.
-1
I agree with the goal to try to respect pep8 rules and to use tools that
help doing this. But this is a massive reformatting that adds a lot of
noise if you use blame or similar techniques. And I use often diffs
between different versions to understand the history of the code.
There might be a subset of pep8 rules that is already respected in most
parts of the code and where fixing the rest wouldn't add much noise.
Cheers,
Yuppie
_______________________________________________
Zope-CMF maillist - [email protected]
https://mail.zope.org/mailman/listinfo/zope-cmf
See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
