Re: [Zope-CMF] IndexableObjectWrapper

2009-03-11 Thread yuppie
Hi Martin! Martin Aspeli wrote: > yuppie wrote: >> Martin Aspeli wrote: >>> yuppie wrote: >>> AFAICS wrapping the object before looking up adapters is unnecessary. The catalog should do the lookup directly and the existing features provided by IndexableObjectWrapper should be rei

Re: [Zope-CMF] IndexableObjectWrapper

2009-03-11 Thread Martin Aspeli
yuppie wrote: > Why is IIndexableObjectWrapper in Plone a multi-adapter and not a simple > adapter for object? Some of the indexers need access to the site root. I think the idea was that you could have different adapters in different types of sites by marking the site root, but a single adapt

Re: [Zope-CMF] IndexableObjectWrapper

2009-03-11 Thread Miles
Hi, >> Could we push this further down the stack to the ZCatalog, making it >> unnecessary to override catalog_object in CMF? AFAICS all CMF-specific >> stuff could be done inside the wrapper. > > Maybe. Touching ZCatalog is kinda scary, though. I think trying to remove catalog_object comple

Re: [Zope-CMF] IndexableObjectWrapper

2009-03-11 Thread Dieter Maurer
Wichert Akkerman wrote at 2009-3-10 10:01 +0100: > ... >The debate is currently focusing on GPL versus BSD license. Any opinions >on a choice between those two would be very welcome. I like BSD more, but could live with LGPL as well. -- Dieter ___ Zo

Re: [Zope-CMF] IndexableObjectWrapper

2009-03-11 Thread yuppie
Hi! Miles wrote: > Hi, > > > >>> Could we push this further down the stack to the ZCatalog, making it >>> unnecessary to override catalog_object in CMF? AFAICS all CMF-specific >>> stuff could be done inside the wrapper. >> Maybe. Touching ZCatalog is kinda scary, though. > > I think trying

Re: [Zope-CMF] SVN: Products.CMFCore/trunk/Products/CMFCore/tests/test_CatalogTool.py Clean out module-scope imports.

2009-03-11 Thread yuppie
Hi Tres! Tres Seaver wrote: > yuppie wrote: >> Tres Seaver wrote: >>> Log message for revision 97800: >>> Clean out module-scope imports. >>> [...] >> What was wrong with these imports? > > I don't like module-scope imports in unit tests: I want tests to > *fail*, not be skipped, when somethi