Re: [Zope-CMF] CMFDefault browser view and tests confusion

2009-05-26 Thread Jens Vagelpohl
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1


On May 24, 2009, at 14:20 , Charlie Clark wrote:

> I'm responsible for part of the mess - I replicated the doctests for
> new_folder and then set up unit tests to replace to doctests for
> consistency with other modules and for completion. The mess will be
> cleared up for 2.2 when new_folder.py formlib view will replace
> folder.py.

I have gone ahead and cleaned up the tests modules myself.

jens



-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.8 (Darwin)

iEYEARECAAYFAkob2EYACgkQRAx5nvEhZLIvtACghuO9apdIXtJm0tNzG5XBGTJW
OVkAoJhbYQUH9Wb6+Es8Grf1JhtO8XKn
=hlJU
-END PGP SIGNATURE-
___
Zope-CMF maillist  -  Zope-CMF@lists.zope.org
http://mail.zope.org/mailman/listinfo/zope-cmf

See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests


Re: [Zope-CMF] CMFDefault browser view and tests confusion

2009-05-24 Thread Charlie Clark

Am 24.05.2009 um 12:46 schrieb Jens Vagelpohl:

> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> I just fixed an issue that made it impossible to add content to a
> CMFBTreeFolder and noticed that the module CMFDefault.browser and the
> tests scattered therein are a real mess right now.
>
> Looking at the various folder modules (folder.py, new_folder.py) and
> test files (folder.txt, folder_utest.txt, tests/test_folder.py, tests/
> folder_utest.txt) it is not clear to me what's used under what
> circumstances, and what's tested. Matter of fact, the doctest files
> inside browser/ are not used at all right now because the folder
> browser/tests clobbers the browser/tests.py module.
>
> Is there a way this could be cleaned up before 2.2?

I'm responsible for part of the mess - I replicated the doctests for  
new_folder and then set up unit tests to replace to doctests for  
consistency with other modules and for completion. The mess will be  
cleared up for 2.2 when new_folder.py formlib view will replace  
folder.py.

Charlie
--
Charlie Clark
Helmholtzstr. 20
Düsseldorf
D- 40215
Tel: +49-211-938-5360
GSM: +49-178-782-6226



___
Zope-CMF maillist  -  Zope-CMF@lists.zope.org
http://mail.zope.org/mailman/listinfo/zope-cmf

See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests