Re: [Zope-dev] z3c.password and tracking failed login attempts

2010-03-24 Thread Jan-Wijbrand Kolman
Adam GROSZER agros...@gmail.com wrote: Looks good. The only weird is to define those constants in the method parameters. def _isIrrelevantRequest(self, RELEVANTlse, IRRELEVANT ue): Do you call this method from somewhere else? Maybe it would be better to change the name (and behavour)

Re: [Zope-dev] z3c.password and tracking failed login attempts

2010-03-24 Thread Adam GROSZER
Wednesday, March 24, 2010, 10:01:02 AM, you wrote: JWK I'll make a release of z3c.password then too, if you agree with that. Sure. I'd go with a minor version increment. E.g. 0.10.1. -- Best regards, Adam GROSZERmailto:agros...@gmail.com -- Quote of the day: Truth

Re: [Zope-dev] z3c.password and tracking failed login attempts

2010-03-24 Thread Jan-Wijbrand Kolman
Adam GROSZER agros...@gmail.com wrote: JWK I'll make a release of z3c.password then too, if you agree with that. Sure. I'd go with a minor version increment. E.g. 0.10.1. We were at 0.9.0, I made it a 0.10.0. Great for having these features available!! regards, jw

Re: [Zope-dev] z3c.password and tracking failed login attempts

2010-03-20 Thread Adam GROSZER
Hello Jan, Looks good. The only weird is to define those constants in the method parameters. def _isIrrelevantRequest(self, RELEVANT=False, IRRELEVANT=True): Do you call this method from somewhere else? Maybe it would be better to change the name (and behavour) to _isRelevantRequest and go

Re: [Zope-dev] z3c.password and tracking failed login attempts

2010-03-08 Thread Roger
Hi Jan Betreff: [Zope-dev] z3c.password and tracking failed login attempts Hi, A while ago I asked some questions and made some suggestions for improving how to track failed login attempts in z3c.password. Most likely these suggestions got buried in now a out-of-sight thread and