Re: [Zope-dev] [ZPT/Zope 2.10] Unicode fixes backported

2006-12-28 Thread Andreas Jung
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1



- --On 28. Dezember 2006 20:43:34 +0100 Tino Wildenhain <[EMAIL PROTECTED]> 
wrote:

> Andreas Jung schrieb:
>> -BEGIN PGP SIGNED MESSAGE-
>> Hash: SHA1
>>
>> Hi,
>>
>> as mentioned in an earlier I was working on several encoding and webdav
>> issues related to the Zope 3 ZPT integration in Zope 2.10. I backported
>> the changes to the 2.10 branch.
>>
>> The changes include an in-place migration of all ZopePageTemplate
>> instances  to unicode (through a custom __setstate__() implemenetation).
>> The migration  code tries to sniff the encoding (it knows about
>> ISO-8859-15 and UTF-8). A  custom "preferred" encoding can be specified
>> through the environment  variable $ZPT_PREFERRED_ENCODING.
>
> You should rather use config param default-zpublisher-encoding as a
> default, maybe with a fallback to (hopefully once obsolete)
> MANAGE_PAGE_CHARSET property.

The zpublisher-encoding usually must not have something to do with the 
encoding of ZPTs. The manage_page_charset would make sense since it can be 
specific to a particular subfolder. However we can't use acquisition with 
the phase where the migration happens (__setstate__()).


>
>
>> I know that this migration is a big hammer (for a minor release) however
>> I  have not found another solution to deal with the outstanding issues
>> in a  reasonable and sane way. Therefore this migration must be tested.
>> I am  thinking about a beta release for 2.10.2 in order to get the stuff
>> tested (I am also aware of the fact that most people don't test betas
>> :-))
>
> The sniffing could work however. Maybe we should have some warnings
> printed on console during zope start? Or even a "configureme" parameter
> which stopps zopes start when there is a non empty storage to migrate?
>

Zope will raise an exception if it can't autodetect the encoding. However
the current implementation does not store the changes back. So the original
data in the ZODB remains untouched until the user clicks on 'Save'.

Andreas

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (Darwin)

iD8DBQFFlCHaCJIWIbr9KYwRAlSkAKDI8gpFGq4qnjFs9NRymg3tw5fElQCfXQSF
y4sF5VjpOW0mU3qfSMNSfMg=
=pDVE
-END PGP SIGNATURE-

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] [ZPT/Zope 2.10] Unicode fixes backported

2006-12-28 Thread Tino Wildenhain

Andreas Jung schrieb:

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hi,

as mentioned in an earlier I was working on several encoding and webdav
issues related to the Zope 3 ZPT integration in Zope 2.10. I backported
the changes to the 2.10 branch.

The changes include an in-place migration of all ZopePageTemplate instances 
to unicode (through a custom __setstate__() implemenetation). The migration 
code tries to sniff the encoding (it knows about ISO-8859-15 and UTF-8). A 
custom "preferred" encoding can be specified through the environment 
variable $ZPT_PREFERRED_ENCODING.


You should rather use config param default-zpublisher-encoding as a 
default, maybe with a fallback to (hopefully once obsolete)

MANAGE_PAGE_CHARSET property.


I know that this migration is a big hammer (for a minor release) however I 
have not found another solution to deal with the outstanding issues in a 
reasonable and sane way. Therefore this migration must be tested. I am 
thinking about a beta release for 2.10.2 in order to get the stuff tested

(I am also aware of the fact that most people don't test betas :-))


The sniffing could work however. Maybe we should have some warnings
printed on console during zope start? Or even a "configureme" parameter
which stopps zopes start when there is a non empty storage to migrate?

Regards
Tino
___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
http://mail.zope.org/mailman/listinfo/zope-announce

http://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] [ZPT/Zope 2.10] Unicode fixes backported

2006-12-28 Thread Andreas Jung
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hi,

as mentioned in an earlier I was working on several encoding and webdav
issues related to the Zope 3 ZPT integration in Zope 2.10. I backported
the changes to the 2.10 branch.

The changes include an in-place migration of all ZopePageTemplate instances 
to unicode (through a custom __setstate__() implemenetation). The migration 
code tries to sniff the encoding (it knows about ISO-8859-15 and UTF-8). A 
custom "preferred" encoding can be specified through the environment 
variable $ZPT_PREFERRED_ENCODING.

I know that this migration is a big hammer (for a minor release) however I 
have not found another solution to deal with the outstanding issues in a 
reasonable and sane way. Therefore this migration must be tested. I am 
thinking about a beta release for 2.10.2 in order to get the stuff tested
(I am also aware of the fact that most people don't test betas :-))

Thoughts? Objections?

Andreas

- -- 
ZOPYX Ltd. & Co. KG - Charlottenstr. 37/1 - 72070 Tübingen - Germany
Web: www.zopyx.com - Email: [EMAIL PROTECTED] - Phone +49 - 7071 - 793376
E-Publishing, Python, Zope & Plone development, Consulting
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (Darwin)

iD8DBQFFk81+CJIWIbr9KYwRAhF9AKCTgzufb/v5VUBxQvHNbL/1GcfcfACdG9Wo
Ti+S/skHE79SXJfnjjI8gAM=
=QKf4
-END PGP SIGNATURE-

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists -
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] Zope Tests: 7 OK

2006-12-28 Thread Zope Tests Summarizer
Summary of messages to the zope-tests list.
Period Wed Dec 27 12:00:00 2006 UTC to Thu Dec 28 12:00:00 2006 UTC.
There were 7 messages: 7 from Zope Unit Tests.


Tests passed OK
---

Subject: OK : Zope-2.6 Python-2.1.3 : Linux
From: Zope Unit Tests
Date: Wed Dec 27 21:09:24 EST 2006
URL: http://mail.zope.org/pipermail/zope-tests/2006-December/006915.html

Subject: OK : Zope-2.6 Python-2.3.6 : Linux
From: Zope Unit Tests
Date: Wed Dec 27 21:10:54 EST 2006
URL: http://mail.zope.org/pipermail/zope-tests/2006-December/006916.html

Subject: OK : Zope-2.7 Python-2.3.6 : Linux
From: Zope Unit Tests
Date: Wed Dec 27 21:12:24 EST 2006
URL: http://mail.zope.org/pipermail/zope-tests/2006-December/006917.html

Subject: OK : Zope-2.8 Python-2.3.6 : Linux
From: Zope Unit Tests
Date: Wed Dec 27 21:13:54 EST 2006
URL: http://mail.zope.org/pipermail/zope-tests/2006-December/006918.html

Subject: OK : Zope-2.9 Python-2.4.4 : Linux
From: Zope Unit Tests
Date: Wed Dec 27 21:15:24 EST 2006
URL: http://mail.zope.org/pipermail/zope-tests/2006-December/006919.html

Subject: OK : Zope-2.10 Python-2.4.4 : Linux
From: Zope Unit Tests
Date: Wed Dec 27 21:16:54 EST 2006
URL: http://mail.zope.org/pipermail/zope-tests/2006-December/006920.html

Subject: OK : Zope-trunk Python-2.4.4 : Linux
From: Zope Unit Tests
Date: Wed Dec 27 21:18:24 EST 2006
URL: http://mail.zope.org/pipermail/zope-tests/2006-December/006921.html

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )