Re: [Zope-dev] Re: SVN: zope.component/ Merge wichert-utility-factories branch to trunk
Christian Theune wrote: On Fri, 2008-07-25 at 16:58 +0100, Chris Withers wrote: Wichert Akkerman wrote: -if (self._utility_registrations.get((provided, name)) +if (self._utility_registrations.get((provided, name)[:2]) Excellent catch, fixed. With a test I hope? Uh. Lol? To me this looks like an inefficiency that's gonna be hard to test from the outside. Or did I miss anything? No. Wichert. -- Wichert Akkerman<[EMAIL PROTECTED]>It is simple to make things. http://www.wiggy.net/ It is hard to make things simple. ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: SVN: zope.component/ Merge wichert-utility-factories branch to trunk
Christian Theune wrote: To me this looks like an inefficiency that's gonna be hard to test from the outside. Or did I miss anything? That's not the impression I got, which is why a test would be good... cheers, Chris -- Simplistix - Content Management, Zope & Python Consulting - http://www.simplistix.co.uk ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: SVN: zope.component/ Merge wichert-utility-factories branch to trunk
On Fri, 2008-07-25 at 16:58 +0100, Chris Withers wrote: > Wichert Akkerman wrote: > >> -if (self._utility_registrations.get((provided, name)) > >> +if (self._utility_registrations.get((provided, name)[:2]) > > > > Excellent catch, fixed. > > With a test I hope? Uh. Lol? To me this looks like an inefficiency that's gonna be hard to test from the outside. Or did I miss anything? Christian -- Christian Theune · [EMAIL PROTECTED] gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany http://gocept.com · tel +49 345 1229889 7 · fax +49 345 1229889 1 Zope and Plone consulting and development signature.asc Description: This is a digitally signed message part ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] Re: SVN: zope.component/ Merge wichert-utility-factories branch to trunk
Wichert Akkerman wrote: -if (self._utility_registrations.get((provided, name)) +if (self._utility_registrations.get((provided, name)[:2]) Excellent catch, fixed. With a test I hope? cheers, Chris -- Simplistix - Content Management, Zope & Python Consulting - http://www.simplistix.co.uk ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Zope Tests: 5 OK
Summary of messages to the zope-tests list. Period Thu Jul 24 11:00:00 2008 UTC to Fri Jul 25 11:00:00 2008 UTC. There were 5 messages: 5 from Zope Tests. Tests passed OK --- Subject: OK : Zope-2.8 Python-2.3.6 : Linux From: Zope Tests Date: Thu Jul 24 21:05:31 EDT 2008 URL: http://mail.zope.org/pipermail/zope-tests/2008-July/009905.html Subject: OK : Zope-2.9 Python-2.4.4 : Linux From: Zope Tests Date: Thu Jul 24 21:07:01 EDT 2008 URL: http://mail.zope.org/pipermail/zope-tests/2008-July/009906.html Subject: OK : Zope-2.10 Python-2.4.4 : Linux From: Zope Tests Date: Thu Jul 24 21:08:31 EDT 2008 URL: http://mail.zope.org/pipermail/zope-tests/2008-July/009907.html Subject: OK : Zope-2.11 Python-2.4.4 : Linux From: Zope Tests Date: Thu Jul 24 21:10:01 EDT 2008 URL: http://mail.zope.org/pipermail/zope-tests/2008-July/009908.html Subject: OK : Zope-trunk Python-2.4.4 : Linux From: Zope Tests Date: Thu Jul 24 21:11:31 EDT 2008 URL: http://mail.zope.org/pipermail/zope-tests/2008-July/009909.html ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
