Re: [Zope-dev] Proposal: Eliminating Globals as an import façade

2008-12-28 Thread Martin Aspeli
Tres Seaver wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > I have just checked in work on a separate branch which removes all use > of 'Globals' as an indirection for imports within the Zope2 core, > restoring the module to its original purpose, which was to hold shared > data (e.g.,

Re: [Zope-dev] Sorting for zope.index

2008-12-28 Thread Chris McDonough
Dan Korostelev wrote: > 2008/12/28 Chris McDonough : >> BTW, one optimization for fieldindex sorting that I'm fooling around with now >> (based on profiling data from a real-world application) is to: >> >> - Keep around a list of docids in forward value-sorted order. >> >> - Keey around a list of

Re: [Zope-dev] Sorting for zope.index

2008-12-28 Thread Dan Korostelev
2008/12/28 Chris McDonough : > BTW, one optimization for fieldindex sorting that I'm fooling around with now > (based on profiling data from a real-world application) is to: > > - Keep around a list of docids in forward value-sorted order. > > - Keey around a list of docids in reverse value-sorted

Re: [Zope-dev] Sorting for zope.index

2008-12-28 Thread Dan Korostelev
2008/12/28 Chris McDonough : > IMO, the cognitive cost of maintaining the write-on-read and > by-default-normalize code (imagine someone looking at this code three years > from > now) is pretty high. For example, it took me about two or three hours to > figure > out that the keyword index case

Re: [Zope-dev] Sorting for zope.index

2008-12-28 Thread Dan Korostelev
2008/12/28 Chris McDonough : > Dan Korostelev wrote: > - I'm tempted to ditch the case normalization feature of keyword indexes. > This > is actually the application's job; there's no guarantee that values that are > passed by the app will be strings. I'm not sure that anyone has actually used

Re: [Zope-dev] Sorting for zope.index

2008-12-28 Thread Chris McDonough
Dan Korostelev wrote: > Hi, Chris and other developers. > > I adapted repoze.catalog field index sorting code and tests for > standard zope.index FieldIndex and looks like it works. :) > > Though I like raising the KeyError when trying to sort docids that are > not indexed, I had to remove it fro

[Zope-dev] Zope Tests: 4 OK, 2 Failed

2008-12-28 Thread Zope Tests Summarizer
Summary of messages to the zope-tests list. Period Sat Dec 27 12:00:00 2008 UTC to Sun Dec 28 12:00:00 2008 UTC. There were 6 messages: 6 from Zope Tests. Test failures - Subject: FAILED (failures=1) : Zope-trunk Python-2.4.5 : Linux From: Zope Tests Date: Sat Dec 27 20:38:05 EST 200

Re: [Zope-dev] Sorting for zope.index

2008-12-28 Thread Dan Korostelev
Hi, Chris and other developers. I adapted repoze.catalog field index sorting code and tests for standard zope.index FieldIndex and looks like it works. :) Though I like raising the KeyError when trying to sort docids that are not indexed, I had to remove it from interface declaration, and change