Re: [Zope-dev] zope.org upgraded

2012-11-14 Thread Joshua Immanuel
Hello Johannes, On Sat, 2012-11-10 at 20:54 +0100, johannes raggam wrote: If you have some comments and suggestions regarding zope.org, drop me a mail. The pages from top-level navigation links such as sitemap, accessibility-info, contact-info and site search toolbar's text are not in English.

[Zope-dev] Small fix in Products.ZCTextIndex, how to go further?

2012-11-14 Thread Gauthier Bastien
Hi everybody, I made a small change in the current Products.ZCTextIndex product, the change can be saw here : http://svn.zope.org/Products.ZCTextIndex/trunk/src/Products/ZCTextIndex/ZCTextIndex.py?rev=128273sortby=logr2=128273r1=113689 and I added a test here

Re: [Zope-dev] Small fix in Products.ZCTextIndex, how to go further?

2012-11-14 Thread Hanno Schlichting
Hi. The change looks ok. But I think you broke an optimization. IIRC the code compares the old and new values for the index, and skips the indexing step if they are the same. The typical item.reindexObject() call sents data for all indexes, even if just one or two them have changed. The

Re: [Zope-dev] Small fix in Products.ZCTextIndex, how to go further?

2012-11-14 Thread Charlie Clark
Am 14.11.2012, 16:26 Uhr, schrieb Hanno Schlichting ha...@hannosch.eu: Hi. The change looks ok. But I think you broke an optimization. IIRC the code compares the old and new values for the index, and skips the indexing step if they are the same. The typical item.reindexObject() call sents

Re: [Zope-dev] Small fix in Products.ZCTextIndex, how to go further?

2012-11-14 Thread Gauthier Bastien
Hi Hanno, I did not know if checking the current index value could be faster or slower than indexing anyway. I think that checking the current index length could do what we need : Keeping the current code and changing this :

[Zope-dev] zope-tests - OK: 21

2012-11-14 Thread Zope tests summarizer
This is the summary for test reports received on the zope-tests list between 2012-11-13 00:00:00 UTC and 2012-11-14 00:00:00 UTC: See the footnotes for test reports of unsuccessful builds. An up-to date view of the builders is also available in our buildbot documentation: