Re: [Zope-dev] I want some Python 3 C coding style guidance.

2010-11-30 Thread Lennart Regebro
On Thu, Nov 25, 2010 at 11:37, Wichert Akkerman wrote: > On 11/25/10 11:31 , Lennart Regebro wrote: >> Which style do you prefer? I'll make zope.hookable, zope.i18nmessage >> and zope.proxy use the same style if we can agree on one. > > The second. #ifdefs in code make code hard to follow and tend

Re: [Zope-dev] I want some Python 3 C coding style guidance.

2010-11-25 Thread Wichert Akkerman
On 11/25/10 11:31 , Lennart Regebro wrote: > Which style do you prefer? I'll make zope.hookable, zope.i18nmessage > and zope.proxy use the same style if we can agree on one. The second. #ifdefs in code make code hard to follow and tend to lead to problems. FWIW the Linux kernel tree has a similar

[Zope-dev] I want some Python 3 C coding style guidance.

2010-11-25 Thread Lennart Regebro
I've been porting some zope.* modules that have C-extensions to Python 3, and with the C-preprocessor you have so many possibilities that I get all confused. So I'd like some opinions. Or onions. Or something. The big issue is the module definition, which is quite different in Python 2 and Python