[Zope-dev] Re: [Zope-Checkins] SVN: Zope/trunk/ - Collector #1323: applied patch to fix umask problem in zdctl

2005-05-31 Thread Tim Peters
[Andreas Jung]
 Log message for revision 30558:

- Collector #1323: applied patch to fix umask problem in zdctl

 Changed:
  U   Zope/trunk/doc/CHANGES.txt
  U   Zope/trunk/lib/python/zdaemon/zdctl.py

Andreas, Zope doesn't own zdaemon.  zdaemon is (so far) *copied*
into Zope from repos/main/zdaemon/trunk/.  Checkins made to a zdaemon
copy from a client project (like Zope) have no effect on the zdaemon
code.  So, for example, the zdaemon trunk is still broken, the zdaemon
copies in Zope3 and in ZODB are still broken, and the changes you
checked in to Zope's copy are likely to get lost the next time someone
copies zdaemon into Zope.

The right way to fix this in Zope is:

1. Apply the patch to repos/main/zdaemon/trunk/.
2. Make a tag of zdaemon trunk.
3. Delete (svn rm) Zope's copy of zdaemon and commit.
4. From a Zope checkout, svn propedit svn:externals lib/python, and
   add a line naming the zdaemon tag you created in step #2.

That would make zdaemon like Zope's other external code (the ZopeX3
stuff, assorted ZODB directories, and ZConfig), and the existence of a
zdaemon tag (there isn't one now) would make it easy for other
projects (like Zope3 and ZODB) to use the _same_ zdaemon code.
___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists -
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] Re: [Zope-Checkins] SVN: Zope/trunk/ - Collector #1323: applied patch to fix umask problem in zdctl

2005-05-31 Thread Tim Peters
[Andreas Jung]
 I thought Fred hooked zdaemon and ZConfig already as external definition.
 But apparently this happened only for ZConfig.

That's correct; nothing about zdaemon has changed yet.  Back on 13 May:

[me]
 The first time ZConfig and zdaemon get tagged, it's important that
 whoever do that first search all clients (ZODB and both Zopes) for
 changes to those checked in from a wrong project, and do merges back
 to ZConfig and zdaemon (I explained that dance last time) -- else
 those changes (if any) will get lost.

[you]
 That's a job for loosers :-) but I will take it over for ZConfig and
 ZDaemon.. maybe not for the next beta but hopefully for the final
 for 2.8.1 release.

so I thought you would be doing this.  Fred fixed a bug in ZConfig
since then, and did the right thing to get it fixed everywhere.  The
same hasn't been done for zdaemon yet, and I'm sure Fred won't be
doing it.

If it *had* been done already, SVN would not have allowed you to check
in a change to zdaemon made from Zope, forcing you to make the change
in the right place (i.e., in zdaemon) instead.
___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists -
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )