Re: [Zope-dev] Re: catalogObject changes (Zope-2_6-branch)

2003-10-08 Thread Leonardo Rochael Almeida
On Tue, 2003-10-07 at 21:37, Leonardo Rochael Almeida wrote: On Tue, 2003-10-07 at 16:57, Chris McDonough wrote: OK, I checked in changes on the 2.6, 2.7, and HEAD branches that add an update_metadata keyword argument to Catalog's catalogObject and ZCatalog's catalog_object. The argument

Re: [Zope-dev] Re: catalogObject changes (Zope-2_6-branch)

2003-10-08 Thread Chris Withers
Leonardo Rochael Almeida wrote: Cool! Can we get some form of 2.6.3 beta out to encourage people not to migrate to 2.6.2? Or maybe a HotFix? This isn't hotfix-related so I'd say no. Would be cool to crank out a 2.6.3 though... Chris ___ Zope-Dev

[Zope-dev] Re: catalogObject changes (Zope-2_6-branch)

2003-10-07 Thread Yuppie
Hi! Chris McDonough wrote: Option 1: Add an update_metadata flag to the catalogObject method with a default of True on all branches. Option 2: Do nothing, but add the updateMetadata method to the ZCatalog interface. Option 1 would only take effect when 2.6.3 was released (if ever) and

Re: [Zope-dev] Re: catalogObject changes (Zope-2_6-branch)

2003-10-07 Thread Casey Duncan
This is broken in 2.6.2 and I would consider it a bug in that release. I would support an improved api such as: catalog_object(obj, idxs=[], metadata=1) The way it is currently breaks at least one of my applications as well (ironically, this was an application the Chris was also working on).

Re: [Zope-dev] Re: catalogObject changes (Zope-2_6-branch)

2003-10-07 Thread Casey Duncan
On Tuesday 07 October 2003 10:41 am, Yuppie wrote: Hi! Casey Duncan wrote: This is broken in 2.6.2 and I would consider it a bug in that release. I would support an improved api such as: catalog_object(obj, idxs=[], metadata=1) I'm sure you mean catalog_object(obj, uid,

Re: [Zope-dev] Re: catalogObject changes (Zope-2_6-branch)

2003-10-07 Thread Leonardo Rochael Almeida
On Tue, 2003-10-07 at 10:52, Casey Duncan wrote: This is broken in 2.6.2 and I would consider it a bug in that release. I would support an improved api such as: catalog_object(obj, idxs=[], metadata=1) The way it is currently breaks at least one of my applications as well (ironically,

Re: [Zope-dev] Re: catalogObject changes (Zope-2_6-branch)

2003-10-07 Thread Casey Duncan
On Tuesday 07 October 2003 12:08 pm, Chris McDonough wrote: On Tue, 2003-10-07 at 09:52, Casey Duncan wrote: This is broken in 2.6.2 and I would consider it a bug in that release. I would support an improved api such as: catalog_object(obj, idxs=[], metadata=1) The way it is

Re: [Zope-dev] Re: catalogObject changes (Zope-2_6-branch)

2003-10-07 Thread Chris McDonough
On Tue, 2003-10-07 at 09:52, Casey Duncan wrote: This is broken in 2.6.2 and I would consider it a bug in that release. I would support an improved api such as: catalog_object(obj, idxs=[], metadata=1) The way it is currently breaks at least one of my applications as well (ironically,

Re: [Zope-dev] Re: catalogObject changes (Zope-2_6-branch)

2003-10-07 Thread Chris McDonough
OK, I checked in changes on the 2.6, 2.7, and HEAD branches that add an update_metadata keyword argument to Catalog's catalogObject and ZCatalog's catalog_object. The argument defaults to true. I also added some tests, and made sure that the reindexIndex method of ZCatalog took advantage of this

Re: [Zope-dev] Re: catalogObject changes (Zope-2_6-branch)

2003-10-07 Thread Leonardo Rochael Almeida
On Tue, 2003-10-07 at 16:57, Chris McDonough wrote: OK, I checked in changes on the 2.6, 2.7, and HEAD branches that add an update_metadata keyword argument to Catalog's catalogObject and ZCatalog's catalog_object. The argument defaults to true. I also added some tests, and made sure that

[Zope-dev] Re: catalogObject changes (Zope-2_6-branch)

2003-10-06 Thread Yuppie
Hi Chris! Chris McDonough wrote: The system is making the assumption that if you update indexes individually, you know what you're doing. Passing an index name into catalogObject was always meant to do as much or as little work as you specified with respect to the names of the indexes; it was

Re: [Zope-dev] Re: catalogObject changes (Zope-2_6-branch)

2003-10-06 Thread Chris McDonough
OK, I can see your point of view. Option 1: Add an update_metadata flag to the catalogObject method with a default of True on all branches. Option 2: Do nothing, but add the updateMetadata method to the ZCatalog interface. Option 1 would only take effect when 2.6.3 was released (if ever)