Re: [Zope-dev] RFC: zope.app.pagetemplate.engine dependencies
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Tres Seaver wrote: > Resolution #3 > = > > Whereas: > > - In Zope2, the 'Products.PageTemplates.Expressions' module depends > on the 'zope.app.pagetemplates.engine' module, but only uses its > 'ZopeEngine' class; > > - Zope2 further supplies its own context class (to avoid using the Zope3 > security model); > > - one remaining bit of non-overridden functionality is the Zope3- > proxified 'getFunctionNamespace' wrapper, which probably won't work > at all as intended; > > - the other bit is the use of the AdapterNamespaces bit, which feeds > into the 'getFunctionNamespace' bit; > > therefore be it resolved: > > - that we forego using the 'ZopeEngine' class completely in Zope2, > providing instead a forked / simplified implementation. Done. Zope2 no longer imports / depnds on zope.app.pagetemplate directly at all. Tres. - -- === Tres Seaver +1 540-429-0999 tsea...@palladion.com Palladion Software "Excellence by Design"http://palladion.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFKG0ef+gerLs4ltQ4RAs+NAJ9auYhR7cdjhueap2XBJHzdSNPc+ACggh9Q pEzQbdFdU6nABlVpO5HoLfU= =A4h8 -END PGP SIGNATURE- ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] RFC: zope.app.pagetemplate.engine dependencies
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Martijn Faassen wrote: > Tres Seaver wrote: >> Resolution #2 >> = >> >> Whereas: > [removing evaluateInlineCode] > > zope.app.catalog: old-fashioned HTTP log test. Not very important. > zope.app.publication: the same > zope.app.exception: the same > > zope.app.session: actually turns on evaluateInlineCode in test setup for > some reason. A discussion topic. > > zope.app.zptpage: actual code and tests that mess around with > evaluateInlineCode. A discussion topic > > zope.app.session seems to be almost wholly moved to zope.session, > leaving some ZMI stuff behind. I think this means we can safely ignore > zope.app.session. > > zope.app.zptpage is the most interesting. It maintains an > evaluateInlineCode attribute and passes it along to > zope.app.pagetemplate. Of course it also is there to support the ZMI. > Since it's unlikely anyone actually has *useful* ZPT pages with inline > code, as nobody is programming with the ZMI anyway, I propose we just > rip this support out of here. But this can be done later when we see > things break. > > +1 for removing it. Ah, the code refered to 'zope.app.pythonpage', but should have been talking about 'zope.app.zptpage'. It should be simple for that package to pick up the implementation of 'evaluateCode' and add it to a custom 'ZopeContext' derivative which it uses when evaluating the page. >> Resolution #3 >> = > > I'm fine with this, though haven't done any real analysis. :) This is a "back to the future" change (or feels like it, anyway). Tres. - -- === Tres Seaver +1 540-429-0999 tsea...@palladion.com Palladion Software "Excellence by Design"http://palladion.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFKGvvR+gerLs4ltQ4RAgOEAKDLvaaqnviDYek692cnSER/qqlFiACgmhB8 AIiZKBXxgJ/5pZFW41vAQ10= =/cMi -END PGP SIGNATURE- ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] RFC: zope.app.pagetemplate.engine dependencies
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Tres Seaver wrote: > Resolution #1 > = > > Whereas: > > - The 'zope.app.pagetemplate.engine' module pulls in nothing from > 'zope.app' packages except some antique testing support in doctest; > > - that module is potentially useful outside the scope of the Zope3 ZMI; > > therefore be it resolved: > > - that we move the 'engine' module to 'zope.pagetemplate', along with > its supporting scaffolding, and clean up the tests. Done, and released in the following: - http://pypi.python.org/pypi/zope.pagetemplate/3.5.0 - http://pypi.python.org/pypi/zope.app.pagetemplate/3.7.0 I also had to release an updated 'zope.app.publisher', in order to get the tests for 'zope.app.pagetemplate' to pass: the older version was depending on being able to import the 'engine' module from the old location: http://pypi.python.org/pypi/zope.app.publisher/3.8.1 Tres. - -- === Tres Seaver +1 540-429-0999 tsea...@palladion.com Palladion Software "Excellence by Design"http://palladion.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFKGvqk+gerLs4ltQ4RAtQVAKCCaozyXLF8zz9P7sTG/EbeFZdpeQCfRawJ wevk9XNVT7RGFRKfYV6nFJA= =tbs9 -END PGP SIGNATURE- ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] RFC: zope.app.pagetemplate.engine dependencies
Tres Seaver wrote: > Resolution #1 > = +1 > Resolution #2 > = > > Whereas: [removing evaluateInlineCode] zope.app.catalog: old-fashioned HTTP log test. Not very important. zope.app.publication: the same zope.app.exception: the same zope.app.session: actually turns on evaluateInlineCode in test setup for some reason. A discussion topic. zope.app.zptpage: actual code and tests that mess around with evaluateInlineCode. A discussion topic zope.app.session seems to be almost wholly moved to zope.session, leaving some ZMI stuff behind. I think this means we can safely ignore zope.app.session. zope.app.zptpage is the most interesting. It maintains an evaluateInlineCode attribute and passes it along to zope.app.pagetemplate. Of course it also is there to support the ZMI. Since it's unlikely anyone actually has *useful* ZPT pages with inline code, as nobody is programming with the ZMI anyway, I propose we just rip this support out of here. But this can be done later when we see things break. +1 for removing it. > Resolution #3 > = I'm fine with this, though haven't done any real analysis. :) Regards, Martijn ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] RFC: zope.app.pagetemplate.engine dependencies
Chris McDonough wrote: > On 5/25/09 12:37 PM, Tres Seaver wrote: >> >> Debate, anyone? > > +1. +1, you? ;) Hanno ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] RFC: zope.app.pagetemplate.engine dependencies
On 5/25/09 12:37 PM, Tres Seaver wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Resolution #1 > = > > Whereas: ..snip.. > Debate, anyone? +1. - C ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] RFC: zope.app.pagetemplate.engine dependencies
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Resolution #1 = Whereas: - - The 'zope.app.pagetemplate.engine' module pulls in nothing from 'zope.app' packages except some antique testing support in doctest; - - that module is potentially useful outside the scope of the Zope3 ZMI; therefore be it resolved: - - that we move the 'engine' module to 'zope.pagetemplate', along with its supporting scaffolding, and clean up the tests. Resolution #2 = Whereas: - - The 'evaluateInlineCode' support in the 'engine' module has no tests; - - its comments indicate that it exists to support 'zope.app.pythonpage', which doesn't even import the module; - - third-party consumers of the feature have a recently-released version of the egg which they can continue using indefinitely; therefore be it resolved: - - that we remove the code entirely, documenting the backward incompatibility in a new feature release. Resolution #3 = Whereas: - - In Zope2, the 'Products.PageTemplates.Expressions' module depends on the 'zope.app.pagetemplates.engine' module, but only uses its 'ZopeEngine' class; - - Zope2 further supplies its own context class (to avoid using the Zope3 security model); - - one remaining bit of non-overridden functionality is the Zope3- proxified 'getFunctionNamespace' wrapper, which probably won't work at all as intended; - - the other bit is the use of the AdapterNamespaces bit, which feeds into the 'getFunctionNamespace' bit; therefore be it resolved: - - that we forego using the 'ZopeEngine' class completely in Zope2, providing instead a forked / simplified implementation. Debate, anyone? Tres. - -- === Tres Seaver +1 540-429-0999 tsea...@palladion.com Palladion Software "Excellence by Design"http://palladion.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFKGsle+gerLs4ltQ4RAgNKAJwOyvPTdkV40l6YaE7LgXNvts9eagCdHlRF WYPBpVkAXT7nBhX9hSTj9rY= =5xWq -END PGP SIGNATURE- ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
